From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEEE3C433E0 for ; Wed, 3 Feb 2021 17:24:38 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5AC7C64F4B for ; Wed, 3 Feb 2021 17:24:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5AC7C64F4B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:46344 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l7LtN-0000rN-3W for qemu-devel@archiver.kernel.org; Wed, 03 Feb 2021 12:24:37 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:37998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l7LoV-00040p-55 for qemu-devel@nongnu.org; Wed, 03 Feb 2021 12:19:38 -0500 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]:33116) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1l7LoN-0003on-Ir for qemu-devel@nongnu.org; Wed, 03 Feb 2021 12:19:31 -0500 Received: by mail-pj1-x102d.google.com with SMTP id lw17so3687046pjb.0 for ; Wed, 03 Feb 2021 09:19:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=8Rjo9F7NYNOjMYVi19kTzo000+0RFd/XghNH/qUQdIE=; b=sIrcXGPYuIM0O00SRF/NMMoJwpSaf8j5sqaeWUFkqaBmFKWJaQj1Bh4tUFO+R2/aJW HQIsJVh/sdjeYCLwiXCRplyQT7csqgY7cAC/Ad1qlaDY9viylOe2eAdc4keXc0CArSl2 1EPJgNUUuxnusr3YWFwP6nxDSvxXraW92vMBvuTpCtzvMTwTYP0QG/c19Jh1q5cchLp6 3tyZrOVAe1VkLqbgp0NKZx7iEt5Eg9/V5wWD9xKnMt9T4UUbdTNnrXt0fF0QmwJlIiOF eMljYiLBk67xHYks4fg3AK2YrwIOpKq+QKpbfVAP/DZjVYC/mVT/fVELiwByZ/FW4qVY NW2w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8Rjo9F7NYNOjMYVi19kTzo000+0RFd/XghNH/qUQdIE=; b=VnzQ8pFZXyVjMtqTx+aNiw1Uma077St08SlwgYIPlglqy5+erU68TRTX9JsXU6GM7L CcmjDDFXfHO7yZfRDGbtBRjQhCaKz6Rl8E3Uwt7KkFEm5PTdyJYs0TI09hcCRUIz6Tzf 28+cfCd+gKHpjU5FYUCP5SAfEKjrKpnYyqKyV67uUAlyp6dlpYohyCIZmfaNyg2i0VEM SXU8O17y0X/C4mcX/LyAAgtty4OqUOpzZvOC1/fmmuf3wDbJ/2xNR/n16MAxjMiK4sDW oP0a0ayGyl8OTGNyD//CI5e5zxKKrm/7hinm0zTqsI96rKibCvhy5piF3U/RawBhHVWu +PqQ== X-Gm-Message-State: AOAM531BsSai2H5Jbk7iGntviFw6HKuKxvhwbtEJRoGWZr9ZHvnGqKup W/DKqMTsD6AjQLcIViu3x2X8Jw== X-Google-Smtp-Source: ABdhPJzmQyNPbg9gxMsI1iUMrRX3Cp7TlJiCEtPfFAu2Re7/G2FrX5HH1ZC0CDICE+HDr60+dHl0QQ== X-Received: by 2002:a17:902:cecc:b029:e1:268e:2286 with SMTP id d12-20020a170902ceccb02900e1268e2286mr3954672plg.62.1612372765059; Wed, 03 Feb 2021 09:19:25 -0800 (PST) Received: from [192.168.3.43] (cpe-66-27-222-29.hawaii.res.rr.com. [66.27.222.29]) by smtp.gmail.com with ESMTPSA id r14sm3609610pgi.27.2021.02.03.09.19.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 03 Feb 2021 09:19:24 -0800 (PST) Subject: Re: [PATCH v4 2/4] target/arm: Support AA32 DIT by moving PSTATE_SS from cpsr into env->pstate To: Rebecca Cran , qemu-devel@nongnu.org References: <20210203045816.10953-1-rebecca@nuviainc.com> <20210203045816.10953-3-rebecca@nuviainc.com> From: Richard Henderson Message-ID: Date: Wed, 3 Feb 2021 07:19:20 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210203045816.10953-3-rebecca@nuviainc.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102d; envelope-from=richard.henderson@linaro.org; helo=mail-pj1-x102d.google.com X-Spam_score_int: -22 X-Spam_score: -2.3 X-Spam_bar: -- X-Spam_report: (-2.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.178, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 2/2/21 6:58 PM, Rebecca Cran wrote: > @@ -9433,8 +9448,9 @@ static void take_aarch32_exception(CPUARMState *env, int new_mode, > * For exceptions taken to AArch32 we must clear the SS bit in both > * PSTATE and in the old-state value we save to SPSR_, so zero it now. > */ > - env->uncached_cpsr &= ~PSTATE_SS; > - env->spsr = cpsr_read(env); > + env->pstate &= ~PSTATE_SS; > + env->spsr = cpsr_read_for_spsr_elx(env); > + Again, this is the aarch32 exception path, and should not use cpsr_read_for_spsr_elx. r~