Re: [PATCH 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pavan Holla <pholla@chromium.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Subject: Re: [PATCH 3/3] platform/chrome: cros_ec_ucsi: Implement UCSI PDC driver
Date: Tue, 26 Mar 2024 09:46:26 +0100	[thread overview]
Message-ID: <a885b792-6c88-4c01-b17f-6dfb11b8fd0c@kernel.org> (raw)
In-Reply-To: <20240325-public-ucsi-h-v1-3-7c7e888edc0a@chromium.org>

On 26/03/2024 00:37, Pavan Holla wrote:
> Implementation of transport driver for UCSI. This driver will be used
> if the ChromeOS EC implements a PPM.
> 

> +static struct platform_driver cros_ucsi_driver = {
> +	.driver = {
> +		.name = DRV_NAME,
> +		.pm = &cros_ucsi_pm_ops,
> +	},
> +	.probe = cros_ucsi_probe,
> +	.remove = cros_ucsi_remove,
> +};
> +
> +module_platform_driver(cros_ucsi_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_DESCRIPTION("UCSI driver for ChromeOS EC.");
> +MODULE_ALIAS("platform:" DRV_NAME);

You should not need MODULE_ALIAS() in normal cases. If you need it,
usually it means your device ID table is wrong (e.g. misses either
entries or MODULE_DEVICE_TABLE()). MODULE_ALIAS() is not a substitute
for incomplete ID table.

Using DRV_NAME here brings even more confusion...

Best regards,
Krzysztof