* [PATCH] PCI: vmd: depend on !UML
@ 2021-08-11 14:25 Johannes Berg
2021-08-11 14:43 ` Derrick, Jonathan
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Johannes Berg @ 2021-08-11 14:25 UTC (permalink / raw)
To: linux-pci
Cc: Jonathan Derrick, Geert Uytterhoeven, linux-um, Randy Dunlap,
Johannes Berg
From: Johannes Berg <johannes.berg@intel.com>
With UML having enabled (simulated) PCI on UML, VMD breaks
allyesconfig/allmodconfig compilation because it assumes
it's running on X86_64 bare metal, and has hardcoded API
use of ARCH=x86. Make it depend on !UML to fix this.
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
---
drivers/pci/controller/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
index 64e2f5e379aa..297bbd86806a 100644
--- a/drivers/pci/controller/Kconfig
+++ b/drivers/pci/controller/Kconfig
@@ -257,7 +257,7 @@ config PCIE_TANGO_SMP8759
config and MMIO accesses.
config VMD
- depends on PCI_MSI && X86_64 && SRCU
+ depends on PCI_MSI && X86_64 && SRCU && !UML
tristate "Intel Volume Management Device Driver"
help
Adds support for the Intel Volume Management Device (VMD). VMD is a
--
2.31.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: vmd: depend on !UML
2021-08-11 14:25 [PATCH] PCI: vmd: depend on !UML Johannes Berg
@ 2021-08-11 14:43 ` Derrick, Jonathan
2021-08-11 15:43 ` Randy Dunlap
2021-10-13 14:13 ` Lorenzo Pieralisi
2 siblings, 0 replies; 6+ messages in thread
From: Derrick, Jonathan @ 2021-08-11 14:43 UTC (permalink / raw)
To: Johannes Berg, linux-pci
Cc: Geert Uytterhoeven, linux-um, Randy Dunlap, Berg, Johannes
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
On 8/11/2021 8:25 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> With UML having enabled (simulated) PCI on UML, VMD breaks
> allyesconfig/allmodconfig compilation because it assumes
> it's running on X86_64 bare metal, and has hardcoded API
> use of ARCH=x86. Make it depend on !UML to fix this.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 64e2f5e379aa..297bbd86806a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -257,7 +257,7 @@ config PCIE_TANGO_SMP8759
> config and MMIO accesses.
>
> config VMD
> - depends on PCI_MSI && X86_64 && SRCU
> + depends on PCI_MSI && X86_64 && SRCU && !UML
> tristate "Intel Volume Management Device Driver"
> help
> Adds support for the Intel Volume Management Device (VMD). VMD is a
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: vmd: depend on !UML
@ 2021-08-11 14:43 ` Derrick, Jonathan
0 siblings, 0 replies; 6+ messages in thread
From: Derrick, Jonathan @ 2021-08-11 14:43 UTC (permalink / raw)
To: Johannes Berg, linux-pci; +Cc: Geert Uytterhoeven, linux-um, Randy Dunlap, Berg
Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
On 8/11/2021 8:25 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> With UML having enabled (simulated) PCI on UML, VMD breaks
> allyesconfig/allmodconfig compilation because it assumes
> it's running on X86_64 bare metal, and has hardcoded API
> use of ARCH=x86. Make it depend on !UML to fix this.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 64e2f5e379aa..297bbd86806a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -257,7 +257,7 @@ config PCIE_TANGO_SMP8759
> config and MMIO accesses.
>
> config VMD
> - depends on PCI_MSI && X86_64 && SRCU
> + depends on PCI_MSI && X86_64 && SRCU && !UML
> tristate "Intel Volume Management Device Driver"
> help
> Adds support for the Intel Volume Management Device (VMD). VMD is a
>
_______________________________________________
linux-um mailing list
linux-um@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-um
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: vmd: depend on !UML
2021-08-11 14:25 [PATCH] PCI: vmd: depend on !UML Johannes Berg
2021-08-11 14:43 ` Derrick, Jonathan
@ 2021-08-11 15:43 ` Randy Dunlap
2021-10-13 14:13 ` Lorenzo Pieralisi
2 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-08-11 15:43 UTC (permalink / raw)
To: Johannes Berg, linux-pci
Cc: Jonathan Derrick, Geert Uytterhoeven, linux-um, Johannes Berg
On 8/11/21 7:25 AM, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> With UML having enabled (simulated) PCI on UML, VMD breaks
> allyesconfig/allmodconfig compilation because it assumes
> it's running on X86_64 bare metal, and has hardcoded API
> use of ARCH=x86. Make it depend on !UML to fix this.
>
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
> ---
> drivers/pci/controller/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
> index 64e2f5e379aa..297bbd86806a 100644
> --- a/drivers/pci/controller/Kconfig
> +++ b/drivers/pci/controller/Kconfig
> @@ -257,7 +257,7 @@ config PCIE_TANGO_SMP8759
> config and MMIO accesses.
>
> config VMD
> - depends on PCI_MSI && X86_64 && SRCU
> + depends on PCI_MSI && X86_64 && SRCU && !UML
> tristate "Intel Volume Management Device Driver"
> help
> Adds support for the Intel Volume Management Device (VMD). VMD is a
>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: vmd: depend on !UML
2021-08-11 14:43 ` Derrick, Jonathan
(?)
@ 2021-10-08 21:37 ` Randy Dunlap
-1 siblings, 0 replies; 6+ messages in thread
From: Randy Dunlap @ 2021-10-08 21:37 UTC (permalink / raw)
To: Derrick, Jonathan, Johannes Berg, linux-pci
Cc: Geert Uytterhoeven, linux-um, Berg, Johannes
On 8/11/21 7:43 AM, Derrick, Jonathan wrote:
> Reviewed-by: Jon Derrick <jonathan.derrick@intel.com>
>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Bjorn, can you merge this, please?
or did you expect it to be merged somewhere else?
thanks.
> On 8/11/2021 8:25 AM, Johannes Berg wrote:
>> From: Johannes Berg <johannes.berg@intel.com>
>>
>> With UML having enabled (simulated) PCI on UML, VMD breaks
>> allyesconfig/allmodconfig compilation because it assumes
>> it's running on X86_64 bare metal, and has hardcoded API
>> use of ARCH=x86. Make it depend on !UML to fix this.
>>
>> Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>> ---
>> drivers/pci/controller/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/pci/controller/Kconfig b/drivers/pci/controller/Kconfig
>> index 64e2f5e379aa..297bbd86806a 100644
>> --- a/drivers/pci/controller/Kconfig
>> +++ b/drivers/pci/controller/Kconfig
>> @@ -257,7 +257,7 @@ config PCIE_TANGO_SMP8759
>> config and MMIO accesses.
>>
>> config VMD
>> - depends on PCI_MSI && X86_64 && SRCU
>> + depends on PCI_MSI && X86_64 && SRCU && !UML
>> tristate "Intel Volume Management Device Driver"
>> help
>> Adds support for the Intel Volume Management Device (VMD). VMD is a
>>
--
~Randy
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] PCI: vmd: depend on !UML
2021-08-11 14:25 [PATCH] PCI: vmd: depend on !UML Johannes Berg
2021-08-11 14:43 ` Derrick, Jonathan
2021-08-11 15:43 ` Randy Dunlap
@ 2021-10-13 14:13 ` Lorenzo Pieralisi
2 siblings, 0 replies; 6+ messages in thread
From: Lorenzo Pieralisi @ 2021-10-13 14:13 UTC (permalink / raw)
To: Johannes Berg, linux-pci
Cc: Lorenzo Pieralisi, Jonathan Derrick, linux-um,
Geert Uytterhoeven, Johannes Berg, Randy Dunlap
On Wed, 11 Aug 2021 16:25:30 +0200, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> With UML having enabled (simulated) PCI on UML, VMD breaks
> allyesconfig/allmodconfig compilation because it assumes
> it's running on X86_64 bare metal, and has hardcoded API
> use of ARCH=x86. Make it depend on !UML to fix this.
>
> [...]
Applied to pci/vmd, thanks!
[1/1] PCI: vmd: depend on !UML
https://git.kernel.org/lpieralisi/pci/c/42cf2a633d
Thanks,
Lorenzo
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-10-13 14:13 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-11 14:25 [PATCH] PCI: vmd: depend on !UML Johannes Berg
2021-08-11 14:43 ` Derrick, Jonathan
2021-08-11 14:43 ` Derrick, Jonathan
2021-10-08 21:37 ` Randy Dunlap
2021-08-11 15:43 ` Randy Dunlap
2021-10-13 14:13 ` Lorenzo Pieralisi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.