From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84FAEC432BE for ; Wed, 28 Jul 2021 22:55:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 690E66101B for ; Wed, 28 Jul 2021 22:55:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232289AbhG1Wzu (ORCPT ); Wed, 28 Jul 2021 18:55:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232163AbhG1Wzt (ORCPT ); Wed, 28 Jul 2021 18:55:49 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BD683C061757; Wed, 28 Jul 2021 15:55:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=iXq6gtJgg/KgevAKbbPdcmL6v/tjqWXVyd71VWdu32g=; b=aI/AM99FpdL/zSIAo7Uo0E+CGl +6s2Jzg6JH7umPO7PnUwe9u26jTVXQ90CLsXspPyQcEh6GF7iq/xzNwOlz9QtYBUO1+Jior47Leye UHbOSgx9TfIJDmqaHIgYJpSATyZdCW09tJqjuopHP0ufQWUcBHwe0z5TPdOJcDcLU9iP6dQQr1abz ocoaW5D52xHSV9dtD/KAKwJ/Z4yAkC+zsAnAxwyZkj6mQFREHGcJ9yVQeohCgBX+xuqgGk4EodYGz wMCm3iDoURIPA+0kNsRrt1HPIOqu5kml7t1whfX/Ns632XWKij1/cjzkovQ3wo+iurrNMmiIZOtlb 1dFvZjgg==; Received: from [2601:1c0:6280:3f0::aefb] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8sSo-002Vco-EI; Wed, 28 Jul 2021 22:55:46 +0000 Subject: Re: patch suggestion: Kconfig symbols To: Joe Perches Cc: linux-kernel-mentees@lists.linuxfoundation.org, LKML , kernel-janitors References: <295b8f8c-4264-9f32-6723-9d2d574021ac@infradead.org> <09db53b9-7edf-44fc-c6b7-7c4e9198a2d4@infradead.org> <733d2747b67a8a172333b51bacbf77fe@perches.com> From: Randy Dunlap Message-ID: Date: Wed, 28 Jul 2021 15:55:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <733d2747b67a8a172333b51bacbf77fe@perches.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/28/21 2:30 PM, Joe Perches wrote: > On 2021-07-28 12:41, Randy Dunlap wrote: >> On 7/28/21 8:37 AM, Joe Perches wrote: >>> On Mon, 2021-07-26 at 17:21 -0700, Randy Dunlap wrote: >>>> Running scripts/checkkconfigsymbols.py reports several hundred (maybe thousand) >>>> Kconfig symbols that are used questionably. Lots of these are false positives >>>> but lots of the remainder could use some cleaning up. >>> [] >>>> False positive example: >>>> >>>> XCHOFFLD_MEM >>>> Referencing files: drivers/scsi/qla2xxx/qla_mbx.c >>>> Similar symbols: OF_PMEM, CXL_MEM, CXL_PMEM >>>> >>>> The Referencing source file does this: >>>> #define CONFIG_XCHOFFLD_MEM    0x3 >>>> >>>> which is legitimate, so no change is needed. >>> >>> Legitimate is perhaps dubious. >>> >>> It might be better if Kconfig has exclusive use of CONFIG_ naming so >>> renaming all the other existing CONFIG_ defines might be appropriate. >> >> I would prefer that as well -- maybe 15 years ago. >> But I think it's too invasive to make that change now. > > I do not think it's that invasive. > > It's something that doesn't have to be done immediately either. > > It's not too many macro defines and not too many uses of those defines. OK :) I'm not trying to prevent such a change. Getting the exclusive use of CONFIG_symbols being dedicated to Kconfig namespace is the bug hurdle (IMO). -- ~Randy From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 906D8C4338F for ; Wed, 28 Jul 2021 22:55:54 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1712360EFD for ; Wed, 28 Jul 2021 22:55:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1712360EFD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linuxfoundation.org Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id CDE3F405E7; Wed, 28 Jul 2021 22:55:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7b99eOmwHQ1G; Wed, 28 Jul 2021 22:55:53 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp4.osuosl.org (Postfix) with ESMTPS id EA4C2402EF; Wed, 28 Jul 2021 22:55:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C0913C0010; Wed, 28 Jul 2021 22:55:52 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [IPv6:2605:bc80:3010::133]) by lists.linuxfoundation.org (Postfix) with ESMTP id A4061C000E for ; Wed, 28 Jul 2021 22:55:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 9EF87402CB for ; Wed, 28 Jul 2021 22:55:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp2.osuosl.org (amavisd-new); dkim=pass (2048-bit key) header.d=infradead.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HTlDA795ZH9E for ; Wed, 28 Jul 2021 22:55:48 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by smtp2.osuosl.org (Postfix) with ESMTPS id 09709400EB for ; Wed, 28 Jul 2021 22:55:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=iXq6gtJgg/KgevAKbbPdcmL6v/tjqWXVyd71VWdu32g=; b=aI/AM99FpdL/zSIAo7Uo0E+CGl +6s2Jzg6JH7umPO7PnUwe9u26jTVXQ90CLsXspPyQcEh6GF7iq/xzNwOlz9QtYBUO1+Jior47Leye UHbOSgx9TfIJDmqaHIgYJpSATyZdCW09tJqjuopHP0ufQWUcBHwe0z5TPdOJcDcLU9iP6dQQr1abz ocoaW5D52xHSV9dtD/KAKwJ/Z4yAkC+zsAnAxwyZkj6mQFREHGcJ9yVQeohCgBX+xuqgGk4EodYGz wMCm3iDoURIPA+0kNsRrt1HPIOqu5kml7t1whfX/Ns632XWKij1/cjzkovQ3wo+iurrNMmiIZOtlb 1dFvZjgg==; Received: from [2601:1c0:6280:3f0::aefb] by bombadil.infradead.org with esmtpsa (Exim 4.94.2 #2 (Red Hat Linux)) id 1m8sSo-002Vco-EI; Wed, 28 Jul 2021 22:55:46 +0000 Subject: Re: patch suggestion: Kconfig symbols To: Joe Perches References: <295b8f8c-4264-9f32-6723-9d2d574021ac@infradead.org> <09db53b9-7edf-44fc-c6b7-7c4e9198a2d4@infradead.org> <733d2747b67a8a172333b51bacbf77fe@perches.com> From: Randy Dunlap Message-ID: Date: Wed, 28 Jul 2021 15:55:45 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <733d2747b67a8a172333b51bacbf77fe@perches.com> Content-Language: en-US Cc: kernel-janitors , linux-kernel-mentees@lists.linuxfoundation.org, LKML X-BeenThere: linux-kernel-mentees@lists.linuxfoundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: linux-kernel-mentees-bounces@lists.linuxfoundation.org Sender: "Linux-kernel-mentees" T24gNy8yOC8yMSAyOjMwIFBNLCBKb2UgUGVyY2hlcyB3cm90ZToKPiBPbiAyMDIxLTA3LTI4IDEy OjQxLCBSYW5keSBEdW5sYXAgd3JvdGU6Cj4+IE9uIDcvMjgvMjEgODozNyBBTSwgSm9lIFBlcmNo ZXMgd3JvdGU6Cj4+PiBPbiBNb24sIDIwMjEtMDctMjYgYXQgMTc6MjEgLTA3MDAsIFJhbmR5IER1 bmxhcCB3cm90ZToKPj4+PiBSdW5uaW5nIHNjcmlwdHMvY2hlY2trY29uZmlnc3ltYm9scy5weSBy ZXBvcnRzIHNldmVyYWwgaHVuZHJlZCAobWF5YmUgdGhvdXNhbmQpCj4+Pj4gS2NvbmZpZyBzeW1i b2xzIHRoYXQgYXJlIHVzZWQgcXVlc3Rpb25hYmx5LiBMb3RzIG9mIHRoZXNlIGFyZSBmYWxzZSBw b3NpdGl2ZXMKPj4+PiBidXQgbG90cyBvZiB0aGUgcmVtYWluZGVyIGNvdWxkIHVzZSBzb21lIGNs ZWFuaW5nIHVwLgo+Pj4gW10KPj4+PiBGYWxzZSBwb3NpdGl2ZSBleGFtcGxlOgo+Pj4+Cj4+Pj4g WENIT0ZGTERfTUVNCj4+Pj4gUmVmZXJlbmNpbmcgZmlsZXM6IGRyaXZlcnMvc2NzaS9xbGEyeHh4 L3FsYV9tYnguYwo+Pj4+IFNpbWlsYXIgc3ltYm9sczogT0ZfUE1FTSwgQ1hMX01FTSwgQ1hMX1BN RU0KPj4+Pgo+Pj4+IFRoZSBSZWZlcmVuY2luZyBzb3VyY2UgZmlsZSBkb2VzIHRoaXM6Cj4+Pj4g I2RlZmluZSBDT05GSUdfWENIT0ZGTERfTUVNwqDCoMKgIDB4Mwo+Pj4+Cj4+Pj4gd2hpY2ggaXMg bGVnaXRpbWF0ZSwgc28gbm8gY2hhbmdlIGlzIG5lZWRlZC4KPj4+Cj4+PiBMZWdpdGltYXRlIGlz IHBlcmhhcHMgZHViaW91cy4KPj4+Cj4+PiBJdCBtaWdodCBiZSBiZXR0ZXIgaWYgS2NvbmZpZyBo YXMgZXhjbHVzaXZlIHVzZSBvZiBDT05GSUdfPGZvbz4gbmFtaW5nIHNvCj4+PiByZW5hbWluZyBh bGwgdGhlIG90aGVyIGV4aXN0aW5nIENPTkZJR188Zm9vPiBkZWZpbmVzIG1pZ2h0IGJlIGFwcHJv cHJpYXRlLgo+Pgo+PiBJIHdvdWxkIHByZWZlciB0aGF0IGFzIHdlbGwgLS0gbWF5YmUgMTUgeWVh cnMgYWdvLgo+PiBCdXQgSSB0aGluayBpdCdzIHRvbyBpbnZhc2l2ZSB0byBtYWtlIHRoYXQgY2hh bmdlIG5vdy4KPiAKPiBJIGRvIG5vdCB0aGluayBpdCdzIHRoYXQgaW52YXNpdmUuCj4gCj4gSXQn cyBzb21ldGhpbmcgdGhhdCBkb2Vzbid0IGhhdmUgdG8gYmUgZG9uZSBpbW1lZGlhdGVseSBlaXRo ZXIuCj4gCj4gSXQncyBub3QgdG9vIG1hbnkgbWFjcm8gZGVmaW5lcyBhbmQgbm90IHRvbyBtYW55 IHVzZXMgb2YgdGhvc2UgZGVmaW5lcy4KCk9LIDopCgpJJ20gbm90IHRyeWluZyB0byBwcmV2ZW50 IHN1Y2ggYSBjaGFuZ2UuCgpHZXR0aW5nIHRoZSBleGNsdXNpdmUgdXNlIG9mIENPTkZJR19zeW1i b2xzIGJlaW5nIGRlZGljYXRlZCB0bwpLY29uZmlnIG5hbWVzcGFjZSBpcyB0aGUgYnVnIGh1cmRs ZSAoSU1PKS4KCi0tIAp+UmFuZHkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fCkxpbnV4LWtlcm5lbC1tZW50ZWVzIG1haWxpbmcgbGlzdApMaW51eC1rZXJu ZWwtbWVudGVlc0BsaXN0cy5saW51eGZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhm b3VuZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWtlcm5lbC1tZW50ZWVzCg==