From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 96DA7C433F5 for ; Thu, 16 Sep 2021 21:46:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 75E8A61074 for ; Thu, 16 Sep 2021 21:46:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239762AbhIPVsG (ORCPT ); Thu, 16 Sep 2021 17:48:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35612 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234847AbhIPVsF (ORCPT ); Thu, 16 Sep 2021 17:48:05 -0400 Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB672C061574 for ; Thu, 16 Sep 2021 14:46:44 -0700 (PDT) Received: by mail-pf1-x436.google.com with SMTP id j6so7227413pfa.4 for ; Thu, 16 Sep 2021 14:46:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KwmQaaY2xyRkmDA83EoBJb9N7/sEkBvqoNxQ3QK3dRA=; b=St2H/u8aa2xWuIptYLzuEuXwKVxfrSO6pzCp49SIhDtFyOW59V4MfJcm8bBZ9z8iiL HzJqsRThB3aXkXf4lVjr7wWlUIdfUnlDGnsifHPKP8umuMYwFLxUQbFm0iXmT1axGgGd d6PlNGiYO7P8+iAwsJs5esblHP+MCq2pSVI4w32+h40neeqZMa96GLrAeX8nGBr1xUR3 dwhovFw6t35dBZVG2QBItumjCNB/ENOT/NGrXKnW1sf6sJTb2lTmgHlB0TTRDnK6CZpi tl70zCuA2DkoUJEzBBF4vkMPj2HEw5IpXp+v1uakYOOVudu/URC4jXk/Rde5SgQxCwic D4oA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KwmQaaY2xyRkmDA83EoBJb9N7/sEkBvqoNxQ3QK3dRA=; b=RHTF1vEPrWUIspEXPyNNEIBG9d+o/4hKznaIkXKI6Ur1k8bk1R06HUK1UerypWkOZM PiJDFr8/Ya6CKW100H+CNlm/qdLIgrYuy52unVHZdjZUaz2EZWqjTDQtf3TrNv41QBnL T/i7Dvm+fpQYo9Vtjo+yTfUT/VZG/JAGTUiPtcUpIsQVgytNRVsL+yvBDSMsVciXAwvq ybeIJ5FzCzZo9fmZ57JjsMXbyW3C+5tKzUjgTHVF1hE0tUFvctA1OPBfGO+fwyXJ3AYn rzftKZ7ZQ/jsLGcYq+VgQURSHAiy9fP6c97iyu2rNULj9yLMESBICRs14LjxcppWzmum kERQ== X-Gm-Message-State: AOAM530S5lhUh7041VU+DPIbgkB11UBiR6MK7ivGVKqa7VB6q34VbNiF SSpxYQtxCghK0eo0Y/ZApbs= X-Google-Smtp-Source: ABdhPJy77b3lDuMT4kiYvV9TdlUJ43ODrSJGMyvVTrGJaCBRbNHFiJqk7P0dCOZCOvHCdr6dVMh1QA== X-Received: by 2002:a63:1259:: with SMTP id 25mr6913768pgs.48.1631828804387; Thu, 16 Sep 2021 14:46:44 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id l9sm8757777pjz.55.2021.09.16.14.46.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Sep 2021 14:46:42 -0700 (PDT) Subject: Re: [PATCH net-next 0/4] net: dsa: b53: Clean up CPU/IMP ports From: Florian Fainelli To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Andrew Lunn , Vivien Didelot , Vladimir Oltean , "David S . Miller" , Jakub Kicinski Cc: netdev@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= References: <20210916120354.20338-1-zajec5@gmail.com> <7c5e1cf8-2d98-91df-fc6b-f9edfa0f23c9@gmail.com> Message-ID: Date: Thu, 16 Sep 2021 14:46:35 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7c5e1cf8-2d98-91df-fc6b-f9edfa0f23c9@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 9/16/21 9:23 AM, Florian Fainelli wrote: > On 9/16/21 5:03 AM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> This has been tested on: >> >> 1. Luxul XBR-4500 with used CPU port 5 >> [ 8.361438] b53-srab-switch 18007000.ethernet-switch: found switch: BCM53012, rev 0 >> >> 2. Netgear R8000 with used CPU port 8 >> [ 4.453858] b53-srab-switch 18007000.ethernet-switch: found switch: BCM53012, rev 5 > > These look good at first glance, let me give them a try on 7445 and 7278 > at least before responding with Reviewed-by/Tested-by tags, thanks! > Found some issues on 7445 and 7278 while moving to the latest net-next which I will be addressing but this worked nicely. What do you think about removing dev->enabled_ports and b53_for_each_port entirely and using a DSA helper that iterates over the switch's port list? Now that we have dev->num_ports accurately reflect the number of ports it should be equivalent. -- Florian