From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11A6BC433E0 for ; Wed, 27 Jan 2021 06:54:36 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1464720729 for ; Wed, 27 Jan 2021 06:54:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1464720729 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=weilnetz.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:43098 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1l4eio-0003h4-5e for qemu-devel@archiver.kernel.org; Wed, 27 Jan 2021 01:54:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50804) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4ehZ-0002up-K8 for qemu-devel@nongnu.org; Wed, 27 Jan 2021 01:53:17 -0500 Received: from mail.weilnetz.de ([37.120.169.71]:43866 helo=mail.v2201612906741603.powersrv.de) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1l4ehX-0000IV-Bl for qemu-devel@nongnu.org; Wed, 27 Jan 2021 01:53:17 -0500 Received: from edv-macbook-pro.fritz.box (p5b1511bf.dip0.t-ipconnect.de [91.21.17.191]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.v2201612906741603.powersrv.de (Postfix) with ESMTPSA id 01419DA14DC; Wed, 27 Jan 2021 07:53:12 +0100 (CET) To: Richard Henderson , =?UTF-8?Q?Alex_Benn=c3=a9e?= References: <20210125144530.2837481-1-philmd@redhat.com> <20210125144530.2837481-5-philmd@redhat.com> <20210125164746.GE3538803@redhat.com> <992cbe66-dfae-7950-0d92-516b2f0c9717@redhat.com> <9f22d4b0-34ca-6798-3661-36057609c152@weilnetz.de> <30cc0c14-fbec-bb21-2b6b-8e295029bc1f@linaro.org> <8f1f2dc6-5ad2-7d48-c2f9-9afa1e4d4065@weilnetz.de> <81c810b4-1bd3-631d-4b5b-7e54a27a5b4c@linaro.org> <875z3jy3tt.fsf@linaro.org> <89209f1b-29ad-e5df-6d45-b2480db4775e@weilnetz.de> From: Stefan Weil Subject: Re: [PATCH v4 4/4] meson: Warn when TCI is selected but TCG backend is available Message-ID: Date: Wed, 27 Jan 2021 07:53:14 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=37.120.169.71; envelope-from=sw@weilnetz.de; helo=mail.v2201612906741603.powersrv.de X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, NICE_REPLY_A=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Thomas Huth , =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= , qemu-devel@nongnu.org, Paolo Bonzini Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Am 26.01.21 um 23:39 schrieb Richard Henderson: > On 1/26/21 9:44 AM, Stefan Weil wrote: >> I was not talking about the TODO assertions. When I wrote TCI, I only = enabled >> and included code which was triggered by my testing - that's why I sai= d the >> productive code lines have 100 % test coverage. TODO assertions are no= t >> productive code, but debug code which were made to detect new test cas= es. They >> were successful, too, because they were triggered by some tests in `ma= ke >> check-tcg`. > The TODO assertions are all bugs. > > Any *real* dead code detection should have been done in > tcg/tci/tcg-target.c.inc. What's interpreted in tcg/tci.c should be ex= actly > what is produced on the other side, and you are producing more than you= are > consuming. Unless the TCG opcodes in tcg/tci/tcg-target.c.inc are used in real-live = scenarios, they are dead code, too. Writing a test case which produces them directly (not for some real=20 architecture) is not a real-live scenario. And the remaining TODO assertions are a good indicator that the current=20 tests are incomplete for native TCG because they obviously don't cover=20 all TCG opcodes. Stefan