Re: [Buildroot] [PATCH v3 6/7] package/zsh: Enable dynamic modules

[Arnout Vandecappelle <arnout@mind.be>]

On 22/02/2022 11:22, Norbert Lange wrote:
> The autoconf scripts seem to assume that no dynamic loader
> is available if crosscompiling.
> This results in only a small set of modules being enabled
> and linked statically.
> 
> For comparison, debian patches the fallback to enable
> dynamic modules (unconditionally).
> 
> This commit enables modules if shared libraries are enabled.

  While reviewing this, I noticed that there are many more things that zsh uses 
TRY_RUN for, so I'll send a patch with more cache variable overrides.

> 
> Signed-off-by: Norbert Lange <nolange79@gmail.com>
> 
> ---
> v1:
> -   so far only tested with glibc

  Perhaps we need a runtime test? I'm not actually worried about non-glibc 
libraries (though I would make the runtime test with uclibc). It would however 
be useful to have a runtime test that checks 32 and 64 bit targets - the patch 
that I'm sending is mainly about that. Currently it always assumes 32 bit (which 
I guess is mostly OK anyway).

  Regards,
  Arnout

> ---
>   package/zsh/zsh.mk | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/package/zsh/zsh.mk b/package/zsh/zsh.mk
> index c5ab7c2fae..c26a00c430 100644
> --- a/package/zsh/zsh.mk
> +++ b/package/zsh/zsh.mk
> @@ -36,6 +36,14 @@ else
>   ZSH_CONF_OPTS += --disable-pcre
>   endif
>   
> +ifneq ($(BR2_STATIC_LIBS),y)
> +# zsh assumes shared libs to be not available when crosscompiling
> +ZSH_CONF_OPTS += zsh_cv_shared_environ=yes zsh_cv_shared_tgetent=yes \
> +	zsh_cv_shared_tigetstr=yes zsh_cv_sys_dynamic_clash_ok=yes \
> +	zsh_cv_sys_dynamic_rtld_global=yes zsh_cv_sys_dynamic_execsyms=yes \
> +	zsh_cv_sys_dynamic_strip_exe=yes zsh_cv_sys_dynamic_strip_lib=yes
> +endif
> +
>   # Add /bin/zsh to /etc/shells otherwise some login tools like dropbear
>   # can reject the user connection. See man shells.
>   define ZSH_ADD_ZSH_TO_SHELLS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot