From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [PATCH v3 02/27] net/ena: update ena_com to the
 newer version
Date: Fri, 8 Jun 2018 20:43:07 +0100
Message-ID: <a8be4828-323c-31be-475a-1380c506acb9@intel.com>
References: <20180607094322.14312-1-mk@semihalf.com>
 <20180607094322.14312-2-mk@semihalf.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org, matua@amazon.com, Rafal Kozik <rk@semihalf.com>
To: Michal Krawczyk <mk@semihalf.com>, Marcin Wojtas <mw@semihalf.com>,
 Guy Tzalik <gtzalik@amazon.com>, Evgeny Schemeilin <evgenys@amazon.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 7505E1CDF5
 for <dev@dpdk.org>; Fri,  8 Jun 2018 21:43:12 +0200 (CEST)
In-Reply-To: <20180607094322.14312-2-mk@semihalf.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 6/7/2018 10:42 AM, Michal Krawczyk wrote:
> ena_com is the HAL provided by the vendor and it shouldn't be modified
> by the driver developers.
> 
> The PMD and platform file was adjusted for the new version of the
> ena_com:
>     * Do not use deprecated meta descriptor fields
>     * Add empty AENQ handler structure with unimplemented handlers
>     * Add memzone allocations count to ena_ethdev.c file - it was
>       removed from ena_com.c file
>     * Add new macros used in new ena_com files
>     * Use error code ENA_COM_UNSUPPORTED instead of ENA_COM_PERMISSION
> 
> Signed-off-by: Michal Krawczyk <mk@semihalf.com>
> Signed-off-by: Rafal Kozik <rk@semihalf.com>

<...>

> @@ -1840,7 +1844,7 @@ void ena_com_aenq_intr_handler(struct ena_com_dev *dev, void *data)
>  		ena_trc_dbg("AENQ! Group[%x] Syndrom[%x] timestamp: [%llus]\n",
>  			    aenq_common->group,
>  			    aenq_common->syndrom,
> -			    (unsigned long long)aenq_common->timestamp_low +
> +			    (u64)aenq_common->timestamp_low +

This is causing build error [1], please check with DEBUG enabled.

[1]
.../drivers/net/ena/base/ena_com.c:1847:8: error: format specifies type
'unsigned long long' but the argument has type 'unsigned long' [-Werror,-Wformat]
                            (u64)aenq_common->timestamp_low +
                            ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
.../drivers/net/ena/base/ena_plat_dpdk.h:129:59: note: expanded from macro
'ena_trc_dbg'
        RTE_LOG(DEBUG, PMD, "[ENA_COM: %s] " format, __func__, ##arg)
                                                                 ^~~
.../x86_64-native-linuxapp-clang/include/rte_log.h:322:32: note: expanded from
macro 'RTE_LOG'
                 RTE_LOGTYPE_ ## t, # t ": " __VA_ARGS__)
                                             ^~~~~~~~~~~
1 error generated.