From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB0DCC432BE for ; Mon, 26 Jul 2021 11:31:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 93F3960EB2 for ; Mon, 26 Jul 2021 11:31:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233433AbhGZKux (ORCPT ); Mon, 26 Jul 2021 06:50:53 -0400 Received: from mailgw02.mediatek.com ([210.61.82.184]:52452 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S233162AbhGZKuw (ORCPT ); Mon, 26 Jul 2021 06:50:52 -0400 X-UUID: 8accbbb64a9d41b086ba4a9e510bb324-20210726 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=SvbcylQIDwYvhf0Wwa/jBlMORZrzYSGu9JBqThQEr2E=; b=rKFkTeqSNbEwCgCxyr/AB/tUYOp3cspJ++Td6m/QtSYorwPfY2/W0tnybKz+oM2ZRebOFOhIFrZ9dcpovkX1WnD2Upcgg0fuUosk6kvJKZ5wStKAt1YyJlfYeOInKw3jasX0AYe20c7DpU5+cqhnWK46oCGWC9/pBsdoBuSMSyc=; X-UUID: 8accbbb64a9d41b086ba4a9e510bb324-20210726 Received: from mtkmbs10n1.mediatek.inc [(172.21.101.34)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 661082176; Mon, 26 Jul 2021 19:31:18 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 19:31:17 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 26 Jul 2021 19:31:16 +0800 Message-ID: Subject: Re: [v3 5/5] soc: mediatek: pm-domains: Remove unused macro From: Chun-Jie Chen To: Chen-Yu Tsai CC: Enric Balletbo i Serra , Matthias Brugger , Nicolas Boichat , "Rob Herring" , , LKML , , , srv_heupstream , Project_Global_Chrome_Upstream_Group Date: Mon, 26 Jul 2021 19:31:16 +0800 In-Reply-To: References: <20210705054111.4473-1-chun-jie.chen@mediatek.com> <20210705054111.4473-6-chun-jie.chen@mediatek.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N Content-Transfer-Encoding: base64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org T24gVGh1LCAyMDIxLTA3LTE1IGF0IDE0OjQwICswODAwLCBDaGVuLVl1IFRzYWkgd3JvdGU6DQo+ IE9uIE1vbiwgSnVsIDUsIDIwMjEgYXQgMTo0OCBQTSBDaHVuLUppZSBDaGVuIDwNCj4gY2h1bi1q aWUuY2hlbkBtZWRpYXRlay5jb20+IHdyb3RlOg0KPiA+IA0KPiA+IER1ZSB0byBjbGsgcmVzb3Vy Y2UgZGF0YSB3aWxsIGJlIGFsbG9jYXRlZCBkeW5hbWljYWxseSBieQ0KPiA+IHNlYXJjaGluZyBw YXJlbnQgY291bnQgb2YgY2xrIGluIHBvd2VyIGRvbWFpbiBub2RlLCBzbyByZW1vdmUNCj4gPiB0 aGUgdW51c2VkIG1hcmNvIE1BWF9TVUJTWVNfQ0xLUyBmb3Igc3RhdGljIGFsbG9jYXRpb24uDQo+ ID4gDQo+ID4gU2lnbmVkLW9mZi1ieTogQ2h1bi1KaWUgQ2hlbiA8Y2h1bi1qaWUuY2hlbkBtZWRp YXRlay5jb20+DQo+ID4gUmV2aWV3ZWQtYnk6IEVucmljIEJhbGxldGJvIGkgU2VycmEgPGVucmlj LmJhbGxldGJvQGNvbGxhYm9yYS5jb20+DQo+ID4gLS0tDQo+ID4gIGRyaXZlcnMvc29jL21lZGlh dGVrL210ay1wbS1kb21haW5zLmggfCAyIC0tDQo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAyIGRlbGV0 aW9ucygtKQ0KPiA+IA0KPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGst cG0tZG9tYWlucy5oDQo+ID4gYi9kcml2ZXJzL3NvYy9tZWRpYXRlay9tdGstcG0tZG9tYWlucy5o DQo+ID4gaW5kZXggY2FhYTM4MTAwMDkzLi4xYjg5NjdiOTgyOWUgMTAwNjQ0DQo+ID4gLS0tIGEv ZHJpdmVycy9zb2MvbWVkaWF0ZWsvbXRrLXBtLWRvbWFpbnMuaA0KPiA+ICsrKyBiL2RyaXZlcnMv c29jL21lZGlhdGVrL210ay1wbS1kb21haW5zLmgNCj4gPiBAQCAtNzIsOCArNzIsNiBAQCBzdHJ1 Y3Qgc2Nwc3lzX2J1c19wcm90X2RhdGEgew0KPiA+ICAgICAgICAgYm9vbCBpZ25vcmVfY2xyX2Fj azsNCj4gPiAgfTsNCj4gPiANCj4gPiAtI2RlZmluZSBNQVhfU1VCU1lTX0NMS1MgMTANCj4gPiAt DQo+IA0KPiBGdXR1cmUgYWR2aWNlOiBjbGVhbnVwcyBsaWtlIHRoaXMgYW5kIG90aGVyIGZpeGVz IHNob3VsZCBiZSBwdXQgaW4NCj4gdGhlDQo+IGZyb250IG9mIHRoZSBzZXJpZXMsIGJlZm9yZSBh bnkgcGF0Y2hlcyB0aGF0IGludHJvZHVjZSBzdXBwb3J0IGZvcg0KPiBuZXcNCj4gZmVhdHVyZXMg b3IgaGFyZHdhcmUuIFRoYXQgd2F5IGlmIHRoZSBuZXcgY29kZSBzdGlsbCBuZWVkcyB3b3JrLA0K PiBtYWludGFpbmVycyBjYW4gb3B0aW9uYWxseSBhcHBseSB0aGUgZml4ZXMgc28geW91IGRvbid0 IGhhdmUgdG8gY2FycnkNCj4gYSBsYXJnZSBwYXRjaCBzZXJpZXMgZm9yd2FyZC4NCj4gDQo+IENo ZW5ZdQ0KPiANCk9rLCBJIHdpbGwgcmUtb3JkZXIgdGhlIHBhdGNoZXMgaW4gbmV4dCBzZXJpZXMu DQpUaGFua3MgZm9yIHlvdXIgY29tbWVudC4NCg0KQmVzdCBSZWdhcmRzLA0KQ2h1bi1KaWUNCg0K PiA+ICAvKioNCj4gPiAgICogc3RydWN0IHNjcHN5c19kb21haW5fZGF0YSAtIHNjcCBkb21haW4g ZGF0YSBmb3IgcG93ZXIgb24vb2ZmDQo+ID4gZmxvdw0KPiA+ICAgKiBAbmFtZTogVGhlIG5hbWUg b2YgdGhlIHBvd2VyIGRvbWFpbi4NCj4gPiAtLQ0KPiA+IDIuMTguMA0KPiA+IF9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4gTGludXgtbWVkaWF0ZWsg bWFpbGluZyBsaXN0DQo+ID4gTGludXgtbWVkaWF0ZWtAbGlzdHMuaW5mcmFkZWFkLm9yZw0KPiA+ IA0KaHR0cHM6Ly91cmxkZWZlbnNlLmNvbS92My9fX2h0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtbWVkaWF0ZWtfXzshIUNUUk5LQTl3TWcwQVJidyEybF82 aS1NZHJmMjcwZVZLb281OWNsQ25PVlpvaTV3bEJFdUhGQWZyaVR2YVNzcnY2TG9jOEhKYnQ3SzhM ZXhJSld1UiQNCj4gPiAgDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D8B1C4338F for ; Mon, 26 Jul 2021 11:31:52 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EB58860527 for ; Mon, 26 Jul 2021 11:31:51 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org EB58860527 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kdWdzuQpTeqosbAoHtkIfRdhjIcAX6tXk8/+/FGDu3I=; b=M5Zgjv3tFuXAkt 5Greg469SwZPgmA5PmG7rD+6wmuDJU6ZlqhWLFKXDNwO9uvVZDcYz/fwrod43iyMrW4Oei0tQuBu7 ZnyMo3GyyEg5M5/0HBEpNxHo6vblMEYxzqP+WPSaZgldltLj7NGDCTI9UO0uCIuoAkbRTFPmCEHMB 2B+AJhzELXfCOYdUO9mDaS+lTuggwrhWpNyMbsq9R9DB2NFKApGwdxaXZ+e9yu9JiYuMLl8qc+oG4 JEyGeFqImmIHqpYRMCW28IUoj58Qy5YD9YhC//TySMPtHj4AZFRCOXacwdjqk2DB6Q/a8Obtr+4W4 uAUJ2W6lKWvrYjeWHd4A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7ypc-00B0sH-MD; Mon, 26 Jul 2021 11:31:36 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7ypQ-00B0qU-2V; Mon, 26 Jul 2021 11:31:25 +0000 X-UUID: e388e0efdbd3417bb92a1a8edb76aeb8-20210726 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=SvbcylQIDwYvhf0Wwa/jBlMORZrzYSGu9JBqThQEr2E=; b=rKFkTeqSNbEwCgCxyr/AB/tUYOp3cspJ++Td6m/QtSYorwPfY2/W0tnybKz+oM2ZRebOFOhIFrZ9dcpovkX1WnD2Upcgg0fuUosk6kvJKZ5wStKAt1YyJlfYeOInKw3jasX0AYe20c7DpU5+cqhnWK46oCGWC9/pBsdoBuSMSyc=; X-UUID: e388e0efdbd3417bb92a1a8edb76aeb8-20210726 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 66268680; Mon, 26 Jul 2021 04:31:20 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 04:31:18 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 19:31:17 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 26 Jul 2021 19:31:16 +0800 Message-ID: Subject: Re: [v3 5/5] soc: mediatek: pm-domains: Remove unused macro From: Chun-Jie Chen To: Chen-Yu Tsai CC: Enric Balletbo i Serra , Matthias Brugger , Nicolas Boichat , "Rob Herring" , , LKML , , , srv_heupstream , Project_Global_Chrome_Upstream_Group Date: Mon, 26 Jul 2021 19:31:16 +0800 In-Reply-To: References: <20210705054111.4473-1-chun-jie.chen@mediatek.com> <20210705054111.4473-6-chun-jie.chen@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_043124_159454_68B86378 X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, 2021-07-15 at 14:40 +0800, Chen-Yu Tsai wrote: > On Mon, Jul 5, 2021 at 1:48 PM Chun-Jie Chen < > chun-jie.chen@mediatek.com> wrote: > > > > Due to clk resource data will be allocated dynamically by > > searching parent count of clk in power domain node, so remove > > the unused marco MAX_SUBSYS_CLKS for static allocation. > > > > Signed-off-by: Chun-Jie Chen > > Reviewed-by: Enric Balletbo i Serra > > --- > > drivers/soc/mediatek/mtk-pm-domains.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h > > b/drivers/soc/mediatek/mtk-pm-domains.h > > index caaa38100093..1b8967b9829e 100644 > > --- a/drivers/soc/mediatek/mtk-pm-domains.h > > +++ b/drivers/soc/mediatek/mtk-pm-domains.h > > @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data { > > bool ignore_clr_ack; > > }; > > > > -#define MAX_SUBSYS_CLKS 10 > > - > > Future advice: cleanups like this and other fixes should be put in > the > front of the series, before any patches that introduce support for > new > features or hardware. That way if the new code still needs work, > maintainers can optionally apply the fixes so you don't have to carry > a large patch series forward. > > ChenYu > Ok, I will re-order the patches in next series. Thanks for your comment. Best Regards, Chun-Jie > > /** > > * struct scpsys_domain_data - scp domain data for power on/off > > flow > > * @name: The name of the power domain. > > -- > > 2.18.0 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!2l_6i-Mdrf270eVKoo59clCnOVZoi5wlBEuHFAfriTvaSsrv6Loc8HJbt7K8LexIJWuR$ > > _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A2691C4338F for ; Mon, 26 Jul 2021 11:33:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 6F7B560EB2 for ; Mon, 26 Jul 2021 11:33:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 6F7B560EB2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iAYe4Ke9HhQ4WUz419d/yyfs+D8aQ+AHvc2sobGYsX4=; b=kp+kWjyhTG2bCe mPrUj0nkBQcfIn9Ofmj1idPjJxeLM0ewcjfwQcXc2paKTgMQbx5fa98rCBCtKfVbgLxJOK1MlfKBi IIo/as2kIr6rcOgqJZ0vTW1ZQCS64vqrMkhTthENgtT3z6eCmZFjxilQJLt5SFC7W6iXdobZW5C6o 96DkbeIetWmm4vl93/jZpVdHqaQId/unWfq6fCcVrcIhjoAzjNf4DR6OYqe6KIndEIJYnr8U2Retv i3J2VjKMUE08Ovb5sBRRFa71FT6iP3LZlDX0uD7sYhWogD9m6Gfgby5EJaH6SwiPNH6POEE2bn/pD 49C+68UErAAkjpvpGzmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7ypT-00B0rM-79; Mon, 26 Jul 2021 11:31:27 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m7ypQ-00B0qU-2V; Mon, 26 Jul 2021 11:31:25 +0000 X-UUID: e388e0efdbd3417bb92a1a8edb76aeb8-20210726 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=SvbcylQIDwYvhf0Wwa/jBlMORZrzYSGu9JBqThQEr2E=; b=rKFkTeqSNbEwCgCxyr/AB/tUYOp3cspJ++Td6m/QtSYorwPfY2/W0tnybKz+oM2ZRebOFOhIFrZ9dcpovkX1WnD2Upcgg0fuUosk6kvJKZ5wStKAt1YyJlfYeOInKw3jasX0AYe20c7DpU5+cqhnWK46oCGWC9/pBsdoBuSMSyc=; X-UUID: e388e0efdbd3417bb92a1a8edb76aeb8-20210726 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 66268680; Mon, 26 Jul 2021 04:31:20 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 04:31:18 -0700 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 26 Jul 2021 19:31:17 +0800 Received: from mtksdccf07 (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 26 Jul 2021 19:31:16 +0800 Message-ID: Subject: Re: [v3 5/5] soc: mediatek: pm-domains: Remove unused macro From: Chun-Jie Chen To: Chen-Yu Tsai CC: Enric Balletbo i Serra , Matthias Brugger , Nicolas Boichat , "Rob Herring" , , LKML , , , srv_heupstream , Project_Global_Chrome_Upstream_Group Date: Mon, 26 Jul 2021 19:31:16 +0800 In-Reply-To: References: <20210705054111.4473-1-chun-jie.chen@mediatek.com> <20210705054111.4473-6-chun-jie.chen@mediatek.com> X-Mailer: Evolution 3.28.5-0ubuntu0.18.04.2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210726_043124_159454_68B86378 X-CRM114-Status: GOOD ( 22.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-07-15 at 14:40 +0800, Chen-Yu Tsai wrote: > On Mon, Jul 5, 2021 at 1:48 PM Chun-Jie Chen < > chun-jie.chen@mediatek.com> wrote: > > > > Due to clk resource data will be allocated dynamically by > > searching parent count of clk in power domain node, so remove > > the unused marco MAX_SUBSYS_CLKS for static allocation. > > > > Signed-off-by: Chun-Jie Chen > > Reviewed-by: Enric Balletbo i Serra > > --- > > drivers/soc/mediatek/mtk-pm-domains.h | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git a/drivers/soc/mediatek/mtk-pm-domains.h > > b/drivers/soc/mediatek/mtk-pm-domains.h > > index caaa38100093..1b8967b9829e 100644 > > --- a/drivers/soc/mediatek/mtk-pm-domains.h > > +++ b/drivers/soc/mediatek/mtk-pm-domains.h > > @@ -72,8 +72,6 @@ struct scpsys_bus_prot_data { > > bool ignore_clr_ack; > > }; > > > > -#define MAX_SUBSYS_CLKS 10 > > - > > Future advice: cleanups like this and other fixes should be put in > the > front of the series, before any patches that introduce support for > new > features or hardware. That way if the new code still needs work, > maintainers can optionally apply the fixes so you don't have to carry > a large patch series forward. > > ChenYu > Ok, I will re-order the patches in next series. Thanks for your comment. Best Regards, Chun-Jie > > /** > > * struct scpsys_domain_data - scp domain data for power on/off > > flow > > * @name: The name of the power domain. > > -- > > 2.18.0 > > _______________________________________________ > > Linux-mediatek mailing list > > Linux-mediatek@lists.infradead.org > > https://urldefense.com/v3/__http://lists.infradead.org/mailman/listinfo/linux-mediatek__;!!CTRNKA9wMg0ARbw!2l_6i-Mdrf270eVKoo59clCnOVZoi5wlBEuHFAfriTvaSsrv6Loc8HJbt7K8LexIJWuR$ > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel