From: "Philippe Mathieu-Daudé" <f4bug@amsat.org>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, Thomas Huth <thuth@redhat.com>,
Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [PULL 2/5] Remove the deprecated moxie target
Date: Wed, 12 May 2021 18:37:55 +0200 [thread overview]
Message-ID: <a8c579c8-e361-e3ef-0f4d-d902e12c7525@amsat.org> (raw)
In-Reply-To: <20210512162412.338120-3-armbru@redhat.com>
On 5/12/21 6:24 PM, Markus Armbruster wrote:
> From: Thomas Huth <thuth@redhat.com>
>
> There are no known users of this CPU anymore, and there are no
> binaries available online which could be used for regression tests,
> so the code has likely completely bit-rotten already. It's been
> marked as deprecated since two releases now and nobody spoke up
> that there is still a need to keep it, thus let's remove it now.
Isn't it already in a pull request sent by Thomas last week?
(I ask because I based a pair of branches on it)
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> Message-Id: <20210430160355.698194-1-thuth@redhat.com>
> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
> [Commit message typos fixed, trivial conflicts resolved]
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> docs/system/deprecated.rst | 8 -
> docs/system/removed-features.rst | 7 +
> default-configs/devices/moxie-softmmu.mak | 5 -
> default-configs/targets/moxie-softmmu.mak | 2 -
> meson.build | 1 -
> qapi/machine.json | 2 +-
> qapi/misc-target.json | 2 +-
> include/disas/dis-asm.h | 1 -
> include/elf.h | 3 -
> include/exec/poison.h | 2 -
> include/hw/elf_ops.h | 8 -
> include/sysemu/arch_init.h | 1 -
> target/moxie/cpu-param.h | 17 -
> target/moxie/cpu.h | 123 ---
> target/moxie/helper.h | 5 -
> target/moxie/machine.h | 1 -
> target/moxie/mmu.h | 19 -
> disas/moxie.c | 360 ---------
> hw/moxie/moxiesim.c | 155 ----
> softmmu/arch_init.c | 2 -
> target/moxie/cpu.c | 161 ----
> target/moxie/helper.c | 120 ---
> target/moxie/machine.c | 19 -
> target/moxie/mmu.c | 32 -
> target/moxie/translate.c | 892 ----------------------
> tests/qtest/boot-serial-test.c | 8 -
> tests/qtest/machine-none-test.c | 1 -
> fpu/softfloat-specialize.c.inc | 2 +-
> .gitlab-ci.yml | 6 +-
> MAINTAINERS | 8 -
> disas/meson.build | 1 -
> hw/Kconfig | 1 -
> hw/meson.build | 1 -
> hw/moxie/Kconfig | 3 -
> hw/moxie/meson.build | 4 -
> target/meson.build | 1 -
> target/moxie/meson.build | 14 -
> tests/qtest/meson.build | 2 -
> 38 files changed, 13 insertions(+), 1987 deletions(-)
> delete mode 100644 default-configs/devices/moxie-softmmu.mak
> delete mode 100644 default-configs/targets/moxie-softmmu.mak
> delete mode 100644 target/moxie/cpu-param.h
> delete mode 100644 target/moxie/cpu.h
> delete mode 100644 target/moxie/helper.h
> delete mode 100644 target/moxie/machine.h
> delete mode 100644 target/moxie/mmu.h
> delete mode 100644 disas/moxie.c
> delete mode 100644 hw/moxie/moxiesim.c
> delete mode 100644 target/moxie/cpu.c
> delete mode 100644 target/moxie/helper.c
> delete mode 100644 target/moxie/machine.c
> delete mode 100644 target/moxie/mmu.c
> delete mode 100644 target/moxie/translate.c
> delete mode 100644 hw/moxie/Kconfig
> delete mode 100644 hw/moxie/meson.build
> delete mode 100644 target/moxie/meson.build
next prev parent reply other threads:[~2021-05-12 16:39 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-12 16:24 [PULL 0/5] Miscellaneous patches for 2021-05-12 Markus Armbruster
2021-05-12 16:24 ` [PULL 1/5] monitor/qmp: fix race on CHR_EVENT_CLOSED without OOB Markus Armbruster
2021-05-12 16:24 ` [PULL 2/5] Remove the deprecated moxie target Markus Armbruster
2021-05-12 16:37 ` Philippe Mathieu-Daudé [this message]
2021-05-12 17:07 ` Thomas Huth
2021-05-12 20:04 ` Philippe Mathieu-Daudé
2021-05-12 16:24 ` [PULL 3/5] block: Drop the sheepdog block driver Markus Armbruster
2021-05-12 16:24 ` [PULL 4/5] Drop the deprecated lm32 target Markus Armbruster
2021-05-12 16:24 ` [PULL 5/5] Drop the deprecated unicore32 target Markus Armbruster
2021-05-12 16:33 ` [PULL 0/5] Miscellaneous patches for 2021-05-12 Peter Maydell
2021-05-13 11:53 ` Thomas Huth
2021-05-12 16:42 ` no-reply
2021-05-14 9:04 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8c579c8-e361-e3ef-0f4d-d902e12c7525@amsat.org \
--to=f4bug@amsat.org \
--cc=armbru@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.