From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alex G. Date: Mon, 6 Feb 2017 12:30:32 -0800 Subject: [U-Boot] [PATCH 4/5] configs: am335x: Enable PHY_VITESSE In-Reply-To: References: <20170203234220.28589-1-alex.g@adaptrum.com> <20170203234220.28589-5-alex.g@adaptrum.com> <1f06f9d1-ebf4-ce75-f10e-08f1b88806d5@ti.com> <1d257db6-6f5a-2078-2ca6-e2afe8917d0b@adaptrum.com> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 02/06/2017 11:47 AM, Andrew F. Davis wrote: > On 02/06/2017 01:02 PM, Alex G. wrote: >> On 02/06/2017 07:56 AM, Andrew F. Davis wrote: >>> On 02/03/2017 05:42 PM, Alexandru Gagniuc wrote: >>>> The Adaptrum ACRS2 mainboard uses a Vitesse VSC8601 PHY. >>>> >>>> Signed-off-by: Alexandru Gagniuc >>>> --- >>>> include/configs/am335x_evm.h | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/include/configs/am335x_evm.h b/include/configs/am335x_evm.h >>>> index cd42601..b0014cf 100644 >>>> --- a/include/configs/am335x_evm.h >>>> +++ b/include/configs/am335x_evm.h >>>> @@ -366,6 +366,7 @@ >>>> #define CONFIG_PHY_SMSC >>>> /* Enable Atheros phy driver */ >>>> #define CONFIG_PHY_ATHEROS >>>> +#define CONFIG_PHY_VITESSE >>>> >>> >>> These PHY symbols should instead be moved to Kconfig, lets try not to >>> add anything new to the config headers :) >> >> The whole PHY_ seclection does seem like it could use a major rework. I >> was hoping to not have to touch Kconfig in this series, but if that is >> the will, I shall yield. >> > > It's really not so bad, have you ever used tools/moveconfig.py? Just > define the symbol in kconfig and it will do all the work for you. The > more people forced to at least try it out the quicker we can finish with > this the conversion. I did try this for PHYLIB, and got a bunch of Compiler is missing. Do nothing. I got that for every single defconfig, so I gave up on it. Alex > Andrew > >> Alex >> >>> >>> Andrew >>> >>>> /* >>>> * NOR Size = 16 MiB >>>>