From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f68.google.com ([74.125.83.68]:39662 "EHLO mail-pg0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751611AbeBZQIf (ORCPT ); Mon, 26 Feb 2018 11:08:35 -0500 Received: by mail-pg0-f68.google.com with SMTP id w17so6338212pgv.6 for ; Mon, 26 Feb 2018 08:08:35 -0800 (PST) Subject: Re: [patch net-next] mlxsw: spectrum_switchdev: Allow port enslavement to a VLAN-unaware bridge To: Jiri Pirko , netdev@vger.kernel.org Cc: davem@davemloft.net, idosch@mellanox.com, mlxsw@mellanox.com References: <20180220074512.4307-1-jiri@resnulli.us> From: David Ahern Message-ID: Date: Mon, 26 Feb 2018 09:08:33 -0700 MIME-Version: 1.0 In-Reply-To: <20180220074512.4307-1-jiri@resnulli.us> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 2/20/18 12:45 AM, Jiri Pirko wrote: > From: Ido Schimmel > > Up until now we only allowed VLAN devices to be put in a VLAN-unaware > bridge, but some users need the ability to enslave physical ports as > well. > > This is achieved by mapping the port and VID 1 to the bridge's vFID, > instead of the port and the VID used by the VLAN device. > > The above is valid because as long as the port is not enslaved to a > bridge, VID 1 is guaranteed to be configured as PVID and egress > untagged. > > Signed-off-by: Ido Schimmel > Signed-off-by: Jiri Pirko > --- > drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) > Tested-by: David Ahern