From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4395C04FF3 for ; Mon, 24 May 2021 07:53:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D0635610CB for ; Mon, 24 May 2021 07:53:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0635610CB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C7C346E14C; Mon, 24 May 2021 07:53:41 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 580766E111 for ; Mon, 24 May 2021 07:53:38 +0000 (UTC) Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B2C11140C; Mon, 24 May 2021 09:53:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621842816; bh=AtMQHVfiglCLqM5L+PcEfbs4AxmjJUM2/Lhq8HbfTro=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=c0vD9mtcBVVe2a5PSs0i772SG6U0v3BH7A/ZZZrYYCOfUrJdg3YFnlWzX2/skSyIj pXRgxXA7XQJRB4Tu2mht9puPm28B1XYvrE+asnJaBp95w8enIMeiXqhTbJzW2iw4Y7 Y75yW5/65EMShJxrLVE5SAZAEsv6Wxcoex726Vdw= Subject: Re: [PATCH 09/11] drm/omap: Follow implicit fencing in prepare_fb To: Daniel Vetter , DRI Development References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-9-daniel.vetter@ffwll.ch> From: Tomi Valkeinen Message-ID: Date: Mon, 24 May 2021 10:53:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210521090959.1663703-9-daniel.vetter@ffwll.ch> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 21/05/2021 12:09, Daniel Vetter wrote: > I guess no one ever tried running omap together with lima or panfrost, > not even sure that's possible. Anyway for consistency, fix this. > > Signed-off-by: Daniel Vetter > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/omap_plane.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c > index 801da917507d..512af976b7e9 100644 > --- a/drivers/gpu/drm/omapdrm/omap_plane.c > +++ b/drivers/gpu/drm/omapdrm/omap_plane.c > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > > #include "omap_dmm_tiler.h" > @@ -29,6 +30,8 @@ static int omap_plane_prepare_fb(struct drm_plane *plane, > if (!new_state->fb) > return 0; > > + drm_gem_plane_helper_prepare_fb(plane, new_state); > + > return omap_framebuffer_pin(new_state->fb); > } > > Reviewed-by: Tomi Valkeinen Tomi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 186E8C04FF3 for ; Mon, 24 May 2021 07:53:46 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C512C610C7 for ; Mon, 24 May 2021 07:53:45 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C512C610C7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7667F6E123; Mon, 24 May 2021 07:53:43 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2571D6E134 for ; Mon, 24 May 2021 07:53:42 +0000 (UTC) Received: from [192.168.1.111] (91-157-208-71.elisa-laajakaista.fi [91.157.208.71]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id B2C11140C; Mon, 24 May 2021 09:53:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1621842816; bh=AtMQHVfiglCLqM5L+PcEfbs4AxmjJUM2/Lhq8HbfTro=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=c0vD9mtcBVVe2a5PSs0i772SG6U0v3BH7A/ZZZrYYCOfUrJdg3YFnlWzX2/skSyIj pXRgxXA7XQJRB4Tu2mht9puPm28B1XYvrE+asnJaBp95w8enIMeiXqhTbJzW2iw4Y7 Y75yW5/65EMShJxrLVE5SAZAEsv6Wxcoex726Vdw= To: Daniel Vetter , DRI Development References: <20210521090959.1663703-1-daniel.vetter@ffwll.ch> <20210521090959.1663703-9-daniel.vetter@ffwll.ch> From: Tomi Valkeinen Message-ID: Date: Mon, 24 May 2021 10:53:34 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210521090959.1663703-9-daniel.vetter@ffwll.ch> Content-Language: en-US Subject: Re: [Intel-gfx] [PATCH 09/11] drm/omap: Follow implicit fencing in prepare_fb X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Vetter , Intel Graphics Development Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On 21/05/2021 12:09, Daniel Vetter wrote: > I guess no one ever tried running omap together with lima or panfrost, > not even sure that's possible. Anyway for consistency, fix this. > > Signed-off-by: Daniel Vetter > Cc: Tomi Valkeinen > --- > drivers/gpu/drm/omapdrm/omap_plane.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c b/drivers/gpu/drm/omapdrm/omap_plane.c > index 801da917507d..512af976b7e9 100644 > --- a/drivers/gpu/drm/omapdrm/omap_plane.c > +++ b/drivers/gpu/drm/omapdrm/omap_plane.c > @@ -6,6 +6,7 @@ > > #include > #include > +#include > #include > > #include "omap_dmm_tiler.h" > @@ -29,6 +30,8 @@ static int omap_plane_prepare_fb(struct drm_plane *plane, > if (!new_state->fb) > return 0; > > + drm_gem_plane_helper_prepare_fb(plane, new_state); > + > return omap_framebuffer_pin(new_state->fb); > } > > Reviewed-by: Tomi Valkeinen Tomi _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx