From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 298B9C4332F for ; Fri, 9 Dec 2022 14:13:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xFVljPaJHhhNwXHnsDwMF28BPe4C026kVaxdZ7Yebg0=; b=NXMKUOJr6897aw PJ1+L+hSrWH9BDXYshDjEUR4fll2xYxFHTTaAqAWEGnXwqrW1V0VhqMqhBtAIDx9jgTECiiRKNaB5 +YIUukPlHJdQSNCouJdNr3PRA+twADDiYFx3u1OH3qCcNE1i6SDWMpJrpr+vMuW8TRpjb2Q+fZ7rH IT4mgY3Y8cyWYMCez9eq5TlzJPkW1UCLyWihAM3mvrrL99K/LptnAGbAigLmn3tJ1gGRoPNNwLb8m OtGUWASHIFGUcm4QIH++VoTOPPYT7yE7sGLMFZypGkA2Ijktgrhkx5AElxNdOjCnMXVp4znh4mR6U fqW6C3VoU0oTEtvBc9rQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3e6P-008Ibx-95; Fri, 09 Dec 2022 14:11:51 +0000 Received: from sender4-of-o53.zoho.com ([136.143.188.53]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p3e48-008Gnq-BZ for linux-arm-kernel@lists.infradead.org; Fri, 09 Dec 2022 14:09:30 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1670594954; cv=none; d=zohomail.com; s=zohoarc; b=jnOvki9TrmI+eMrjm3T54AOYQZSvXWLx8TKjJX5NAWxw1O2HszUbhyYjt24sWVGIdzjQo4eV7oec56D+sqGIHPkMAppGCurOY6nLrVwnrwIvP/WJcnkVnQap/MuPfad/odc7gcrxNRjn+bwcc1q3llJAJgBk72LYH9I/3cH9Ym4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670594954; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=F8+cB/N0zNmn7olZOIHjU0tWqdllh9rXI88S3aPtc0Q=; b=SrWP2kGygYy6q/JWdyTkQIhe7Tf8BzNpi99RAQ3EiNHOOV8+w/VPQ9p9+qGzauGUQ6YR7PvflFbpSMfg01yZu28rHhjfm+1+NFJTZwMTLAk2I7Fp3k9XujXJ1HyLN2hhBd6AkDf15O9d4AILkvR0Ezanap7HcTNGp9f2bITGwws= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=machnikowski.net; spf=pass smtp.mailfrom=maciek@machnikowski.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1670594954; s=zoho; d=machnikowski.net; i=maciek@machnikowski.net; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=F8+cB/N0zNmn7olZOIHjU0tWqdllh9rXI88S3aPtc0Q=; b=Vyfudvow/JM85NCk++q6naXT3D4OCTRIX/7C8nw6W50nXbMS2okQeS0yx+F1hk82 dQRxLIdNOQj2WujEoxSq90ZXhubuKR54/YW/kufAYnBPO2rfzRQBWJAK+/bxca+cnv3 PDpwACTTWPc6EQfz/4YVtHcEkKprM7ns98jdw/Pk4fat/qafq50eKANCvliMCakHQ67 kp2hhu9WizdlSQy3LEBM7fGe9iJ/Mg/xHTrz6t/XYMYnZlueVzrjJpyArYYYkNulNV4 xcMWmM6QNzIjn75NWeqC+To4xuNQ9sShtBB2PVurWb2pK1up8lAOyXGnIvTcCeVgP02 uY6xZIPdWA== Received: from [192.168.1.227] (83.8.188.9.ipv4.supernova.orange.pl [83.8.188.9]) by mx.zohomail.com with SMTPS id 1670594952370207.56053616816519; Fri, 9 Dec 2022 06:09:12 -0800 (PST) Message-ID: Date: Fri, 9 Dec 2022 15:09:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH v4 0/4] Create common DPLL/clock configuration API Content-Language: en-US To: Jiri Pirko Cc: Jakub Kicinski , "'Kubalewski, Arkadiusz'" , 'Vadim Fedorenko' , 'Jonathan Lemon' , 'Paolo Abeni' , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221206184740.28cb7627@kernel.org> <10bb01d90a45$77189060$6549b120$@gmail.com> <20221207152157.6185b52b@kernel.org> <6e252f6d-283e-7138-164f-092709bc1292@machnikowski.net> From: Maciek Machnikowski In-Reply-To: X-ZohoMailClient: External X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221209_060928_499239_30D9BC64 X-CRM114-Status: GOOD ( 26.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxMi85LzIwMjIgMTI6MDcgUE0sIEppcmkgUGlya28gd3JvdGU6Cj4gVGh1LCBEZWMgMDgs IDIwMjIgYXQgMDc6MDg6MDRQTSBDRVQsIG1hY2lla0BtYWNobmlrb3dza2kubmV0IHdyb3RlOgo+ PiBPbiAxMi84LzIwMjIgMTI6MjEgQU0sIEpha3ViIEtpY2luc2tpIHdyb3RlOgo+PiBNeSBtYWlu IGNvbXBsYWludCBhYm91dCB0aGUgY3VycmVudCBwaW5zIGltcGxlbWVudGF0aW9uIGlzIHRoYXQg dGhleSBwdXQKPj4gZXZlcnl0aGluZyBpbiBhIHNpbmdsZSBiYWcuIEluIGEgbmV0ZGV2IHdvcmxk IC0gaXQgd291bGQgYmUgbGlrZSB3ZSBwdXQKPj4gVFggcXVldWVzIGFuZCBSWCBxdWV1ZXMgdG9n ZXRoZXIsIG5hbWVkIHRoZW0gIlF1ZXVlcyIsIGV4cG9zZSBhIGxpc3QgdG8KPj4gdGhlIHVzZXJz cGFjZSBhbmQgbGV0IHRoZSB1c2VyIGZpZ3VyZSBvdXQgd2hpY2ggb25lcyB3aGljaCBieSByZWFk aW5nIGEKPj4gIlRYIiBmbGFnLgo+Pgo+PiBBbGwgRFBMTHMgSSBrbm93IGhhdmUgYSBTb3VyY2Vz IGJsb2NrLCBEUExMcyBhbmQgT3V0cHV0IGJsb2Nrcy4gU2VlOgo+Pgo+PiBodHRwczovL3d3dy5y ZW5lc2FzLmNvbS91cy9lbi9wcm9kdWN0cy9jbG9ja3MtdGltaW5nL2ppdHRlci1hdHRlbnVhdG9y cy1mcmVxdWVuY3ktdHJhbnNsYXRpb24vOGEzNDA0NC1tdWx0aWNoYW5uZWwtZHBsbC1kY28tZm91 ci1laWdodC1jaGFubmVscyNvdmVydmlldwo+Pgo+PiBodHRwczovL3d3MS5taWNyb2NoaXAuY29t L2Rvd25sb2Fkcy9hZW1Eb2N1bWVudHMvZG9jdW1lbnRzL1RJTS9Qcm9kdWN0RG9jdW1lbnRzL1By b2R1Y3RCcmllZi9aTDMwNjN4LVN5c3RlbS1TeW5jaHJvbml6ZXJzLXdpdGgtdXAtdG8tNS1DaGFu bmVscy0xMC1JbnB1dHMtMjAtT3V0cHV0cy1Qcm9kdWN0LUJyaWVmLURTMjAwMDY2MzQucGRmCj4+ Cj4+IGh0dHBzOi8vd3d3LnNpdGltZS5jb20vc3VwcG9ydC9yZXNvdXJjZS1saWJyYXJ5L3Byb2R1 Y3QtYnJpZWZzL2Nhc2NhZGUtc2l0OTUxNHgtY2xvY2stc3lzdGVtLWNoaXAtZmFtaWx5Cj4+Cj4+ IGh0dHBzOi8vd3d3LnRpLmNvbS9saXQvZHMvc3ltbGluay9sbWs1YjMzNDE0LnBkZj90cz0xNjcw NTE2MTMyNjQ3JnJlZl91cmw9aHR0cHMlMjUzQSUyNTJGJTI1MkZ3d3cudGkuY29tJTI1MkZjbG9j a3MtdGltaW5nJTI1MkZqaXR0ZXItY2xlYW5lcnMtc3luY2hyb25pemVycyUyNTJGcHJvZHVjdHMu aHRtbAo+Pgo+PiBJZiB3ZSBtb2RlbCBldmVyeXRoaW5nIGFzICJwaW5zIiB3ZSB3b24ndCBiZSBh YmxlIHRvIGNvcnJlY3RseSBleHRlbmQKPj4gdGhlIEFQSSB0byBhZGQgbmV3IGZlYXR1cmVzLgo+ Pgo+PiBTb3VyY2VzIGNhbiBjb25maWd1cmUgdGhlIGV4cGVjdGVkIGZyZXF1ZW5jeSwgaW5wdXQg c2lnbmFsIG1vbml0b3JpbmcKPj4gKG9uIG11bHRpcGxlIGxheWVycyksIGV4cGVjdGVkIHNpZ25h bCBsZXZlbHMsIGlucHV0IHRlcm1pbmF0aW9uIGFuZCBzbwo+PiBvbi4gT3V0cHV0cyB3aWxsIG5l ZWQgdGhlIGVuYWJsZSBmbGFnLCBzaWduYWwgZm9ybWF0LCBmcmVxdWVuY3ksIHBoYXNlCj4+IG9m ZnNldCBldGMuIE11bHRpcGxlIERQTExzIGNhbiByZXVzZSBhIHNpbmdsZSBzb3VyY2UgaW5zaWRl IHRoZSBzYW1lCj4+IHBhY2thZ2Ugc2ltdWx0YW5lb3VzbHkuCj4gCj4gCj4gTG9va2luZyBhdCB0 aGUgZG9jdW1lbnRhdGlvbiBvZiB0aGUgY2hpcHMsIHRoZXkgYWxsIGhhdmUgbXVwbHRpcGxlIERQ TExzCj4gb24gYSBkaWUuIEFya2FkaXVzeiwgaW4geW91ciBwcm9wb3NlZCBpbXBsZW1lbnRhdGlv biwgZG8geW91IG1vZGVsIGVhY2gKPiBEUExMIHNlcGFyYXRlbGx5PyBJZiB5ZXMsIHRoZW4gSSB1 bmRlcnN0YW5kIHRoZSB1cmdlbmN5IG9mIG5lZWQgb2YgYQo+IHNoYXJlZCBwaW4uIFNvIGFsbCBE UExMcyBzaGFyaW5nIHRoZSBwaW4gYXJlIHBhcnQgb2YgdGhlIHNhbWUgY2hpcD8KPiAKPiBRdWVz dGlvbjogY2FuIHdlIGhhdmUgYW4gZW50aXR5LCB0aGF0IHdvdWxkIGJlIDE6MSBtYXBwZWQgdG8g dGhlIGFjdHVhbAo+IGRldmljZS9jaGlwIGhlcmU/IExldCdzIGNhbGwgaXMgImEgc3luY2hyb25p emVyIi4gSXQgd291bGQgY29udGFpbgo+IG11bHRpcGxlIERQTExzLCB1c2VyLWZhY2luZy1zb3Vy Y2VzKGlucHV0X2Nvbm5lY3RvciksCj4gdXNlci1mYWNpbmctb3V0cHV0cyhvdXRwdXRfY29ubmVj dG9yKSwgaS9vIHBpbnMuCj4gCj4gQW4gZXhhbXBsZToKPiAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgU1lOQ0hST05JWkVSCj4gCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg 4pSM4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSQCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCCj4gICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCCj4gICBT eW5jRSBpbiBjb25uZWN0b3IgICAgICAgICAg4pSCICAgICAgICAgICAgICDilIzilIDilIDilIDi lIDilIDilIDilIDilIDilIDilJAgICAgICAgICAgICAgIOKUgiAgICAgU3luY0Ugb3V0IGNvbm5l Y3Rvcgo+ICAgICAgICAgICAgICAgICDilIzilIDilIDilIDilJAgICAgICAgICDilIJpbiBwaW4g MSAgICAgIOKUgkRQTExfMSAgIOKUgiAgICAgb3V0IHBpbiAx4pSCICAgIOKUjOKUgOKUgOKUgOKU kAo+ICAgICAgICAgICAgICAgICDilIIgICDilJzilIDilIDilIDilIDilIDilIDilIDilIDilIDi lLzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilKQgICAgICAgICDi lJzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilLzilIDilIDilIDi lIDilKQgICDilIIKPiAgICAgICAgICAgICAgICAg4pSCICAg4pSCICAgICAgICAg4pSCICAgICAg ICAgICAgICDilIIgICAgICAgICDilIIgICAgICAgICAgICAgIOKUgiAgICDilIIgICDilIIKPiAg ICAgICAgICAgICAgICAg4pSU4pSA4pSA4pSA4pSYICAgICAgICAg4pSCICAgICAgICAgICAgICDi lIIgICAgICAgICDilIIgICAgICAgICAgICAgIOKUgiAgICDilJTilIDilIDilIDilJgKPiAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICDilIIgICAgICAgICAgICAgIOKUgiAgICAgICAgIOKU giAgICAgICAgICAgICAg4pSCCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCICAg ICAgICAgICDilIzilIDilIDilKQgICAgICAgICDilIIgICAgICAgICAgICAgIOKUggo+ICAgIEdO U1MgaW4gY29ubmVjdG9yICAgICAgICAgIOKUgiAgICAgICAgICAg4pSCICDilJTilIDilIDilIDi lIDilIDilIDilIDilIDilIDilJggICAgICAgICAgICAgIOKUggo+ICAgICAgICAgICAgICAgICDi lIzilIDilIDilIDilJAgICAgICAgICDilIJpbiBwaW4gMiAgIOKUgiAgICAgICAgICAgICAgICAg IG91dCBwaW4gMuKUgiAgICAgRVhUIFNNQSBjb25uZWN0b3IKPiAgICAgICAgICAgICAgICAg4pSC ICAg4pSc4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pS84pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSYICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCICAgIOKUjOKUgOKU gOKUgOKUkAo+ICAgICAgICAgICAgICAgICDilIIgICDilIIgICAgICAgICDilIIgICAgICAgICAg ICAgICAgICAgICAgICAgICDilIzilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilIDilLzi lIDilIDilIDilIDilKQgICDilIIKPiAgICAgICAgICAgICAgICAg4pSU4pSA4pSA4pSA4pSYICAg ICAgICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCICAgICAgICAgICDilIIgICAg 4pSCICAg4pSCCj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCICAgICAgICAgICAg ICAgICAgICAgICAgICAg4pSCICAgICAgICAgICDilIIgICAg4pSU4pSA4pSA4pSA4pSYCj4gICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAg 4pSCICAgICAgICAgICDilIIKPiAgICBFWFQgU01BIGNvbm5lY3RvciAgICAgICAgICDilIIgICAg ICAgICAgICAgICAgICAgICAgICAgICDilIIgICAgICAgICAgIOKUggo+ICAgICAgICAgICAgICAg ICDilIzilIDilIDilIDilJAgICBtdXggICDilIJpbiBwaW4gMyAgICAgIOKUjOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUkCAg4pSCICAgICAgICAgICDilIIKPiAgICAgICAgICAgICAgICAg 4pSCICAg4pSc4pSA4pSA4pSA4pSA4pSs4pSA4pSA4pSA4pSA4pS84pSA4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSQICDilIIgICAgICAgICDilIIgIOKUgiAgICAgICAgICAg4pSCCj4g ICAgICAgICAgICAgICAgIOKUgiAgIOKUgiAgICDilIIgICAg4pSCICAgICAgICAgICDilIIgIOKU gkRQTExfMiAgIOKUgiAg4pSCICAgICAgICAgICDilIIKPiAgICAgICAgICAgICAgICAg4pSU4pSA 4pSA4pSA4pSYICAgIOKUgiAgICDilIIgICAgICAgICAgIOKUgiAg4pSCICAgICAgICAg4pSCICDi lIIgICAgICAgICAgIOKUggo+ICAgICAgICAgICAgICAgICAgICAgICAgICDilIIgICAg4pSCICAg ICAgICAgICDilJTilIDilIDilKQgICAgICAgICDilJzilIDilIDilJggICAgICAgICAgIOKUggo+ ICAgICAgICAgICAgICAgICAgICAgICAgICDilIIgICAg4pSCICAgICAgICAgICAgICDilIIgICAg ICAgICDilIIgICAgICAgICAgICAgIOKUggo+ICAgIEVYVCBTTUEgY29ubmVjdG9yICAgICDilIIg ICAg4pSCICAgICAgICAgICAgICDilIIgICAgICAgICDilIIgICAgICAgICAgICAgIOKUggo+ICAg ICAgICAgICAgICAgICDilIzilIDilIDilIDilJAgICAg4pSCICAgIOKUgiAgICAgICAgICAgICAg 4pSCICAgICAgICAg4pSCICAgICAgICAgICAgICDilIIKPiAgICAgICAgICAgICAgICAg4pSCICAg 4pSc4pSA4pSA4pSA4pSA4pSYICAgIOKUgiAgICAgICAgICAgICAg4pSU4pSA4pSA4pSA4pSA4pSA 4pSA4pSA4pSA4pSA4pSYICAgICAgICAgICAgICDilIIKPiAgICAgICAgICAgICAgICAg4pSCICAg 4pSCICAgICAgICAg4pSCICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg4pSC Cj4gICAgICAgICAgICAgICAgIOKUlOKUgOKUgOKUgOKUmCAgICAgICAgIOKUlOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUmAo+IAo+ IERvIEkgZ2V0IHRoYXQgcmVtb3RlbGx5IGNvcnJlY3Q/CgpJdCBsb29rcyBnb290LCBoZW5jZSB0 d28gY29ycmVjdGlvbnMgYXJlIG5lZWRlZDoKLSBhbGwgaW5wdXRzIGNhbiBnbyB0byBhbGwgRFBM THMsIGFuZCBhIHNpbmdsZSBzb3VyY2UgY2FuIGRyaXZlIG1vcmUKICB0aGFuIG9uZSBEUExMCi0g VGhlIGV4dGVybmFsIG11eCBmb3IgU01BIGNvbm5lY3RvciBzaG91bGQgbm90IGJlIGEgcGFydCBv ZiB0aGUKICBTeW5jaHJvbml6ZXIgc3Vic3lzdGVtIC0gSSBiZWxpZXZlIHRoZXJlJ3MgYWxyZWFk eSBhIHNlcGFyYXRlIE1VWAogIHN1YnN5c3RlbSBpbiB0aGUga2VybmVsIGFuZCBhbGwgZXh0ZXJu YWwgY29ubmVjdGlvbnMgc2hvdWxkIGJlIGhhbmRsZWQKICBieSBhIGRldnRyZWUgb3IgYSBzaW1p bGFyIGNvbmNlcHQuCgpUaGUgb25seSAibXV4aW5nIiB0aGluZyB0aGF0IGNvdWxkIHBvdGVudGlh bGx5IGJlIG1vZGVsZWQgaXMgYQpzeW5jaHJvbml6ZXIgb3V0cHV0IHRvIHN5bmNocm9uaXplciBp bnB1dCByZWxhdGlvbi4gU29tZSBzeW5jaHJvbml6ZXJzCmRvZXMgdGhhdCBpbnRlcm5hbGx5IGFu ZCBjYW4gdXNlIHRoZSBvdXRwdXQgb2Ygb25lIERQTEwgYXMgYSBzb3VyY2UgZm9yCmFub3RoZXIu CgpBbHNvLCBpbiB0aGVvcnksIHRoZSBEUExMLT5vdXRwdXQgcmVsYXRpb24gbWF5IGNoYW5nZSwg aG93ZXZlciBJIGFzc3VtZQp3ZSBjYW4gc2tpcCBzdXBwb3J0IGZvciB0aGF0IGF0IHRoZSBiZWdp bm5pbmcuCgpTbyBzb21ldGhpbmcgbGlrZSB0aGlzIHdvdWxkIGJlIHJvdWdobHkgY29ycmVjdDoK ICAgICAgIOKUjOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUkAogICAgICAg4pSCICAgICAgICAg ICAgICAgICAgICAgICAgICAg4pSCCuKUjOKUgOKUgOKUkCAgIOKUgiBzcmMwICAg4pSM4pSA4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSQICAgb3V0MCDilIIgICAg4pSM4pSA4pSA4pSQCuKUgiAg 4pSc4pSA4pSA4pSA4pS84pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSkIERQTEwxICAg4pSc4pSA 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pS84pSA4pSA4pSA4pSA4pSkICDilIIK4pSU4pSA4pSA4pSY ICAg4pSCICAgICAgICDilIIgICAgICAgICDilIIgICAgICAgIOKUgiAgICDilJTilIDilIDilJgK ICAgICAgIOKUgiAgICAgICAg4pSCICAgICAgICAg4pSCICAgICAgICDilIIKICAgICAgIOKUgiAg ICAgICAg4pSCICAgICAgICAg4pSCICAgb3V0MSDilIIgICAg4pSM4pSA4pSA4pSQCuKUjOKUgOKU gOKUkCAgIOKUgiBzcmMxICAg4pSCICAgICAgICAg4pSc4pSA4pSA4pSA4pSs4pSA4pSA4pSA4pSA 4pS84pSA4pSA4pSA4pSA4pSkICDilIIK4pSCICDilJzilIDilIDilIDilLzilIDilIDilKzilIDi lIDilIDilIDilIDilKQgICAgICAgICDilIIgICDilIIgICAg4pSCICAgIOKUlOKUgOKUgOKUmAri lJTilIDilIDilJggICDilIIgIOKUgiAgICAg4pSU4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pSYICAg4pSCICAgIOKUggogICAgICAg4pSCICDilIIgICDilIzilIDilIDilIDilIDilIDilIDi lIDilIDilIDilIDilIDilIDilIDilIDilIDilJggICAg4pSCCiAgICAgICDilIIgIOKUgiAgIOKU giAgIHNyY19kcGxsMSAgICAgICAg4pSCCiAgICAgICDilIIgIOKUgiAgIOKUgiDilIzilIDilIDi lIDilIDilIDilIDilIDilIDilIDilJAgICBvdXQyIOKUgiAgICDilIzilIDilIDilJAKICAgICAg IOKUgiAg4pSCICAg4pSU4pSA4pSkIERQTEwyICAg4pSc4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA 4pS84pSA4pSA4pSA4pSA4pSkICDilIIKICAgICAgIOKUgiAg4pSCICAgICDilIIgICAgICAgICDi lIIgICAgICAgIOKUgiAgICDilJTilIDilIDilJgKICAgICAgIOKUgiAg4pSU4pSA4pSA4pSA4pSA 4pSA4pSkICAgICAgICAg4pSCICAgICAgICDilIIK4pSM4pSA4pSA4pSQICAg4pSCIHNyYzIgICDi lIIgICAgICAgICDilIIgICAgICAgIOKUggrilIIgIOKUnOKUgOKUgOKUgOKUvOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUpCAgICAgICAgIOKUgiAgICAgICAg4pSCCuKUlOKUgOKUgOKUmCAgIOKU giAgICAgICAg4pSCICAgICAgICAg4pSCICAgICAgICDilIIKICAgICAgIOKUgiAgICAgICAg4pSU 4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSA4pSYICAgICAgICDilIIKICAgICAgIOKUgiAgICAg ICAgICAgICAgICAgICAgICAgICAgIOKUggogICAgICAg4pSCICAgICAgICAgICAgICAgICAgICAg ICAgICAg4pSCCiAgICAgICDilIIgICAgICAgICAgICAgICAgICAgICAgICAgICDilIIKICAgICAg IOKUlOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKU gOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUgOKUmAoKPiBzeW5jaAo+IHN5bmNocm9uaXplcl9y ZWdpc3RlcihzeW5jaCkKPiAgICBkcGxsXzEKPiAgICBzeW5jaHJvbml6ZXJfZHBsbF9yZWdpc3Rl cihzeW5jaCwgZHBsbF8xKQo+ICAgIGRwbGxfMgo+ICAgIHN5bmNocm9uaXplcl9kcGxsX3JlZ2lz dGVyKHN5bmNoLCBkcGxsXzIpCj4gICAgc291cmNlX3Bpbl8xCj4gICAgc3luY2hyb25pemVyX3Bp bl9yZWdpc3RlcihzeW5jaCwgc291cmNlX3Bpbl8xKQo+ICAgIG91dHB1dF9waW5fMQo+ICAgIHN5 bmNocm9uaXplcl9waW5fcmVnaXN0ZXIoc3luY2gsIG91dHB1dF9waW5fMSkKPiAgICBvdXRwdXRf cGluXzIKPiAgICBzeW5jaHJvbml6ZXJfcGluX3JlZ2lzdGVyKHN5bmNoLCBvdXRwdXRfcGluXzIp Cj4gCj4gc3luY2hfYm9hcmQKPiAgICBzeW5jaHJvbml6ZXJfYm9hcmRfcmVnaXN0ZXIoc3luY2hf Ym9hcmQpCj4gICAgc3luY2gKPiAgICBzeW5jaHJvbml6ZXJfYm9hcmRfc3luY19yZWdpc3Rlcihz eW5jaF9ib2FyZCwgc3luY2gpCj4gICAgc291cmNlX2Nvbm5lY3Rvcl8xCj4gICAgc3luY2hyb25p emVyX2JvYXJkX2Nvbm5lY3Rvcl9yZWdpc3RlcihzeW5jaF9ib2FyZCwgc291cmNlX2Nvbm5lY3Rv cl8xLCBzb3VyY2VfcGluXzEpCj4gICAgb3V0cHV0X2Nvbm5lY3Rvcl8xCj4gICAgc3luY2hyb25p emVyX2JvYXJkX2Nvbm5lY3Rvcl9yZWdpc3RlcihzeW5jaF9ib2FyZCwgb3V0cHV0X2Nvbm5lY3Rv cl8xLCBvdXRwdXRfcGluXzEpCj4gICAgb3V0cHV0X2Nvbm5lY3Rvcl8yCj4gICAgc3luY2hyb25p emVyX2JvYXJkX2Nvbm5lY3Rvcl9yZWdpc3RlcihzeW5jaF9ib2FyZCwgb3V0cHV0X2Nvbm5lY3Rv cl8yLCBvdXRwdXRfcGluXzIpCgpJJ2QgcmF0aGVyIG5vdCB1c2UgcGlucyBhdCBhbGwgLSBqdXN0 IHN0aWNrIHRvIHNvdXJjZXMgYW5kIG91dHB1dHMuIEJvdGgKY2FuIHVzZSBzb21lIGxhYmVscyB0 byBiZSBpZGVudGlmaWFibGUuCgoKPiBUaGlua2luZyBhYm91dCBpdCBhIGJpdCBtb3JlLCB0aGlz IHNob3VsZCBiZSBwcm9iYWJseSBnb29kIHRvIGRlc2NyaWJlCj4gYnkgZGV2aWNlIHRyZWUuIFRo ZSBzeW5jaHJvbml6ZXIgaXRzZWxmIGRwbGxzIGFuZCBwaW5zIGl0IGNvbnRhaW5zCj4gaGF2ZSBj b25zdGFuYyBnZW9tZXRyeSwgYWNjb3JkaW5nIHRvIHRoZSBzeW5jaHJvbml6ZXIgZGV2aWNlIHR5 cGUuCj4gCj4gVGhlIENvbm5lY3Rvci1waW4gbGlua2FnZXMgbWF5IHZhcnkgYWNjb3JkaW5nIHRv IHRoZSBib2FyZC4KPiAKPiBTbyB0byBkaXZpZGUgaXQsIHRoZXJlIHNob3VsZCBiZSBvbmUgc3lu Y2hyb25pemVyIGRyaXZlci4gVGhlbiBwcm9iYWJseQo+IHNvbWUgb3RoZXIgb25lIHRvIGNvbm5l Y3Qvc2VsZWN0L211eCB0aGUgY29ubmVjdG9ycyB0byB0aGUgc3luY2hyb25pemVyLgoKQWdyZWVk IC0gd2Ugc2hvdWxkIG5vdCBtb2RlbCBleHRlcm5hbCBib2FyZCBjb25uZWN0aW9ucyBpbnNpZGUg dGhlCnN5bmNocm9uaXplciBkcml2ZXIgc3Vic3lzdGVtLgotTWFjaWVrCgoKX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0 cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F498C04FDE for ; Fri, 9 Dec 2022 14:13:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230009AbiLIONw (ORCPT ); Fri, 9 Dec 2022 09:13:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229996AbiLION2 (ORCPT ); Fri, 9 Dec 2022 09:13:28 -0500 Received: from sender4-of-o53.zoho.com (sender4-of-o53.zoho.com [136.143.188.53]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 081BC78697; Fri, 9 Dec 2022 06:09:35 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1670594954; cv=none; d=zohomail.com; s=zohoarc; b=jnOvki9TrmI+eMrjm3T54AOYQZSvXWLx8TKjJX5NAWxw1O2HszUbhyYjt24sWVGIdzjQo4eV7oec56D+sqGIHPkMAppGCurOY6nLrVwnrwIvP/WJcnkVnQap/MuPfad/odc7gcrxNRjn+bwcc1q3llJAJgBk72LYH9I/3cH9Ym4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1670594954; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=F8+cB/N0zNmn7olZOIHjU0tWqdllh9rXI88S3aPtc0Q=; b=SrWP2kGygYy6q/JWdyTkQIhe7Tf8BzNpi99RAQ3EiNHOOV8+w/VPQ9p9+qGzauGUQ6YR7PvflFbpSMfg01yZu28rHhjfm+1+NFJTZwMTLAk2I7Fp3k9XujXJ1HyLN2hhBd6AkDf15O9d4AILkvR0Ezanap7HcTNGp9f2bITGwws= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=machnikowski.net; spf=pass smtp.mailfrom=maciek@machnikowski.net; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1670594954; s=zoho; d=machnikowski.net; i=maciek@machnikowski.net; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=F8+cB/N0zNmn7olZOIHjU0tWqdllh9rXI88S3aPtc0Q=; b=Vyfudvow/JM85NCk++q6naXT3D4OCTRIX/7C8nw6W50nXbMS2okQeS0yx+F1hk82 dQRxLIdNOQj2WujEoxSq90ZXhubuKR54/YW/kufAYnBPO2rfzRQBWJAK+/bxca+cnv3 PDpwACTTWPc6EQfz/4YVtHcEkKprM7ns98jdw/Pk4fat/qafq50eKANCvliMCakHQ67 kp2hhu9WizdlSQy3LEBM7fGe9iJ/Mg/xHTrz6t/XYMYnZlueVzrjJpyArYYYkNulNV4 xcMWmM6QNzIjn75NWeqC+To4xuNQ9sShtBB2PVurWb2pK1up8lAOyXGnIvTcCeVgP02 uY6xZIPdWA== Received: from [192.168.1.227] (83.8.188.9.ipv4.supernova.orange.pl [83.8.188.9]) by mx.zohomail.com with SMTPS id 1670594952370207.56053616816519; Fri, 9 Dec 2022 06:09:12 -0800 (PST) Message-ID: Date: Fri, 9 Dec 2022 15:09:08 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 Subject: Re: [RFC PATCH v4 0/4] Create common DPLL/clock configuration API Content-Language: en-US To: Jiri Pirko Cc: Jakub Kicinski , "'Kubalewski, Arkadiusz'" , 'Vadim Fedorenko' , 'Jonathan Lemon' , 'Paolo Abeni' , netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221206184740.28cb7627@kernel.org> <10bb01d90a45$77189060$6549b120$@gmail.com> <20221207152157.6185b52b@kernel.org> <6e252f6d-283e-7138-164f-092709bc1292@machnikowski.net> From: Maciek Machnikowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 12/9/2022 12:07 PM, Jiri Pirko wrote: > Thu, Dec 08, 2022 at 07:08:04PM CET, maciek@machnikowski.net wrote: >> On 12/8/2022 12:21 AM, Jakub Kicinski wrote: >> My main complaint about the current pins implementation is that they put >> everything in a single bag. In a netdev world - it would be like we put >> TX queues and RX queues together, named them "Queues", expose a list to >> the userspace and let the user figure out which ones which by reading a >> "TX" flag. >> >> All DPLLs I know have a Sources block, DPLLs and Output blocks. See: >> >> https://www.renesas.com/us/en/products/clocks-timing/jitter-attenuators-frequency-translation/8a34044-multichannel-dpll-dco-four-eight-channels#overview >> >> https://ww1.microchip.com/downloads/aemDocuments/documents/TIM/ProductDocuments/ProductBrief/ZL3063x-System-Synchronizers-with-up-to-5-Channels-10-Inputs-20-Outputs-Product-Brief-DS20006634.pdf >> >> https://www.sitime.com/support/resource-library/product-briefs/cascade-sit9514x-clock-system-chip-family >> >> https://www.ti.com/lit/ds/symlink/lmk5b33414.pdf?ts=1670516132647&ref_url=https%253A%252F%252Fwww.ti.com%252Fclocks-timing%252Fjitter-cleaners-synchronizers%252Fproducts.html >> >> If we model everything as "pins" we won't be able to correctly extend >> the API to add new features. >> >> Sources can configure the expected frequency, input signal monitoring >> (on multiple layers), expected signal levels, input termination and so >> on. Outputs will need the enable flag, signal format, frequency, phase >> offset etc. Multiple DPLLs can reuse a single source inside the same >> package simultaneously. > > > Looking at the documentation of the chips, they all have mupltiple DPLLs > on a die. Arkadiusz, in your proposed implementation, do you model each > DPLL separatelly? If yes, then I understand the urgency of need of a > shared pin. So all DPLLs sharing the pin are part of the same chip? > > Question: can we have an entity, that would be 1:1 mapped to the actual > device/chip here? Let's call is "a synchronizer". It would contain > multiple DPLLs, user-facing-sources(input_connector), > user-facing-outputs(output_connector), i/o pins. > > An example: > SYNCHRONIZER > > ┌───────────────────────────────────────┐ > │ │ > │ │ > SyncE in connector │ ┌─────────┐ │ SyncE out connector > ┌───┐ │in pin 1 │DPLL_1 │ out pin 1│ ┌───┐ > │ ├─────────┼──────────────┤ ├──────────────┼────┤ │ > │ │ │ │ │ │ │ │ > └───┘ │ │ │ │ └───┘ > │ │ │ │ > │ ┌──┤ │ │ > GNSS in connector │ │ └─────────┘ │ > ┌───┐ │in pin 2 │ out pin 2│ EXT SMA connector > │ ├─────────┼───────────┘ │ ┌───┐ > │ │ │ ┌───────────┼────┤ │ > └───┘ │ │ │ │ │ > │ │ │ └───┘ > │ │ │ > EXT SMA connector │ │ │ > ┌───┐ mux │in pin 3 ┌─────────┐ │ │ > │ ├────┬────┼───────────┐ │ │ │ │ > │ │ │ │ │ │DPLL_2 │ │ │ > └───┘ │ │ │ │ │ │ │ > │ │ └──┤ ├──┘ │ > │ │ │ │ │ > EXT SMA connector │ │ │ │ │ > ┌───┐ │ │ │ │ │ > │ ├────┘ │ └─────────┘ │ > │ │ │ │ > └───┘ └───────────────────────────────────────┘ > > Do I get that remotelly correct? It looks goot, hence two corrections are needed: - all inputs can go to all DPLLs, and a single source can drive more than one DPLL - The external mux for SMA connector should not be a part of the Synchronizer subsystem - I believe there's already a separate MUX subsystem in the kernel and all external connections should be handled by a devtree or a similar concept. The only "muxing" thing that could potentially be modeled is a synchronizer output to synchronizer input relation. Some synchronizers does that internally and can use the output of one DPLL as a source for another. Also, in theory, the DPLL->output relation may change, however I assume we can skip support for that at the beginning. So something like this would be roughly correct: ┌───────────────────────────┐ │ │ ┌──┐ │ src0 ┌─────────┐ out0 │ ┌──┐ │ ├───┼────────┤ DPLL1 ├────────┼────┤ │ └──┘ │ │ │ │ └──┘ │ │ │ │ │ │ │ out1 │ ┌──┐ ┌──┐ │ src1 │ ├───┬────┼────┤ │ │ ├───┼──┬─────┤ │ │ │ └──┘ └──┘ │ │ └─────────┘ │ │ │ │ ┌───────────────┘ │ │ │ │ src_dpll1 │ │ │ │ ┌─────────┐ out2 │ ┌──┐ │ │ └─┤ DPLL2 ├────────┼────┤ │ │ │ │ │ │ └──┘ │ └─────┤ │ │ ┌──┐ │ src2 │ │ │ │ ├───┼────────┤ │ │ └──┘ │ │ │ │ │ └─────────┘ │ │ │ │ │ │ │ └───────────────────────────┘ > synch > synchronizer_register(synch) > dpll_1 > synchronizer_dpll_register(synch, dpll_1) > dpll_2 > synchronizer_dpll_register(synch, dpll_2) > source_pin_1 > synchronizer_pin_register(synch, source_pin_1) > output_pin_1 > synchronizer_pin_register(synch, output_pin_1) > output_pin_2 > synchronizer_pin_register(synch, output_pin_2) > > synch_board > synchronizer_board_register(synch_board) > synch > synchronizer_board_sync_register(synch_board, synch) > source_connector_1 > synchronizer_board_connector_register(synch_board, source_connector_1, source_pin_1) > output_connector_1 > synchronizer_board_connector_register(synch_board, output_connector_1, output_pin_1) > output_connector_2 > synchronizer_board_connector_register(synch_board, output_connector_2, output_pin_2) I'd rather not use pins at all - just stick to sources and outputs. Both can use some labels to be identifiable. > Thinking about it a bit more, this should be probably good to describe > by device tree. The synchronizer itself dplls and pins it contains > have constanc geometry, according to the synchronizer device type. > > The Connector-pin linkages may vary according to the board. > > So to divide it, there should be one synchronizer driver. Then probably > some other one to connect/select/mux the connectors to the synchronizer. Agreed - we should not model external board connections inside the synchronizer driver subsystem. -Maciek