From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ferruh Yigit Subject: Re: [PATCH 1/2] net/i40e: queue region set and flush Date: Wed, 6 Sep 2017 10:11:01 +0100 Message-ID: References: <20170824032602.107045-1-wei.zhao1@intel.com> <20170824032602.107045-2-wei.zhao1@intel.com> <4e3ff030-ddfe-ed0d-7668-def8f0d49f43@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit To: "Zhao1, Wei" , "dev@dpdk.org" Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id 729BDFFA for ; Wed, 6 Sep 2017 11:11:03 +0200 (CEST) In-Reply-To: Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/1/2017 3:38 AM, Zhao1, Wei wrote: > HI, Ferruh > >> -----Original Message----- >> From: Yigit, Ferruh >> Sent: Friday, September 1, 2017 12:18 AM >> To: Zhao1, Wei ; dev@dpdk.org >> Subject: Re: [dpdk-dev] [PATCH 1/2] net/i40e: queue region set and flush >> >> On 8/24/2017 4:26 AM, Wei Zhao wrote: >>> This feature enable queue regions configuration for RSS in PF/VF, so >>> that different traffic classes or different packet classification >>> types can be separated to different queues in different queue >>> regions.This patch can set queue region range, it include queue number >>> in a region and the index of first queue. >>> This patch enable mapping between different priorities (UP) and >>> different traffic classes.It also enable mapping between a region >>> index and a sepcific flowtype(PCTYPE).It also provide the solution of >>> flush all configuration about queue region the above described. >>> >>> Signed-off-by: Wei Zhao >> >> Hi Wei, >> >> I wonder if this can be implemented using rte_flow, instead of PMD specific >> API? >> >> And if not, what is missing in rte_flow for this? > > Yes, at first I have plan to use rte_flow to implement this feature. > But there are many opposition for this, for example, this feature is only support by i40e but not igb/ixgbe > From hardware capacity, not all NIC. So, private API is selected. I guess rte_flow headers needs to be updated for this support, how big that update, what is missing in rte_flow for this? Even this is only for i40e, rte_flow can be an option. I believe this increases the usability of the feature for the driver. > >> >> Thanks, >> ferruh