From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DFA1AC636CD for ; Tue, 7 Feb 2023 08:40:41 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2202A85C8F; Tue, 7 Feb 2023 09:40:39 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=canonical.com header.i=@canonical.com header.b="uqyKbV5L"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 863C985C99; Tue, 7 Feb 2023 09:40:37 +0100 (CET) Received: from smtp-relay-internal-0.canonical.com (smtp-relay-internal-0.canonical.com [185.125.188.122]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id C45B185BDD for ; Tue, 7 Feb 2023 09:40:34 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=canonical.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=heinrich.schuchardt@canonical.com Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-0.canonical.com (Postfix) with ESMTPS id 9E00C3FDAB for ; Tue, 7 Feb 2023 08:40:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1675759231; bh=/dAqLCVjXuS3Gi3mDnUz3is0uifZ9IBDMGsJwA7JFSA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=uqyKbV5L3SvJYmwQvDvBvLwq2QPBNp7/d/5n1n5g1sfE3TQlpPXKErl0EkrF4ypoY MFvYQoabbF6G7ADEh+rUYxU8utJ1nL+i9AJI9CIz5wcc50cZP0P6P4Iub1XXriOxxX n1lmp0H+AE1Ag+FFplp+faAOT1oDglAsUD1bW3glA7aKHwdBs2zLPeZHUUN6cHcRaH H2aZekVHDSTfBm87XXD8ZVm9Hvqr2cB37cAGGOSpqkLYnKGp3IRmm908bZ9ROONFQk yQPN2xKdTI5VpctHT1cBmOR77cWddOrlzllC10KyqxXUxsiHHtaHdnfkiWbLS5k5oq pt0QBglYA1Q5A== Received: by mail-wr1-f72.google.com with SMTP id ay26-20020a5d6f1a000000b002c3e94b4810so723217wrb.22 for ; Tue, 07 Feb 2023 00:40:31 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/dAqLCVjXuS3Gi3mDnUz3is0uifZ9IBDMGsJwA7JFSA=; b=XgnqPAhmKZg4EPmWgMZA5PY3X/HHFbTQuMq/M49g5B87cJRkDQTFh+RYKSt161/Lw4 4oHQDDXUGRa+cNv66YBF312PWU/hQ08fa+8+iCZK8r51DfZaiS8f12cLvwFJEmSvV1pK 9g38TnVCkcnloAyQyH5ZCgHGJGnNLeqwavwVrmhrIbYphDv7M0o5sCwc3+IEiqJk0A00 8E+J8YbNfmz3wup34gNMDtFqvxFwLjIE+FTv3BtC0UBYUghXCstxmUje6if2Xh8lU7vD jjTpf45dCbw+2yObeo00YeucZ2+GW1m/4a6nji5knOx3NMVh6ORqqsN/olxIl1jK+d7S sVGg== X-Gm-Message-State: AO0yUKVpiAJVchK2Yvw5ZkUtmBCz6MGGVZlFZ4DGkzlBHIvY0S9b20qO 2kKSH/h2jjlnQvgiM/unvTqervF0gHJq3ctOxdK5J5dlh4YlJbx69gnVj3oY/o5yQ5WlM3JDacj oh6FRaIxRe5YOBG8wpE+5QtF1f0hObeY= X-Received: by 2002:a05:600c:3b8d:b0:3df:f9e6:2c5c with SMTP id n13-20020a05600c3b8d00b003dff9e62c5cmr2242445wms.38.1675759230079; Tue, 07 Feb 2023 00:40:30 -0800 (PST) X-Google-Smtp-Source: AK7set9Tucv1QXIu+w1cWtOq8e7ppOKJT9yQTBqPGEgfeq8BsHQqu+xLmRNVwnDJxKjXchTljcT8rQ== X-Received: by 2002:a05:600c:3b8d:b0:3df:f9e6:2c5c with SMTP id n13-20020a05600c3b8d00b003dff9e62c5cmr2242430wms.38.1675759229797; Tue, 07 Feb 2023 00:40:29 -0800 (PST) Received: from [192.168.123.67] (ip-088-152-145-137.um26.pools.vodafone-ip.de. [88.152.145.137]) by smtp.gmail.com with ESMTPSA id s15-20020a05600c45cf00b003e00c453447sm2859699wmo.48.2023.02.07.00.40.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 00:40:29 -0800 (PST) Message-ID: Date: Tue, 7 Feb 2023 09:40:28 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2 077/169] Correct SPL use of EFI_TCG2_PROTOCOL Content-Language: en-US To: Simon Glass Cc: Tom Rini , U-Boot Mailing List References: <20230205224118.233425-63-sjg@chromium.org> <20230205224118.233425-78-sjg@chromium.org> <3406645c-21ee-1faa-b97e-369d83c4ef42@canonical.com> From: Heinrich Schuchardt In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean On 2/7/23 05:02, Simon Glass wrote: > Hi Heinrich, > > On Mon, 6 Feb 2023 at 16:41, Heinrich Schuchardt > wrote: >> >> >> >> On 2/5/23 23:39, Simon Glass wrote: >>> This converts 1 usage of this option to the non-SPL form, since there is >>> no SPL_EFI_TCG2_PROTOCOL defined in Kconfig >> >> Why do you touch the code? I can't see any problem being solved. > > CONFIG_IS_ENABLED() is going away, so we need to migrate things that > should not be using it. I understand that EFI is not used in SPL, so > it is also redundant. > Neither the cover letter of this series nor the commit message of this patch says that CONFIG_IS_ENABLED() is going away. Both the cover letter and the commit message of the individual patches should clearly indicate this intention. Why do you want to eliminate CONFIG_IS_ENABLED()? What is going to replace it? Best regards Heinrich