From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7861BC433E1 for ; Fri, 24 Jul 2020 21:58:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EECB2070B for ; Fri, 24 Jul 2020 21:58:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ayj+gGQx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726799AbgGXV6G (ORCPT ); Fri, 24 Jul 2020 17:58:06 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:51496 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726593AbgGXV6F (ORCPT ); Fri, 24 Jul 2020 17:58:05 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06OLq4sm002221; Fri, 24 Jul 2020 21:57:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=1oBpwicAEdCFtd8cODZuHTMOvYVeTmLh/YcPQDEdJNc=; b=ayj+gGQxh8t1wRDZ0NHcmvj5ruFMbbhoDIRWrhsqiGKOUFwzCcusI1w27U7G0Y5jxmCA r2uI2s/O6DEG1E2Jl8yPoVf/sHteiPufnJEN814y47ye91X2IuGXI33Ee27YztDnx+Mw 2d0HddH9jHUDZInOXi5meqUhKYZHeYLw0vn75uuLvFCP4Fz2OZwkAoXOLy85kQCSLLQG 8Caju+WksZUvF5QicYL45BhtkehuUz6Rnb7yciNseGcrCOpaBy+9iN9dhedKAqi3UkFh UCrdDbgGqY78R1fjPEVoThYPMg7OVXGZlwzizbdpzt7YN2BVWVmxMgu74Xd3Ac5/yxlf rw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 32d6kt5ka6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Jul 2020 21:57:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06OLrC0K071765; Fri, 24 Jul 2020 21:55:24 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 32g7xv0208-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jul 2020 21:55:24 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06OLtMWK017794; Fri, 24 Jul 2020 21:55:22 GMT Received: from dhcp-10-159-245-90.vpn.oracle.com (/10.159.245.90) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Jul 2020 14:55:22 -0700 Subject: Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy To: "arm@kernel.org" , Arnd Bergmann , Olof Johansson Cc: Grygorii Strashko , Murali Karicheri , Santosh Shilimkar , Sekhar Nori , linux-arm-kernel@lists.infradead.org, "David S . Miller" , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, Oleksij Rempel , Andrew Lunn , Philippe Schenker References: <20200724214221.28125-1-grygorii.strashko@ti.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Fri, 24 Jul 2020 14:55:19 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200724214221.28125-1-grygorii.strashko@ti.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9692 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 suspectscore=3 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007240146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9692 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=3 bulkscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007240146 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Arnd, Olof, On 7/24/20 2:42 PM, Grygorii Strashko wrote: > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. > > The above board have phy-mode = "rgmii-id" and it is worked before because > KSZ9031 PHY started with default RGMII internal delays configuration (TX > off, RX on 1.2 ns) and MAC provided TX delay by default. > After above commit, the KSZ9031 PHY starts handling phy mode properly and > enables both RX and TX delays, as result networking is become broken. > > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous > behavior. > > Cc: Oleksij Rempel > Cc: Andrew Lunn > Cc: Philippe Schenker > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") > Signed-off-by: Grygorii Strashko > --- > Fix for one more broken TI board with KSZ9031 PHY. Can you please apply this patch to your v5.8 fixes branch and send it upstream ? Without the fix K2G EVM board is broken with v5.8. Am hoping you can pick this up with pull request since it just one patch. Regards, Santosh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC71FC433E0 for ; Fri, 24 Jul 2020 21:59:14 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id AAE2E206F0 for ; Fri, 24 Jul 2020 21:59:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="2RyFx8tU"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="ayj+gGQx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org AAE2E206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fZJWPtr8Af4mohKfrpSrNrmF2EhwnH4mJQ35ZUjplwQ=; b=2RyFx8tUeBxRg2BgwW8Ta7Hc+ a5gHEfarwMCtnACy84MWL48/LnxrOrYHjGClFTtgO3rFDAdlL/WVJlevgi5fj6/SE8KapCkstzE+v mQ3FAYUu+e12eDJH69z/bn1DwNaXCEiae7jwJzG4z+cJAWtOxPdj1VnYg7qHn/mERgzTQLZsfRtJN zgS9qDw2fTpjNheXjl4CxHgalv2C+uyU3XvPrrVqrXIRVV32+vyX5MslqvS8s2fhVS2XuxHstTwAj UwmZNKI4xegDl0gAXvn6TgbRI3T02ogmTTNiK34NAgqwUC+/PjmsTk76ENLjLzvUOzbomCJa9sNpU zU6NjcY9w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jz5hH-0003xJ-94; Fri, 24 Jul 2020 21:57:43 +0000 Received: from userp2120.oracle.com ([156.151.31.85]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jz5hE-0003vc-E4 for linux-arm-kernel@lists.infradead.org; Fri, 24 Jul 2020 21:57:41 +0000 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06OLq4sm002221; Fri, 24 Jul 2020 21:57:25 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=1oBpwicAEdCFtd8cODZuHTMOvYVeTmLh/YcPQDEdJNc=; b=ayj+gGQxh8t1wRDZ0NHcmvj5ruFMbbhoDIRWrhsqiGKOUFwzCcusI1w27U7G0Y5jxmCA r2uI2s/O6DEG1E2Jl8yPoVf/sHteiPufnJEN814y47ye91X2IuGXI33Ee27YztDnx+Mw 2d0HddH9jHUDZInOXi5meqUhKYZHeYLw0vn75uuLvFCP4Fz2OZwkAoXOLy85kQCSLLQG 8Caju+WksZUvF5QicYL45BhtkehuUz6Rnb7yciNseGcrCOpaBy+9iN9dhedKAqi3UkFh UCrdDbgGqY78R1fjPEVoThYPMg7OVXGZlwzizbdpzt7YN2BVWVmxMgu74Xd3Ac5/yxlf rw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 32d6kt5ka6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 24 Jul 2020 21:57:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 06OLrC0K071765; Fri, 24 Jul 2020 21:55:24 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 32g7xv0208-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 24 Jul 2020 21:55:24 +0000 Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 06OLtMWK017794; Fri, 24 Jul 2020 21:55:22 GMT Received: from dhcp-10-159-245-90.vpn.oracle.com (/10.159.245.90) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Fri, 24 Jul 2020 14:55:22 -0700 Subject: Re: [RESEND PATCH] ARM: dts: keystone-k2g-evm: fix rgmii phy-mode for ksz9031 phy To: "arm@kernel.org" , Arnd Bergmann , Olof Johansson References: <20200724214221.28125-1-grygorii.strashko@ti.com> From: "santosh.shilimkar@oracle.com" Organization: Oracle Corporation Message-ID: Date: Fri, 24 Jul 2020 14:55:19 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200724214221.28125-1-grygorii.strashko@ti.com> Content-Language: en-US X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9692 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 adultscore=0 mlxlogscore=999 malwarescore=0 bulkscore=0 suspectscore=3 phishscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007240146 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9692 signatures=668680 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 suspectscore=3 bulkscore=0 mlxscore=0 mlxlogscore=999 impostorscore=0 priorityscore=1501 lowpriorityscore=0 phishscore=0 spamscore=0 adultscore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2006250000 definitions=main-2007240146 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200724_175740_619662_DD4547E6 X-CRM114-Status: GOOD ( 24.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Philippe Schenker , Grygorii Strashko , Andrew Lunn , netdev@vger.kernel.org, Sekhar Nori , linux-kernel@vger.kernel.org, Oleksij Rempel , Murali Karicheri , Santosh Shilimkar , "David S . Miller" , linux-arm-kernel@lists.infradead.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Arnd, Olof, On 7/24/20 2:42 PM, Grygorii Strashko wrote: > Since commit bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the > KSZ9031 PHY") the networking is broken on keystone-k2g-evm board. > > The above board have phy-mode = "rgmii-id" and it is worked before because > KSZ9031 PHY started with default RGMII internal delays configuration (TX > off, RX on 1.2 ns) and MAC provided TX delay by default. > After above commit, the KSZ9031 PHY starts handling phy mode properly and > enables both RX and TX delays, as result networking is become broken. > > Fix it by switching to phy-mode = "rgmii-rxid" to reflect previous > behavior. > > Cc: Oleksij Rempel > Cc: Andrew Lunn > Cc: Philippe Schenker > Fixes: bcf3440c6dd7 ("net: phy: micrel: add phy-mode support for the KSZ9031 PHY") > Signed-off-by: Grygorii Strashko > --- > Fix for one more broken TI board with KSZ9031 PHY. Can you please apply this patch to your v5.8 fixes branch and send it upstream ? Without the fix K2G EVM board is broken with v5.8. Am hoping you can pick this up with pull request since it just one patch. Regards, Santosh _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel