From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F0F2C433E0 for ; Tue, 2 Jun 2020 12:48:08 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5DB38206A2 for ; Tue, 2 Jun 2020 12:48:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5DB38206A2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg6Kf-0001OM-L5; Tue, 02 Jun 2020 12:47:53 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1jg6Ke-0001OH-0s for xen-devel@lists.xenproject.org; Tue, 02 Jun 2020 12:47:52 +0000 X-Inumbo-ID: 44d5b408-a4cf-11ea-abea-12813bfff9fa Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 44d5b408-a4cf-11ea-abea-12813bfff9fa; Tue, 02 Jun 2020 12:47:51 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 52389ACF1; Tue, 2 Jun 2020 12:47:52 +0000 (UTC) Subject: Re: [PATCH v2 for-4.14 1/3] xen/monitor: Control register values To: Tamas K Lengyel References: <20200602110223.GW1195@Air-de-Roger> From: Jan Beulich Message-ID: Date: Tue, 2 Jun 2020 14:47:47 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: Petre Pircalabu , Stefano Stabellini , Julien Grall , Wei Liu , Andrew Cooper , Ian Jackson , George Dunlap , Alexandru Isaila , Xen-devel , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" On 02.06.2020 14:40, Tamas K Lengyel wrote: > On Tue, Jun 2, 2020 at 5:08 AM Roger Pau Monné wrote: >> >> On Wed, May 20, 2020 at 08:31:52PM -0600, Tamas K Lengyel wrote: >>> Extend the monitor_op domctl to include option that enables >>> controlling what values certain registers are permitted to hold >>> by a monitor subscriber. >> >> I think the change could benefit for some more detail commit message >> here. Why is this useful? > > You would have to ask the Bitdefender folks who made the feature. I > don't use it. Here we are just making it optional as it is buggy so it > is disabled by default. Now that's exactly the opposite of what I had derived from the description here so far. Perhaps an at least weak indication that you want to reword this. For example, from your reply to Roger I understand it's rather that the new flag allows to "suppress" the controlling (since presumably you don't change default behavior), rather then "enabling" it. >> There already seems to be some support for gating MSR writes, which >> seems to be expanded by this commit? > > We don't expand on any existing features, we make an existing feature optional. > >> >> Is it solving some kind of bug reported? > > It does, please take a look at the cover letter. Please can such important aspects also go in the commit message, so they're available later without needing to hunt down mail threads (besides this way being more readily available to reviewers)? Jan