From mboxrd@z Thu Jan 1 00:00:00 1970 From: Patrick Menschel Subject: Re: [PATCH v3 1/4] ARM: dts: sun4i: Add CAN node Date: Tue, 4 Apr 2017 18:54:35 +0200 Message-ID: References: <1491238814-4888-1-git-send-email-menschel.p@posteo.de> <1491238814-4888-2-git-send-email-menschel.p@posteo.de> <20170404154018.6phu2udfgwuzklkk@lukather> Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="------------ms060502010705000902040604" Return-path: Received: from mout02.posteo.de ([185.67.36.66]:52823 "EHLO mout02.posteo.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752348AbdDDQyu (ORCPT ); Tue, 4 Apr 2017 12:54:50 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 7C38F209E8 for ; Tue, 4 Apr 2017 18:54:48 +0200 (CEST) In-Reply-To: <20170404154018.6phu2udfgwuzklkk@lukather> Sender: linux-can-owner@vger.kernel.org List-ID: To: Maxime Ripard Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk, wens@csie.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-can@vger.kernel.org This is a cryptographically signed message in MIME format. --------------ms060502010705000902040604 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable Am 04.04.2017 um 17:40 schrieb Maxime Ripard: > On Mon, Apr 03, 2017 at 07:00:11PM +0200, Patrick Menschel wrote: >> The A10 SoC has an on-board CAN controller. >> This patch adds the device node. >> >> This patch is adapted from the description in >> Documentation/devicetree/bindings/net/can/sun4i_can.txt >> >> Signed-off-by: Patrick Menschel >> --- >> arch/arm/boot/dts/sun4i-a10.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4= i-a10.dtsi >> index ba20b48..7c559e7 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -1313,6 +1313,14 @@ >> #size-cells =3D <0>; >> }; >> =20 >> + can0: can@01c2bc00 { >> + compatible =3D "allwinner,sun4i-a10-can"; >> + reg =3D <0x01c2bc00 0x400>; >> + interrupts =3D <26>; >> + clocks =3D <&apb1_gates 4>; >> + status =3D "disabled"; >> + }; >> + > This wasn't ordered properly. Fixed and applied. > > Now that you mention it, ps20 and ps21 do not follow follow the rising address order. uart7: serial@01c29c00 { ... i2c0: i2c@01c2ac00 { ... i2c1: i2c@01c2b000 { ... i2c2: i2c@01c2b400 { ... can0: can@01c2bc00 { ... ps20: ps2@01c2a000 { .... ps21: ps2@01c2a400 { ... =20 The correct order would be uart7, ps20, ps21, i2c0, i2c1, i2c2, can0 . I'll fix that in patch v4. Thanks, Patrick --------------ms060502010705000902040604 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExDzANBglghkgBZQMEAgEFADCABgkqhkiG9w0BBwEAAKCC CfcwggSvMIIDl6ADAgECAhEA4CPLFRKDU4mtYW56VGdrITANBgkqhkiG9w0BAQsFADBvMQsw CQYDVQQGEwJTRTEUMBIGA1UEChMLQWRkVHJ1c3QgQUIxJjAkBgNVBAsTHUFkZFRydXN0IEV4 dGVybmFsIFRUUCBOZXR3b3JrMSIwIAYDVQQDExlBZGRUcnVzdCBFeHRlcm5hbCBDQSBSb290 MB4XDTE0MTIyMjAwMDAwMFoXDTIwMDUzMDEwNDgzOFowgZsxCzAJBgNVBAYTAkdCMRswGQYD VQQIExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNVBAoTEUNP TU9ETyBDQSBMaW1pdGVkMUEwPwYDVQQDEzhDT01PRE8gU0hBLTI1NiBDbGllbnQgQXV0aGVu dGljYXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQTCCASIwDQYJKoZIhvcNAQEBBQADggEPADCC AQoCggEBAImxDdp6UxlOcFIdvFamBia3uEngludRq/HwWhNJFaO0jBtgvHpRQqd5jKQi3xdh TpHVdiMKFNNKAn+2HQmAbqUEPdm6uxb+oYepLkNSQxZ8rzJQyKZPWukI2M+TJZx7iOgwZOak +FaA/SokFDMXmaxE5WmLo0YGS8Iz1OlAnwawsayTQLm1CJM6nCpToxDbPSBhPFUDjtlOdiUC ISn6o3xxdk/u4V+B6ftUgNvDezVSt4TeIj0sMC0xf1m9UjewM2ktQ+v61qXxl3dnUYzZ7ifr vKUHOHaMpKk4/9+M9QOsSb7K93OZOg8yq5yVOhM9DkY6V3RhUL7GQD/L5OKfoiECAwEAAaOC ARcwggETMB8GA1UdIwQYMBaAFK29mHo0tCb3+sQmVO8DveAky1QaMB0GA1UdDgQWBBSSYWuC 4aKgqk/sZ/HCo/e0gADB7DAOBgNVHQ8BAf8EBAMCAYYwEgYDVR0TAQH/BAgwBgEB/wIBADAd BgNVHSUEFjAUBggrBgEFBQcDAgYIKwYBBQUHAwQwEQYDVR0gBAowCDAGBgRVHSAAMEQGA1Ud HwQ9MDswOaA3oDWGM2h0dHA6Ly9jcmwudXNlcnRydXN0LmNvbS9BZGRUcnVzdEV4dGVybmFs Q0FSb290LmNybDA1BggrBgEFBQcBAQQpMCcwJQYIKwYBBQUHMAGGGWh0dHA6Ly9vY3NwLnVz ZXJ0cnVzdC5jb20wDQYJKoZIhvcNAQELBQADggEBABsqbqxVwTqriMXY7c1V86prYSvACRAj mQ/FZmpvsfW0tXdeDwJhAN99Bf4Ss6SAgAD8+x1banICCkG8BbrBWNUmwurVTYT7/oKYz1gb 4yJjnFL4uwU2q31Ypd6rO2Pl2tVz7+zg+3vio//wQiOcyraNTT7kSxgDsqgt1Ni7QkuQaYUQ 26Y3NOh74AEQpZzKOsefT4g0bopl0BqKu6ncyso20fT8wmQpNa/WsadxEdIDQ7GPPprsnjJT 9HaSyoY0B7ksyuYcStiZDcGG4pCS+1pCaiMhEOllx/XVu37qjIUgAmLq0ToHLFnFmTPyOInl tukWeh95FPZKEBom+nyK+5swggVAMIIEKKADAgECAhEAvREavCLRTrKKuEIsseliUTANBgkq hkiG9w0BAQsFADCBmzELMAkGA1UEBhMCR0IxGzAZBgNVBAgTEkdyZWF0ZXIgTWFuY2hlc3Rl cjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RPIENBIExpbWl0ZWQxQTA/BgNV BAMTOENPTU9ETyBTSEEtMjU2IENsaWVudCBBdXRoZW50aWNhdGlvbiBhbmQgU2VjdXJlIEVt YWlsIENBMB4XDTE2MDYwNDAwMDAwMFoXDTE3MDYwNDIzNTk1OVowJTEjMCEGCSqGSIb3DQEJ ARYUbWVuc2NoZWwucEBwb3N0ZW8uZGUwggEiMA0GCSqGSIb3DQEBAQUAA4IBDwAwggEKAoIB AQDhF/cULHYMLK+xHh/HbwO1aY3M+56GI9uRfRLAJWEEpdSFWvW8whRizlAZ0t9eHDzzCI1l wi7xDKBfwJt3VNxVjqHs3JjpcxSln/22AF3t8BKy3ACUtw6COlAk7bbwxr29qf7R4wFjumdS AS4uc6vDEBqlLrpdQCICwgOne97Dvi849VmbCBTCLTDpMxgrOXkiveGmQ2wBqLEPU/9o5ZH8 jcCbenY5GZTh7u4gvigPfgIu79jE3dS6he+c64SWgcD7bI/zA9KMCkRuvLrFnN+bu8TeH9jy FpdsFuJ4+7mjoYsalR7S/wm0M7pbcZEDw2fJp4XogbLFmpjIlJjA8QM1AgMBAAGjggHyMIIB 7jAfBgNVHSMEGDAWgBSSYWuC4aKgqk/sZ/HCo/e0gADB7DAdBgNVHQ4EFgQUsac6ykMiqHZ3 OqhHkkcxeF9NoW8wDgYDVR0PAQH/BAQDAgWgMAwGA1UdEwEB/wQCMAAwIAYDVR0lBBkwFwYI KwYBBQUHAwQGCysGAQQBsjEBAwUCMBEGCWCGSAGG+EIBAQQEAwIFIDBGBgNVHSAEPzA9MDsG DCsGAQQBsjEBAgEBATArMCkGCCsGAQUFBwIBFh1odHRwczovL3NlY3VyZS5jb21vZG8ubmV0 L0NQUzBdBgNVHR8EVjBUMFKgUKBOhkxodHRwOi8vY3JsLmNvbW9kb2NhLmNvbS9DT01PRE9T SEEyNTZDbGllbnRBdXRoZW50aWNhdGlvbmFuZFNlY3VyZUVtYWlsQ0EuY3JsMIGQBggrBgEF BQcBAQSBgzCBgDBYBggrBgEFBQcwAoZMaHR0cDovL2NydC5jb21vZG9jYS5jb20vQ09NT0RP U0hBMjU2Q2xpZW50QXV0aGVudGljYXRpb25hbmRTZWN1cmVFbWFpbENBLmNydDAkBggrBgEF BQcwAYYYaHR0cDovL29jc3AuY29tb2RvY2EuY29tMB8GA1UdEQQYMBaBFG1lbnNjaGVsLnBA cG9zdGVvLmRlMA0GCSqGSIb3DQEBCwUAA4IBAQBSqnMFVFL1I7Hr3/FWhV3r0cHCSYrAAJu0 lpgUJcvf6TOGuWNTksdyxbRFWyB6uc6trI9VrQHXbUhHHaUOPyDYBT50Xv4BrgIFYpQe7JI1 IYPyE5PAR4323CeOTADK4S7KyerSRm7ZnqRCOHp6NTC/2cehFgkfCuO01AeRmzyA8arANiZf TS2rPtd31PjpBQ0OpngLxn2qWEIf90Ibq+XxSuiXaLg4l2PI/975QLi0nn466Ql7U2nUeawn R34LMZk1c2ImpKZUX+cpz17btGWyohXSdXLQnrruWvO2dx4F5AjuJ/F8JHbIm17I/mlzh883 4e16eovJEoiXCNVlmxZ3MYIERDCCBEACAQEwgbEwgZsxCzAJBgNVBAYTAkdCMRswGQYDVQQI ExJHcmVhdGVyIE1hbmNoZXN0ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNVBAoTEUNPTU9E TyBDQSBMaW1pdGVkMUEwPwYDVQQDEzhDT01PRE8gU0hBLTI1NiBDbGllbnQgQXV0aGVudGlj YXRpb24gYW5kIFNlY3VyZSBFbWFpbCBDQQIRAL0RGrwi0U6yirhCLLHpYlEwDQYJYIZIAWUD BAIBBQCgggJjMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE3 MDQwNDE2NTQzNVowLwYJKoZIhvcNAQkEMSIEILmGCD4imy/UGkerIpiA5HKDz3pdXzCLY1jC 1URUUp5LMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEqMAsGCWCGSAFlAwQBAjAKBggq hkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwICAUAwBwYFKw4DAgcwDQYIKoZI hvcNAwICASgwgcIGCSsGAQQBgjcQBDGBtDCBsTCBmzELMAkGA1UEBhMCR0IxGzAZBgNVBAgT EkdyZWF0ZXIgTWFuY2hlc3RlcjEQMA4GA1UEBxMHU2FsZm9yZDEaMBgGA1UEChMRQ09NT0RP IENBIExpbWl0ZWQxQTA/BgNVBAMTOENPTU9ETyBTSEEtMjU2IENsaWVudCBBdXRoZW50aWNh dGlvbiBhbmQgU2VjdXJlIEVtYWlsIENBAhEAvREavCLRTrKKuEIsseliUTCBxAYLKoZIhvcN AQkQAgsxgbSggbEwgZsxCzAJBgNVBAYTAkdCMRswGQYDVQQIExJHcmVhdGVyIE1hbmNoZXN0 ZXIxEDAOBgNVBAcTB1NhbGZvcmQxGjAYBgNVBAoTEUNPTU9ETyBDQSBMaW1pdGVkMUEwPwYD VQQDEzhDT01PRE8gU0hBLTI1NiBDbGllbnQgQXV0aGVudGljYXRpb24gYW5kIFNlY3VyZSBF bWFpbCBDQQIRAL0RGrwi0U6yirhCLLHpYlEwDQYJKoZIhvcNAQEBBQAEggEArkNeLIcMD8V0 EwudhHMKSlrqpPBMy8CGSmVgBhm1wob/E9QlP2sX4UJEniCik88HbscprATnYXD2YaCKu+oJ nbfUiqxkQvw+/9ineAtLYybMZpHRMCTC1C3JaNHtBXHOOvrry4Is6sGSEuabPFSQk2R0+IDL xZa4xyD7IJzs+5mZuSNysZjL6K5AYDejh9KoeLhFqWRXpy14UWD3zdFI7q+5HPBEQBxdS/kd amaaQt08l/FY2zVlGjQDRTJ0JDZy0jdxd4D7dkQNuVzkXzMYk98DbIqeZk7nQrMy8VtBr6D9 oAJP9EMNtIQjXBmx4EVeb6TxeA+IcmFl0yBV+8IWWwAAAAAAAA== --------------ms060502010705000902040604-- From mboxrd@z Thu Jan 1 00:00:00 1970 From: menschel.p@posteo.de (Patrick Menschel) Date: Tue, 4 Apr 2017 18:54:35 +0200 Subject: [PATCH v3 1/4] ARM: dts: sun4i: Add CAN node In-Reply-To: <20170404154018.6phu2udfgwuzklkk@lukather> References: <1491238814-4888-1-git-send-email-menschel.p@posteo.de> <1491238814-4888-2-git-send-email-menschel.p@posteo.de> <20170404154018.6phu2udfgwuzklkk@lukather> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am 04.04.2017 um 17:40 schrieb Maxime Ripard: > On Mon, Apr 03, 2017 at 07:00:11PM +0200, Patrick Menschel wrote: >> The A10 SoC has an on-board CAN controller. >> This patch adds the device node. >> >> This patch is adapted from the description in >> Documentation/devicetree/bindings/net/can/sun4i_can.txt >> >> Signed-off-by: Patrick Menschel >> --- >> arch/arm/boot/dts/sun4i-a10.dtsi | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi >> index ba20b48..7c559e7 100644 >> --- a/arch/arm/boot/dts/sun4i-a10.dtsi >> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi >> @@ -1313,6 +1313,14 @@ >> #size-cells = <0>; >> }; >> >> + can0: can at 01c2bc00 { >> + compatible = "allwinner,sun4i-a10-can"; >> + reg = <0x01c2bc00 0x400>; >> + interrupts = <26>; >> + clocks = <&apb1_gates 4>; >> + status = "disabled"; >> + }; >> + > This wasn't ordered properly. Fixed and applied. > > Now that you mention it, ps20 and ps21 do not follow follow the rising address order. uart7: serial at 01c29c00 { ... i2c0: i2c at 01c2ac00 { ... i2c1: i2c at 01c2b000 { ... i2c2: i2c at 01c2b400 { ... can0: can at 01c2bc00 { ... ps20: ps2 at 01c2a000 { .... ps21: ps2 at 01c2a400 { ... The correct order would be uart7, ps20, ps21, i2c0, i2c1, i2c2, can0 . I'll fix that in patch v4. Thanks, Patrick -------------- next part -------------- A non-text attachment was scrubbed... Name: smime.p7s Type: application/pkcs7-signature Size: 3709 bytes Desc: S/MIME Cryptographic Signature URL: