From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751875AbdDKEJI (ORCPT <rfc822;w@1wt.eu>);
        Tue, 11 Apr 2017 00:09:08 -0400
Received: from edison.jonmasters.org ([173.255.233.168]:35002 "EHLO
        edison.jonmasters.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1750721AbdDKEJH (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 11 Apr 2017 00:09:07 -0400
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, linux-efi@vger.kernel.org,
        Ingo Molnar <mingo@kernel.org>, Thomas Gleixner <tglx@linutronix.de>,
        "H . Peter Anvin" <hpa@zytor.com>
References: <20170404160245.27812-1-ard.biesheuvel@linaro.org>
 <20170404160910.28115-1-ard.biesheuvel@linaro.org>
 <20170404160910.28115-2-ard.biesheuvel@linaro.org>
Cc: matt@codeblueprint.co.uk, mark.rutland@arm.com, roy.franz@cavium.com,
        rruigrok@codeaurora.org, leif.lindholm@linaro.org,
        jhugo@codeaurora.org, evgeny.kalugin@intel.com, eugene@hp.com,
        bp@alien8.de, bhsharma@redhat.com, bhe@redhat.com,
        linux-kernel@vger.kernel.org
From: Jon Masters <jcm@jonmasters.org>
Organization: World Organi{s,z}ation Of Broken Dreams
Message-ID: <a9363868-c4a4-e504-25e1-3813190a3db0@jonmasters.org>
Date: Tue, 11 Apr 2017 00:08:39 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.0
MIME-Version: 1.0
In-Reply-To: <20170404160910.28115-2-ard.biesheuvel@linaro.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SA-Exim-Connect-IP: 74.92.29.237
X-SA-Exim-Mail-From: jcm@jonmasters.org
Subject: Re: [PATCH 11/12] efi/libstub: arm/arm64: Disable debug prints on
 'quiet' cmdline arg
X-SA-Exim-Version: 4.2.1 (built Sun, 08 Nov 2009 07:31:22 +0000)
X-SA-Exim-Scanned: Yes (on edison.jonmasters.org)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/04/2017 12:09 PM, Ard Biesheuvel wrote:
> The EFI stub currently prints a number of diagnostic messages that do
> not carry a lot of information. Since these prints are not controlled
> by 'loglevel' or other command line parameters, and since they appear on
> the EFI framebuffer as well (if enabled), it would be nice if we could
> turn them off.
> 
> So let's add support for the 'quiet' command line parameter in the stub,
> and disable the non-error prints if it is passed.

> +extern int __pure is_quiet(void);
> +
> +#define pr_efi(sys_table, msg)		do {				\
> +	if (!is_quiet()) efi_printk(sys_table, "EFI stub: "msg);	\
> +} while (0)
> +
> +#define pr_efi_err(sys_table, msg) efi_printk(sys_table, "EFI stub: ERROR: "msg)

Thanks for this one :)

Jon.