From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B592AC433DB for ; Tue, 12 Jan 2021 13:47:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 606AE22B30 for ; Tue, 12 Jan 2021 13:47:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732459AbhALNr6 convert rfc822-to-8bit (ORCPT ); Tue, 12 Jan 2021 08:47:58 -0500 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]:28121 "EHLO eu-smtp-delivery-151.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731385AbhALNr5 (ORCPT ); Tue, 12 Jan 2021 08:47:57 -0500 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-244-i8hIuy4hNtCF7lb5ZonnQQ-1; Tue, 12 Jan 2021 13:46:18 +0000 X-MC-Unique: i8hIuy4hNtCF7lb5ZonnQQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 12 Jan 2021 13:46:16 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 12 Jan 2021 13:46:16 +0000 From: David Laight To: 'Florian Weimer' , Lukas Wunner CC: Linus Torvalds , Will Deacon , Peter Zijlstra , Arnd Bergmann , Russell King - ARM Linux admin , "linux-toolchains@vger.kernel.org" , "Mark Rutland" , Theodore Ts'o , "linux-kernel@vger.kernel.org" , Andreas Dilger , Ext4 Developers List , Linux ARM Subject: RE: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Thread-Topic: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Thread-Index: AQHW6OeTm0FM5rtghkqQZIJPrgzUmKokAGNg Date: Tue, 12 Jan 2021 13:46:16 +0000 Message-ID: References: <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> <20210108092655.GA4031@willie-the-truck> <20210112132049.GA26096@wunner.de> <877doii8n2.fsf@oldenburg2.str.redhat.com> In-Reply-To: <877doii8n2.fsf@oldenburg2.str.redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Weimer > Sent: 12 January 2021 13:32 > > * Lukas Wunner: > > > On Fri, Jan 08, 2021 at 12:02:53PM -0800, Linus Torvalds wrote: > >> I appreciate Arnd pointing out "--std=gnu11", though. What are the > >> actual relevant language improvements? > >> > >> Variable declarations in for-loops is the only one I can think of. I > >> think that would clean up some code (and some macros), but might not > >> be compelling on its own. > > > > Anonymous structs/unions. I used to have a use case for that in > > struct efi_dev_path in include/linux/efi.h, but Ard Biesheuvel > > refactored it in a gnu89-compatible way for v5.7 with db8952e7094f. > > Aren't those a GNU extension supported since GCC 3.0? They are certainly pretty old. The 15 year old gcc we use for release builds (so binaries work on old distributions) supports them. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92CB2C433DB for ; Tue, 12 Jan 2021 13:49:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 358BB230F9 for ; Tue, 12 Jan 2021 13:49:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 358BB230F9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=ACULAB.COM Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:References:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=jsHip3wSAmz3T1U2KZExaG1CDIn3JOsQhKmnLKCSQbU=; b=JjUIZWBw1bw84BMnnBUoSVw6F 1QAUH4ZMps6Q4NI5c8F521rfDQRZBVNthEYIPQZcz/e7E+1UHh2d0c/5ED2NHGsQdazcs2uypjEHG cyAgPqkfYoYSs9Yc2z3zuelGGBV3AfOzzZFSUmvWRnHSgAlz+TqRhYiFa6XpkTccGdJ2iIiemDG/K owRKh0s54uA1i6eaHxQq9XczBjOnVNiczJi5LIdXebzsvQCmoWrPSbbL+pfzqdt3UB+H7LXYaNTta YAZ+ETKkyae0v06gWjXna+IgBvPQ3VnUzhbqE2oZnCxBmADcIE6PKlgyB2h6/DLvLG3Vwi+oy+vWi TQHfWMp1A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzK0Y-0002RY-Gl; Tue, 12 Jan 2021 13:46:50 +0000 Received: from eu-smtp-delivery-151.mimecast.com ([207.82.80.151]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kzK09-0002Jf-Bd for linux-arm-kernel@lists.infradead.org; Tue, 12 Jan 2021 13:46:30 +0000 Received: from AcuMS.aculab.com (156.67.243.126 [156.67.243.126]) (Using TLS) by relay.mimecast.com with ESMTP id uk-mta-244-i8hIuy4hNtCF7lb5ZonnQQ-1; Tue, 12 Jan 2021 13:46:18 +0000 X-MC-Unique: i8hIuy4hNtCF7lb5ZonnQQ-1 Received: from AcuMS.Aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) by AcuMS.aculab.com (fd9f:af1c:a25b:0:43c:695e:880f:8750) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Tue, 12 Jan 2021 13:46:16 +0000 Received: from AcuMS.Aculab.com ([fe80::43c:695e:880f:8750]) by AcuMS.aculab.com ([fe80::43c:695e:880f:8750%12]) with mapi id 15.00.1347.000; Tue, 12 Jan 2021 13:46:16 +0000 From: David Laight To: 'Florian Weimer' , Lukas Wunner Subject: RE: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Thread-Topic: Aarch64 EXT4FS inode checksum failures - seems to be weak memory ordering issues Thread-Index: AQHW6OeTm0FM5rtghkqQZIJPrgzUmKokAGNg Date: Tue, 12 Jan 2021 13:46:16 +0000 Message-ID: References: <20210106172033.GA2165@willie-the-truck> <20210106223223.GM1551@shell.armlinux.org.uk> <20210107111841.GN1551@shell.armlinux.org.uk> <20210107124506.GO1551@shell.armlinux.org.uk> <20210107133747.GP1551@shell.armlinux.org.uk> <20210108092655.GA4031@willie-the-truck> <20210112132049.GA26096@wunner.de> <877doii8n2.fsf@oldenburg2.str.redhat.com> In-Reply-To: <877doii8n2.fsf@oldenburg2.str.redhat.com> Accept-Language: en-GB, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.202.205.107] MIME-Version: 1.0 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=C51A453 smtp.mailfrom=david.laight@aculab.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: aculab.com Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210112_084625_628656_CEF3EBB0 X-CRM114-Status: GOOD ( 15.41 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Arnd Bergmann , Theodore Ts'o , Peter Zijlstra , Linus Torvalds , Russell King - ARM Linux admin , "linux-kernel@vger.kernel.org" , Andreas Dilger , "linux-toolchains@vger.kernel.org" , Ext4 Developers List , Will Deacon , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Florian Weimer > Sent: 12 January 2021 13:32 > > * Lukas Wunner: > > > On Fri, Jan 08, 2021 at 12:02:53PM -0800, Linus Torvalds wrote: > >> I appreciate Arnd pointing out "--std=gnu11", though. What are the > >> actual relevant language improvements? > >> > >> Variable declarations in for-loops is the only one I can think of. I > >> think that would clean up some code (and some macros), but might not > >> be compelling on its own. > > > > Anonymous structs/unions. I used to have a use case for that in > > struct efi_dev_path in include/linux/efi.h, but Ard Biesheuvel > > refactored it in a gnu89-compatible way for v5.7 with db8952e7094f. > > Aren't those a GNU extension supported since GCC 3.0? They are certainly pretty old. The 15 year old gcc we use for release builds (so binaries work on old distributions) supports them. David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel