From: Heinrich Schuchardt <xypron.glpk@gmx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init - Please, pull.
Date: Mon, 24 Jul 2017 20:37:53 +0200 [thread overview]
Message-ID: <a94e2859-92a3-8ca4-bfcc-de8f3e5b2597@gmx.de> (raw)
In-Reply-To: <20170625135455.GE27196@bill-the-cat>
On 06/25/2017 03:54 PM, Tom Rini wrote:
> On Sun, Jun 25, 2017 at 08:13:19AM +0200, Heinrich Schuchardt wrote:
>
>> Hello Tom,
>>
>> could you, please, pull the patch
>> https://patchwork.ozlabs.org/patch/751043/
>> which has been reviewed in April.
>
> I actually want to run-test this patch. I happen to have a platform,
> and I even set it up the other day, but forgot about this patch. I'll
> set it back up and test it, then apply. Thanks!
>
Hello Tom,
any update?
Regards
Heinrich
>>
>> Best regards
>>
>> Heinrich Schuchardt
>>
>> On 04/16/2017 09:34 PM, Simon Glass wrote:
>>> On 15 April 2017 at 08:11, Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>>>> ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01)
>>>> is always false.
>>>> This does not match the comment
>>>> /*Wait till that bit clears*/
>>>>
>>>> The problem was indicated by cppcheck.
>>>>
>>>> I do not have the hardware to test if the code change below
>>>> leads to a correct system behavior.
>>>>
>>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
>>>> ---
>>>> arch/arm/mach-omap2/omap3/emif4.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> Reviewed-by: Simon Glass <sjg@chromium.org>
>>>
>>
>
>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>
next prev parent reply other threads:[~2017-07-24 18:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-15 14:11 [U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init Heinrich Schuchardt
2017-04-16 19:34 ` Simon Glass
2017-06-25 6:13 ` [U-Boot] [RFC 1/1] omap3: incorrect logical check in do_emif4_init - Please, pull Heinrich Schuchardt
2017-06-25 13:54 ` Tom Rini
2017-07-24 18:37 ` Heinrich Schuchardt [this message]
2017-08-14 0:06 ` [U-Boot] [U-Boot, RFC, 1/1] omap3: incorrect logical check in do_emif4_init Tom Rini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a94e2859-92a3-8ca4-bfcc-de8f3e5b2597@gmx.de \
--to=xypron.glpk@gmx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.