From: Johannes Thumshirn <jthumshirn@suse.de>
To: Nikolay Borisov <nborisov@suse.com>, David Sterba <dsterba@suse.com>
Cc: Linux BTRFS Mailinglist <linux-btrfs@vger.kernel.org>
Subject: Re: [PATCH 3/3] btrfs: document extent mapping assumptions in checksum
Date: Wed, 28 Nov 2018 09:39:30 +0100 [thread overview]
Message-ID: <a951fe6f-d6e4-f03f-7986-13d2864db9e9@suse.de> (raw)
In-Reply-To: <9cc979bd-167f-fd92-1308-ebb1ca85bc99@suse.com>
On 27/11/2018 17:36, Nikolay Borisov wrote:
>
>
> On 27.11.18 г. 18:00 ч., Johannes Thumshirn wrote:
>> Document why map_private_extent_buffer() cannot return '1' (i.e. the map
>> spans two pages) for the csum_tree_block() case.
>>
>> The current algorithm for detecting a page boundary crossing in
>> map_private_extent_buffer() will return a '1' *IFF* the product of the
>
> I think the word product must be replaced with 'sum', since product
> implies multiplication :)
*doh* m)
Yes thanks for spotting this.
--
Johannes Thumshirn SUSE Labs
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
prev parent reply other threads:[~2018-11-28 8:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 16:00 [PATCH 0/3] Misc cosmetic changes for map_private_extent_buffer Johannes Thumshirn
2018-11-27 16:00 ` [PATCH 1/3] btrfs: don't initialize 'offset' in map_private_extent_buffer() Johannes Thumshirn
2018-11-27 16:31 ` Nikolay Borisov
2018-11-27 16:00 ` [PATCH 2/3] btrfs: use offset_in_page for start_offset " Johannes Thumshirn
2018-11-27 16:33 ` Nikolay Borisov
2018-11-27 16:00 ` [PATCH 3/3] btrfs: document extent mapping assumptions in checksum Johannes Thumshirn
2018-11-27 16:36 ` Nikolay Borisov
2018-11-27 19:08 ` Noah Massey
2018-11-27 19:32 ` Nikolay Borisov
2018-11-27 20:20 ` Noah Massey
2018-11-28 8:39 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a951fe6f-d6e4-f03f-7986-13d2864db9e9@suse.de \
--to=jthumshirn@suse.de \
--cc=dsterba@suse.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=nborisov@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.