All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Beulich <jbeulich@suse.com>
To: Tamas K Lengyel <tamas@tklengyel.com>
Cc: "xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
	"Andrew Cooper" <andrew.cooper3@citrix.com>,
	"Wei Liu" <wl@xen.org>, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [PATCH 1/2] x86/mem-sharing: ensure consistent lock order in get_two_gfns()
Date: Tue, 6 Jul 2021 15:13:58 +0200	[thread overview]
Message-ID: <a95a3f1e-afa5-30b7-f2f9-2e0ba1808b94@suse.com> (raw)
In-Reply-To: <CABfawhk4N-KznkFhmk3Q749tTp3X+j0fCwDXooYZEDdfQ7Fchw@mail.gmail.com>

On 06.07.2021 14:36, Tamas K Lengyel wrote:
> On Tue, Jun 29, 2021 at 8:54 AM Jan Beulich <jbeulich@suse.com> wrote:
>>
>> While the comment validly says "Sort by domain, if same domain by gfn",
>> the implementation also included equal domain IDs in the first part of
>> the check, thus rending the second part entirely dead and leaving
>> deadlock potential when there's only a single domain involved.
>>
>> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> 
> Acked-by: Tamas K Lengyel <tamas@tklengyel.com>

Thanks. Do you think I should queue this for backporting (once it got
applied)?

Jan



  reply	other threads:[~2021-07-06 13:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-29 12:53 [PATCH 0/2] x86/mem-sharing: a fix and some cleanup Jan Beulich
2021-06-29 12:53 ` [PATCH 1/2] x86/mem-sharing: ensure consistent lock order in get_two_gfns() Jan Beulich
2021-07-06 12:36   ` Tamas K Lengyel
2021-07-06 13:13     ` Jan Beulich [this message]
2021-07-06 13:37       ` Tamas K Lengyel
2021-06-29 12:54 ` [PATCH 2/2] x86/mem-sharing: mov {get,put}_two_gfns() Jan Beulich
2021-07-06 12:39   ` Tamas K Lengyel
2021-07-06  7:34 ` Ping: [PATCH 0/2] x86/mem-sharing: a fix and some cleanup Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a95a3f1e-afa5-30b7-f2f9-2e0ba1808b94@suse.com \
    --to=jbeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=tamas@tklengyel.com \
    --cc=wl@xen.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.