From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from lb3-smtp-cloud2.xs4all.net ([194.109.24.29]:59665 "EHLO
        lb3-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK)
        by vger.kernel.org with ESMTP id S1751890AbdDKN1R (ORCPT
        <rfc822;linux-media@vger.kernel.org>);
        Tue, 11 Apr 2017 09:27:17 -0400
Subject: Re: [PATCHv4 04/15] v4l: vsp1: Add histogram support
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
References: <20170410192651.18486-1-hverkuil@xs4all.nl>
 <20170410192651.18486-5-hverkuil@xs4all.nl>
 <20170411081728.4df93852@vento.lan>
Cc: linux-media@vger.kernel.org,
        Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
From: Hans Verkuil <hverkuil@xs4all.nl>
Message-ID: <a95e3ae3-de87-5ce4-cc68-4cda449d2fe3@xs4all.nl>
Date: Tue, 11 Apr 2017 15:27:12 +0200
MIME-Version: 1.0
In-Reply-To: <20170411081728.4df93852@vento.lan>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

On 04/11/17 13:17, Mauro Carvalho Chehab wrote:
> Em Mon, 10 Apr 2017 21:26:40 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
> 
>> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>
>> The histogram common code will be used to implement support for both the
>> HGO and HGT histogram computation engines.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> ---
>>  drivers/media/platform/Kconfig           |   1 +
>>  drivers/media/platform/vsp1/Makefile     |   1 +
>>  drivers/media/platform/vsp1/vsp1_histo.c | 646 +++++++++++++++++++++++++++++++
>>  drivers/media/platform/vsp1/vsp1_histo.h |  84 ++++
>>  4 files changed, 732 insertions(+)
>>  create mode 100644 drivers/media/platform/vsp1/vsp1_histo.c
>>  create mode 100644 drivers/media/platform/vsp1/vsp1_histo.h
> 
>> diff --git a/drivers/media/platform/vsp1/vsp1_histo.c b/drivers/media/platform/vsp1/vsp1_histo.c
>> new file mode 100644
>> index 000000000000..afab77cf4fa5
>> --- /dev/null
>> +++ b/drivers/media/platform/vsp1/vsp1_histo.c
> 
> ...
> 
>> +	crop = vsp1_entity_get_pad_selection(&histo->entity, config, sel->pad,
>> +					     V4L2_SEL_TGT_CROP);
>> +
>> +	/*
>> +	 * Clamp the width and height to acceptable values first and then
>> +	 * compute the closest rounded dividing ratio.
>> +	 *
>> +	 * Ratio	Rounded ratio
>> +	 * --------------------------
>> +	 * [1.0 1.5[	1
> 
> Nitpick:
> 
> 	1.0 1.5]	1

No, the notation [a b[ means the range 'a to, but not including, b'.

So this is correct.

I'm used to writing this as [a b), but according to wikipedia both notations
are allowed.

Regards,

	Hans

> 
> Thanks,
> Mauro
>