From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,UPPERCASE_50_75, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F3614C4320A for ; Fri, 6 Aug 2021 15:51:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C981A60F0F for ; Fri, 6 Aug 2021 15:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244774AbhHFPvX (ORCPT ); Fri, 6 Aug 2021 11:51:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:24847 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238025AbhHFPvW (ORCPT ); Fri, 6 Aug 2021 11:51:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628265065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+MvzS92Uk60oNAzw+Z3d407dSFOjXozPlgK3Ui3EuhY=; b=SRaw/YZvlGzVq9AnNY5qKTj+UvohuR2BOGecVwrRBt+Cl6f20+zsuVEU1S/BzgitCFWR8r I+1/a4V7OGvzQeCpke1vlcFVM4kdZx0+mSXosNCwiuqVUIJlr9tVfOPHVPmst7RBM43WGg V8zkyONvuHnOkEYvpuurqi1zNUZNTrc= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-187-zBw2lhEVMwicUlkkcuKw4A-1; Fri, 06 Aug 2021 11:51:04 -0400 X-MC-Unique: zBw2lhEVMwicUlkkcuKw4A-1 Received: by mail-ej1-f72.google.com with SMTP id a17-20020a1709062b11b02905882d7951afso3258944ejg.4 for ; Fri, 06 Aug 2021 08:51:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+MvzS92Uk60oNAzw+Z3d407dSFOjXozPlgK3Ui3EuhY=; b=aTmDlRmPT9B12DawihX9fikqMQxOBIGz6qAQRJV1ePKAk/PRiPpTpX36U2IQPMF+UF dghtejrg84qfdA4hKedtQHjdv9Rfl3r2H6UHsa3aIIy9T67gWEpXsc2t95MB+5br2UUU lKZldhJBD+nTSdeYS9mp2Oo145u7n6JmW/QrntOBqtNlk1yuBLB3fPddKdfHGx1+LZdx 9VmbnNGGsN/QcMA3dmktpampMTavvy3N9G+9XmvsAl+obTauZHprBKQtp+QEV43o50FS oB4lpmFg7R133cULpHWiXFlHECwHE13/N8iuj+2ly/kHpDmlzUqADkQxub3MqPPqUG4X GzSQ== X-Gm-Message-State: AOAM530KzujOq10cqLCXvcjmYXV4Frhm0yK1Y7myel9TatgDhktOoWHP 4LBb9mDiBDhQbcDREFMc4lyhbw6fKAu94T7GTpc9XVoNfpNGkSW5eZ1TJytDcQZPG0ItpdsC3RL pvm7Q8XGbB9/u0J2yEJ7De5UE X-Received: by 2002:a17:906:3b87:: with SMTP id u7mr10704604ejf.66.1628265063274; Fri, 06 Aug 2021 08:51:03 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwAe7/Ac/Nrk5QJgOh1300wanbnDOg/CO6BneIJR56E9sgbBIU8cyOWTJf37lCWXFCHY+PAtw== X-Received: by 2002:a17:906:3b87:: with SMTP id u7mr10704593ejf.66.1628265063117; Fri, 06 Aug 2021 08:51:03 -0700 (PDT) Received: from ?IPv6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.gmail.com with ESMTPSA id hc19sm2735104ejc.0.2021.08.06.08.51.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 06 Aug 2021 08:51:01 -0700 (PDT) Subject: Re: [PATCH v3 2/6] KVM: VMX: Extend BUILD_CONTROLS_SHADOW macro to support 64-bit variation To: Sean Christopherson , Zeng Guang Cc: Vitaly Kuznetsov , Wanpeng Li , Jim Mattson , Joerg Roedel , kvm@vger.kernel.org, Dave Hansen , Tony Luck , Kan Liang , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Kim Phillips , Jarkko Sakkinen , Jethro Beekman , Kai Huang , x86@kernel.org, linux-kernel@vger.kernel.org, Robert Hu , Gao Chao , Robert Hoo References: <20210805151317.19054-1-guang.zeng@intel.com> <20210805151317.19054-3-guang.zeng@intel.com> From: Paolo Bonzini Message-ID: Date: Fri, 6 Aug 2021 17:51:00 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/08/21 00:32, Sean Christopherson wrote: >> -BUILD_CONTROLS_SHADOW(vm_entry, VM_ENTRY_CONTROLS) >> -BUILD_CONTROLS_SHADOW(vm_exit, VM_EXIT_CONTROLS) >> -BUILD_CONTROLS_SHADOW(pin, PIN_BASED_VM_EXEC_CONTROL) >> -BUILD_CONTROLS_SHADOW(exec, CPU_BASED_VM_EXEC_CONTROL) >> -BUILD_CONTROLS_SHADOW(secondary_exec, SECONDARY_VM_EXEC_CONTROL) >> +BUILD_CONTROLS_SHADOW(vm_entry, VM_ENTRY_CONTROLS, 32) >> +BUILD_CONTROLS_SHADOW(vm_exit, VM_EXIT_CONTROLS, 32) >> +BUILD_CONTROLS_SHADOW(pin, PIN_BASED_VM_EXEC_CONTROL, 32) >> +BUILD_CONTROLS_SHADOW(exec, CPU_BASED_VM_EXEC_CONTROL, 32) >> +BUILD_CONTROLS_SHADOW(secondary_exec, SECONDARY_VM_EXEC_CONTROL, 32) >> +BUILD_CONTROLS_SHADOW(tertiary_exec, TERTIARY_VM_EXEC_CONTROL, 64) > > This fails to compile because all the TERTIARY collateral is in a later patch. > > I think I'd also prefer hiding the 32/64 param via more macros, e.g. > > #define __BUILD_CONTROLS_SHADOW(lname, uname, bits) \ No, please don't. :) Also because the 64 bit version is used only once. Agreed on keeping everything here except for TERTIARY_VM_EXEC_CONTROL, and moving that line to patch 3. Paolo