From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9A42C432BE for ; Thu, 26 Aug 2021 16:30:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 89BC9610A1 for ; Thu, 26 Aug 2021 16:30:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243091AbhHZQa7 (ORCPT ); Thu, 26 Aug 2021 12:30:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59958 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242049AbhHZQa6 (ORCPT ); Thu, 26 Aug 2021 12:30:58 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 559A0C061757 for ; Thu, 26 Aug 2021 09:30:11 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id w19so5337871oik.10 for ; Thu, 26 Aug 2021 09:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PR6KS+LXmrB0wt1ro7MtuwxKA0BwjesWn81kF/Hh73o=; b=AM52ANEjB1wjDtg5u0w3dUVHlvaCeFU7zNFXBKAVADkcLRaXOr8R35HZxRA+DHfSPA c4QNHowNEkY5Jk4K5di1VpK4wftb/9RT+8AaGKEzRqNYLLKdauZ5ooEa6BjGR5ryDeeU VKAH5WXXxFEcyTnSoQKJFW/RSbY82pXn/fpDzyM/CtjhjuonFoznoMz4utCqb1fsOByh sbswO5g1BItyRP1OuENauus5ZL4303PTCXC6L/MjDHN1bTHUOrabmyWiHeDZLz4ePif2 ln5jV4k0b71nDR0m3Wc/GdjCei0R7FT74eRymBiM12w0VgxYbO9YApLrM/mHCdUXF0FJ qDag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PR6KS+LXmrB0wt1ro7MtuwxKA0BwjesWn81kF/Hh73o=; b=RDz6HJBONYACxO/x436e/WpuR3OulHPM3HrvHheD/bQRuhf6yXwVwZx+GJf0Jgw6b/ ax+4al1RjKA5CeNIMSgy07LVoE31vFVVOFAN8W4RjVAi9kENjmoe/N1zeaQJyxxRWYI3 kPn/gGyta8GsvaO98lSAeDL0wXJmY4oRnGYev2E/sfAgrifpmVsd8CHczepGRy9EcF2S MFOQX7fDBmX9NNrBnRVXUq3FrXbtyeJmwAq97Vn3nVnuaHa7XERL11xuFuY2zvuU78IS 29PbLnq4gwQWTW5mq5FgvsytHt/Ld2MrDN/ZQ2vlE4z1aJJRa6V6cRUujXFm6OFI9EIh +OKQ== X-Gm-Message-State: AOAM532MSo3FHIUDnFX/GcaHdqEwOK4mjW/24zVfr15/5P7PBQ61N/Io H7yZjBabLFbyUd1x3Qb16mxDF/xQeF0= X-Google-Smtp-Source: ABdhPJyVBNWuH5oIxvYrXIJ0pd7Q1tY/uP5Ha/WLE2hcf3L3xPtuzoee7t2YXz3RHvfP3qr2+QNapA== X-Received: by 2002:aca:df88:: with SMTP id w130mr3113319oig.82.1629995410455; Thu, 26 Aug 2021 09:30:10 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id a23sm671483otp.44.2021.08.26.09.30.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 09:30:09 -0700 (PDT) Sender: Guenter Roeck Subject: Re: [PATCH] coresight: syscfg: fix compiler warnings To: Doug Anderson , Jian Cai Cc: Mike Leach , Matthias Kaehlcke , Manoj Gupta , Luis Lozano , coresight@lists.linaro.org, Linux ARM , clang-built-linux , Mathieu Poirier , Suzuki K Poulose , Leo Yan , Alexander Shishkin , LKML References: <20210825222514.2107728-1-jiancai@google.com> From: Guenter Roeck Message-ID: Date: Thu, 26 Aug 2021 09:30:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 8/26/21 9:19 AM, Doug Anderson wrote: > Hi, > > On Wed, Aug 25, 2021 at 3:25 PM Jian Cai wrote: >> >> This fixes warnings with -Wimplicit-function-declaration, e.g. >> >> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m >> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); >> ^[[0;1;32m ^ >> >> Signed-off-by: Jian Cai >> --- >> drivers/hwtracing/coresight/coresight-syscfg.c | 1 + >> 1 file changed, 1 insertion(+) > > Can you figure out which patch introduced these warnings and add a "Fixes" tag? > Assuming the SHA is stable, that would be commit 85e2414c518a ("coresight: syscfg: Initial coresight system configuration") Guenter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6962BC4320A for ; Thu, 26 Aug 2021 16:32:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B83160F5B for ; Thu, 26 Aug 2021 16:32:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3B83160F5B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=sroOvCWHVul1oNgCq+tWrKhTB7W8ekVxvUxWeoXJZv0=; b=VloFSTYGDS7IYti4Elk6/Ets8i Zqn6aXMF/utzIlXG5eT/4FSiWbVYI5cZonB2jx/kGwl7EpEOih91wUCLVaj3yBTJpso0rdyXyNVgp y5CEtBIllDjO4Yz0TuxuadF8vvs60CVLpxkGF1f3BN12xRL0qfIUYxq0/NzoP0LPOwDle1/O9bMOe xBwxUU3N5pf8d4SogQQ8v/5V271IYhSzfZaPbzlg11NoqtWA6GkPPRZ2zdGTE5lioUkWxay1GdsAf VUwgixMOWM0gLE9blS3g9GtiyGIidWE904ALBNx3j5m6w/GgBE/QA4Y8GxEfZw+QLpIuAK4MtCuyV GkOi0ckw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJIGe-00AZrU-EW; Thu, 26 Aug 2021 16:30:16 +0000 Received: from mail-oi1-x22e.google.com ([2607:f8b0:4864:20::22e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mJIGa-00AZqs-Ex for linux-arm-kernel@lists.infradead.org; Thu, 26 Aug 2021 16:30:13 +0000 Received: by mail-oi1-x22e.google.com with SMTP id h133so5370076oib.7 for ; Thu, 26 Aug 2021 09:30:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PR6KS+LXmrB0wt1ro7MtuwxKA0BwjesWn81kF/Hh73o=; b=AM52ANEjB1wjDtg5u0w3dUVHlvaCeFU7zNFXBKAVADkcLRaXOr8R35HZxRA+DHfSPA c4QNHowNEkY5Jk4K5di1VpK4wftb/9RT+8AaGKEzRqNYLLKdauZ5ooEa6BjGR5ryDeeU VKAH5WXXxFEcyTnSoQKJFW/RSbY82pXn/fpDzyM/CtjhjuonFoznoMz4utCqb1fsOByh sbswO5g1BItyRP1OuENauus5ZL4303PTCXC6L/MjDHN1bTHUOrabmyWiHeDZLz4ePif2 ln5jV4k0b71nDR0m3Wc/GdjCei0R7FT74eRymBiM12w0VgxYbO9YApLrM/mHCdUXF0FJ qDag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PR6KS+LXmrB0wt1ro7MtuwxKA0BwjesWn81kF/Hh73o=; b=f+wU9KQAHAQ49KdvfsZRREGYrMbvUIoIJyARF4oEji8i3xUrJXaClyd7Bq2Uueo6RB TIIATZdvA/JS7WIk5xIQz1H7OtxyM6VRTinPXWoBGTyOvAhpfOGtXDTLjGeSsOqP4+0b XoMyHunJ2CO8q98t0PuqXDl6goWZIf2VSasq40xuLn3MfgSJKAlzSAvCP2PsILAN6+mg bbxRlwG92F4hfytgd3oysD1jYHMxpcCpLCdC1KTe6FJPnnhJC4omHVWuzPtISABpqrqm ZmarxilN+QSSpVSVMQ9B6XxtqtM0GzsohAdJ+uqqfKA9m8HZKUxfjYJIpI3sZM/Cy26Y kuBw== X-Gm-Message-State: AOAM532xNDDZKU7LXJq10A/eaYSDWKn6GvNUP2KV00c9BEsxRkasEoBq RiRHwDWceFkI74onm8jRRbw= X-Google-Smtp-Source: ABdhPJyVBNWuH5oIxvYrXIJ0pd7Q1tY/uP5Ha/WLE2hcf3L3xPtuzoee7t2YXz3RHvfP3qr2+QNapA== X-Received: by 2002:aca:df88:: with SMTP id w130mr3113319oig.82.1629995410455; Thu, 26 Aug 2021 09:30:10 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id a23sm671483otp.44.2021.08.26.09.30.08 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 26 Aug 2021 09:30:09 -0700 (PDT) Subject: Re: [PATCH] coresight: syscfg: fix compiler warnings To: Doug Anderson , Jian Cai Cc: Mike Leach , Matthias Kaehlcke , Manoj Gupta , Luis Lozano , coresight@lists.linaro.org, Linux ARM , clang-built-linux , Mathieu Poirier , Suzuki K Poulose , Leo Yan , Alexander Shishkin , LKML References: <20210825222514.2107728-1-jiancai@google.com> From: Guenter Roeck Message-ID: Date: Thu, 26 Aug 2021 09:30:07 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210826_093012_559322_F47B1556 X-CRM114-Status: GOOD ( 16.18 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 8/26/21 9:19 AM, Doug Anderson wrote: > Hi, > > On Wed, Aug 25, 2021 at 3:25 PM Jian Cai wrote: >> >> This fixes warnings with -Wimplicit-function-declaration, e.g. >> >> ^[[1m/mnt/host/source/src/third_party/kernel/v5.4/drivers/hwtracing/coresight/coresight-syscfg.c:455:15: ^[[0m^[[0;1;31merror: ^[[0m^[[1mimplicit declaration of function 'kzalloc' [-Werror,-Wimplicit-function-declaration]^[[0m >> csdev_item = kzalloc(sizeof(struct cscfg_registered_csdev), GFP_KERNEL); >> ^[[0;1;32m ^ >> >> Signed-off-by: Jian Cai >> --- >> drivers/hwtracing/coresight/coresight-syscfg.c | 1 + >> 1 file changed, 1 insertion(+) > > Can you figure out which patch introduced these warnings and add a "Fixes" tag? > Assuming the SHA is stable, that would be commit 85e2414c518a ("coresight: syscfg: Initial coresight system configuration") Guenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel