From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCA8AECE58D for ; Mon, 7 Oct 2019 12:36:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92E8C205F4 for ; Mon, 7 Oct 2019 12:36:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ELijHLqw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727838AbfJGMgm (ORCPT ); Mon, 7 Oct 2019 08:36:42 -0400 Received: from mail-pg1-f195.google.com ([209.85.215.195]:40808 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727467AbfJGMgl (ORCPT ); Mon, 7 Oct 2019 08:36:41 -0400 Received: by mail-pg1-f195.google.com with SMTP id d26so8135900pgl.7; Mon, 07 Oct 2019 05:36:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HqwQr0izSdX/SrDz5Xc8kECyxj0ZoycAuN4//WzOtYY=; b=ELijHLqwYVBcZ5a4pvTvoiOZnNdiS812VSeLgoKLexclFzzKWbdmD/sqXgJXE1fjgD jNTF2NHmVmZVy92KNpNVm+7QyNq5COD2fmfoJmVswy9YWgF3Hr339NWveBlovP+L29xw 9tvp+7lFmllGAaI1D/5o1sRY0gl6+ySaUqgfqvE5EcDZwBtBHgxCpZrZ7c/y9V+QbvKH L7PIXI4qk+cgmMwKGIG9hJ9t+7qCG9ZJOjfdFkoefQi65vnJub5N2zxCfO6vSMUfZhof t6hD38lnd1ne6M4elbw2LdAkaXBGm588D8tsdVzjqYTJN26ZdMMtjJUTPupbM2P7LsO6 Jdsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HqwQr0izSdX/SrDz5Xc8kECyxj0ZoycAuN4//WzOtYY=; b=gNzuz4VAfRJW4bHgdZFVwHVH/ZM4aOsutAp3eF912x9r1ArL/MqPEy6edqYUEadBgu aiofB5spJzTRnIADX1g0C4AlMTOg/zj+lUFuhmgWI43gRE38hnRb7MXlSoHm02NDTMiZ PjE0fWd4CxNeekN1Z9jjXboGM27bCreSqreP0qGDojQ1uU1EngG50Az6T+/iMiYdh3Hz 55z+SrtHzG5DPmLFn6smysv9l9W/9dEKTmyX7nY7IYpLpi+4WCePZ8eUm0Ucb7xOIJv7 xzB700H0R4RWPhL5o55D3Kqfo6TVTzg+9MuTVf6kUwJQhB0CNTOuS3RTTjmVj0ESW//2 K9OQ== X-Gm-Message-State: APjAAAVhHJG5FtlbyhgpE3SDzVvk2h1yhSwoAsp9ezOkMRmjP8msjQEW 85AVgtV9kBJ7XXjOjIixVVM= X-Google-Smtp-Source: APXvYqzxDmr1SNxHY7hEO0gLriawaqCkKEHy1diUazv80cn7Rlpu7NS07uF3jOMW5Cvpe3h50gMNGA== X-Received: by 2002:a17:90a:e28a:: with SMTP id d10mr33668362pjz.102.1570451800916; Mon, 07 Oct 2019 05:36:40 -0700 (PDT) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id 26sm14949155pjg.21.2019.10.07.05.36.39 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 07 Oct 2019 05:36:40 -0700 (PDT) Subject: Re: [PATCH 2/3] watchdog: sam9x60_wdt: introduce sam9x60 watchdog timer driver To: Eugen.Hristev@microchip.com, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.or Cc: wim@linux-watchdog.org, robh+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com References: <1570001371-8174-1-git-send-email-eugen.hristev@microchip.com> <1570001371-8174-2-git-send-email-eugen.hristev@microchip.com> From: Guenter Roeck Message-ID: Date: Mon, 7 Oct 2019 05:36:38 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/7/19 12:58 AM, Eugen.Hristev@microchip.com wrote: [ ... ] > Hello Guenter, > > Thank you for the feedback. > After reviewing this, can you please guide me towards one of the > possible two directions: merge this driver with sama5d4_wdt , and have a > single driver with support for both hardware blocks; or, have this > driver separately , as in this patch series? > I noticed the similarities. I don't know if it makes sense to reconcile the two drivers; it seems to me the new chip uses the same basic core with enhancements. In general, I prefer a single driver, but only if the result doesn't end up being an if/else mess. Ultimately, it is really your call to make. Guenter