From: Sinan Kaya <okaya@kernel.org>
To: "Rafael J. Wysocki" <rafael@kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/3] ACPI / OSL: Allow PCI to be disabled
Date: Tue, 11 Dec 2018 16:57:32 -0500 [thread overview]
Message-ID: <a9c7cbe1-eef3-40ad-de62-8194df12ca20@kernel.org> (raw)
In-Reply-To: <CAJZ5v0ia+eotSZgjbitt7TAT0ECSmTAz1XJhS3Auz5w5Z61SZA@mail.gmail.com>
On 12/11/2018 4:46 PM, Rafael J. Wysocki wrote:
> On Tue, Dec 11, 2018 at 6:37 PM Sinan Kaya <okaya@kernel.org> wrote:
>>
>> On 12/11/2018 12:09 PM, Christoph Hellwig wrote:
>>> On Mon, Dec 10, 2018 at 06:13:14PM +0000, Sinan Kaya wrote:
>>>> Getting ready to allow PCI to be disabled with ACPI enabled. Stub
>>>> out calls that depend on PCI.
>>>
>>> I think you want to skip building at least all of hwpci.c if CONFIG_PCI
>>> is disabled. Or replace that whole stiking pile of crap with something
>>> resembling C code..
>>>
>>
>> I can give it a try but I'm under the impression that we don't touch
>> ACPICA code in general.
>>
>> Feel free to correct me.
>
> We don't as a rule, but depending on what the patch looks like, we
> might not follow the rule this time.
>
OK. Good to know. I'll take a stab at it.
> I wonder though what we do if some AML wants to access PCI config
> space via an opregion in there. Have you thought about that?
>
Return an error.
AFAIK, ACPI spec says that AML code running on non-existing op-regions to be
discarded last time I checked.
I know Linux is noisy about these.
I did boot QEMU without CONFIG_PCI. There was a bunch of ACPI errors reported
during boot as expected but boot succeeded. There was no hard lockup/failure.
next prev parent reply other threads:[~2018-12-11 21:57 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-10 18:13 [PATCH v3 1/3] ACPI: Allow PCI to be disabled for reboot Sinan Kaya
2018-12-10 18:13 ` Sinan Kaya
2018-12-10 18:13 ` [PATCH v3 2/3] ACPI / OSL: Allow PCI to be disabled Sinan Kaya
2018-12-10 18:13 ` Sinan Kaya
2018-12-11 10:07 ` Rafael J. Wysocki
2018-12-11 16:52 ` Sinan Kaya
2018-12-11 17:09 ` Christoph Hellwig
2018-12-11 17:37 ` Sinan Kaya
2018-12-11 21:46 ` Rafael J. Wysocki
2018-12-11 21:57 ` Sinan Kaya [this message]
2018-12-11 22:16 ` Rafael J. Wysocki
2018-12-11 22:22 ` Sinan Kaya
2018-12-11 22:51 ` Rafael J. Wysocki
2018-12-11 23:00 ` Sinan Kaya
2018-12-10 18:13 ` [PATCH v3 3/3] PCI/ACPI: Allow ACPI to be built without PCI support Sinan Kaya
2018-12-10 18:13 ` Sinan Kaya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9c7cbe1-eef3-40ad-de62-8194df12ca20@kernel.org \
--to=okaya@kernel.org \
--cc=hch@infradead.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.