From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932405AbeCLU3x (ORCPT ); Mon, 12 Mar 2018 16:29:53 -0400 Received: from mx1.riseup.net ([198.252.153.129]:39160 "EHLO mx1.riseup.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932171AbeCLU3s (ORCPT ); Mon, 12 Mar 2018 16:29:48 -0400 X-Riseup-User-ID: 436C82FFD56DEE7D36BB394846D51915FFB02F82C32C62C451DFAFBD46CF5210 Subject: Re: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver To: paul.kocialkowski@bootlin.com Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, Icenowy Zheng , Florent Revest , Alexandre Courbot , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Maxime Ripard , Thomas van Kleef , "Signed-off-by : Bob Ham" , Thomas Petazzoni , Chen-Yu Tsai References: <20180309100933.15922-3-paul.kocialkowski@bootlin.com> <20180309101445.16190-3-paul.kocialkowski@bootlin.com> From: =?UTF-8?Q?Joonas_Kylm=c3=a4l=c3=a4?= Message-ID: Date: Mon, 12 Mar 2018 20:29:00 +0000 MIME-Version: 1.0 In-Reply-To: <20180309101445.16190-3-paul.kocialkowski@bootlin.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Paul Kocialkowski: > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > new file mode 100644 > index 000000000000..88624035e0e3 > --- /dev/null > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > @@ -0,0 +1,313 @@ > +/* > + * Sunxi Cedrus codec driver > + * > + * Copyright (C) 2016 Florent Revest > + * Florent Revest > + * > + * Based on vim2m > + * > + * Copyright (c) 2009-2010 Samsung Electronics Co., Ltd. > + * Pawel Osciak, > + * Marek Szyprowski, > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include "sunxi_cedrus_common.h" > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I think that the definitions #include #include #include #include #include #include are not used directly in the sunxi_cedrus.c file. Therefore they should be removed. Joonas From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Joonas_Kylm=c3=a4l=c3=a4?= Subject: Re: [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver Date: Mon, 12 Mar 2018 20:29:00 +0000 Message-ID: References: <20180309100933.15922-3-paul.kocialkowski@bootlin.com> <20180309101445.16190-3-paul.kocialkowski@bootlin.com> Reply-To: joonas.kylmala-X3B1VOXEql0@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20180309101445.16190-3-paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org> Content-Language: en-US List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: paul.kocialkowski-LDxbnhwyfcJBDgjK7y7TUQ@public.gmane.org Cc: linux-media-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, Icenowy Zheng , Florent Revest , Alexandre Courbot , Hans Verkuil , Laurent Pinchart , Sakari Ailus , Maxime Ripard , Thomas van Kleef , "Signed-off-by : Bob Ham" , Thomas Petazzoni , Chen-Yu Tsai List-Id: devicetree@vger.kernel.org Paul Kocialkowski: > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > new file mode 100644 > index 000000000000..88624035e0e3 > --- /dev/null > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > @@ -0,0 +1,313 @@ > +/* > + * Sunxi Cedrus codec driver > + * > + * Copyright (C) 2016 Florent Revest > + * Florent Revest > + * > + * Based on vim2m > + * > + * Copyright (c) 2009-2010 Samsung Electronics Co., Ltd. > + * Pawel Osciak, > + * Marek Szyprowski, > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include "sunxi_cedrus_common.h" > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I think that the definitions #include #include #include #include #include #include are not used directly in the sunxi_cedrus.c file. Therefore they should be removed. Joonas From mboxrd@z Thu Jan 1 00:00:00 1970 From: joonas.kylmala@iki.fi (=?UTF-8?Q?Joonas_Kylm=c3=a4l=c3=a4?=) Date: Mon, 12 Mar 2018 20:29:00 +0000 Subject: [linux-sunxi] [PATCH 5/9] media: platform: Add Sunxi Cedrus decoder driver In-Reply-To: <20180309101445.16190-3-paul.kocialkowski@bootlin.com> References: <20180309100933.15922-3-paul.kocialkowski@bootlin.com> <20180309101445.16190-3-paul.kocialkowski@bootlin.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Paul Kocialkowski: > diff --git a/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > new file mode 100644 > index 000000000000..88624035e0e3 > --- /dev/null > +++ b/drivers/media/platform/sunxi-cedrus/sunxi_cedrus.c > @@ -0,0 +1,313 @@ > +/* > + * Sunxi Cedrus codec driver > + * > + * Copyright (C) 2016 Florent Revest > + * Florent Revest > + * > + * Based on vim2m > + * > + * Copyright (c) 2009-2010 Samsung Electronics Co., Ltd. > + * Pawel Osciak, > + * Marek Szyprowski, > + * > + * This software is licensed under the terms of the GNU General Public > + * License version 2, as published by the Free Software Foundation, and > + * may be copied, distributed, and modified under those terms. > + * > + * This program is distributed in the hope that it will be useful, > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > + * GNU General Public License for more details. > + */ > + > +#include "sunxi_cedrus_common.h" > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include I think that the definitions #include #include #include #include #include #include are not used directly in the sunxi_cedrus.c file. Therefore they should be removed. Joonas