From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760013AbcKCSup (ORCPT ); Thu, 3 Nov 2016 14:50:45 -0400 Received: from smtprelay4.synopsys.com ([198.182.47.9]:36889 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758097AbcKCSuo (ORCPT ); Thu, 3 Nov 2016 14:50:44 -0400 Subject: Re: [PATCH 9/9] clocksource: import ARC timer driver To: Daniel Lezcano References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-10-git-send-email-vgupta@synopsys.com> <20161101204257.GG1506@mai> <188a2912-3369-19a3-86af-cbb154ff7e44@synopsys.com> <20161103173317.GI1859@mai> CC: , , , Noam Camus , Newsgroups: gmane.linux.kernel,gmane.linux.kernel.arc From: Vineet Gupta Message-ID: Date: Thu, 3 Nov 2016 11:47:59 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20161103173317.GI1859@mai> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.10.161.44] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/03/2016 10:33 AM, Daniel Lezcano wrote: > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a simple > test in the init function: > > if (IS_DEFINED(CONFIG_SMP)) > return -EINVAL; > > So, you can inconditionaly compile in both RTC and GFRC, no ? That would be > cleaner and prevent a different kernel config. That's a very good idea. So now I envision CONFIG_ARC_TIMERS # legacy TIMER0 / TIMER1 CONFIG_ARC_64BIT_TIMERS # rtc, gfrc I need this distinction at the min to be able to select them from ARC Kconfig. -Vineet From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vineet.Gupta1@synopsys.com (Vineet Gupta) Date: Thu, 3 Nov 2016 11:47:59 -0700 Subject: [PATCH 9/9] clocksource: import ARC timer driver In-Reply-To: <20161103173317.GI1859@mai> References: <35bde193-8492-83e0-fb03-8385d8afd007@synopsys.com> <1477954096-770-1-git-send-email-vgupta@synopsys.com> <1477954096-770-10-git-send-email-vgupta@synopsys.com> <20161101204257.GG1506@mai> <188a2912-3369-19a3-86af-cbb154ff7e44@synopsys.com> <20161103173317.GI1859@mai> List-ID: Message-ID: To: linux-snps-arc@lists.infradead.org On 11/03/2016 10:33 AM, Daniel Lezcano wrote: > As now the clksrc-probe is correctly handling the errors, if the rtc and the > gfrc are both defined in the DT, you can fail to init the rtc one with a simple > test in the init function: > > if (IS_DEFINED(CONFIG_SMP)) > return -EINVAL; > > So, you can inconditionaly compile in both RTC and GFRC, no ? That would be > cleaner and prevent a different kernel config. That's a very good idea. So now I envision CONFIG_ARC_TIMERS # legacy TIMER0 / TIMER1 CONFIG_ARC_64BIT_TIMERS # rtc, gfrc I need this distinction at the min to be able to select them from ARC Kconfig. -Vineet