From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH 01/16] libmultipath: make vector_foreach_slot_backwards work as expected Date: Wed, 14 Aug 2019 21:35:22 +0000 Message-ID: References: <1564763622-31752-1-git-send-email-bmarzins@redhat.com> <1564763622-31752-2-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1564763622-31752-2-git-send-email-bmarzins@redhat.com> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: "bmarzins@redhat.com" , "christophe.varoqui@opensvc.com" Cc: "dm-devel@redhat.com" , "mkumar@redhat.com" List-Id: dm-devel.ids On Fri, 2019-08-02 at 11:33 -0500, Benjamin Marzinski wrote: > All of the code that uses vector_foreach_slot_backwards() treats "i" > as > the index of the entry "p", but the way it was coded, that wasn't the > case. "i" was the number of the entry counting from 1, not 0. > > Signed-off-by: Benjamin Marzinski Reviewed-by: Martin Wilck (once more :-)