From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79F64C2D0A3 for ; Fri, 6 Nov 2020 03:58:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECE3320756 for ; Fri, 6 Nov 2020 03:58:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SAA4dD3O" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725828AbgKFD6h (ORCPT ); Thu, 5 Nov 2020 22:58:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725815AbgKFD6h (ORCPT ); Thu, 5 Nov 2020 22:58:37 -0500 Received: from mail-pf1-x441.google.com (mail-pf1-x441.google.com [IPv6:2607:f8b0:4864:20::441]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9292BC0613CF; Thu, 5 Nov 2020 19:58:35 -0800 (PST) Received: by mail-pf1-x441.google.com with SMTP id z3so98094pfz.6; Thu, 05 Nov 2020 19:58:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=72WK5gdLfg+8RgepOagG7LllxF4BWHujAXVduDm7r+4=; b=SAA4dD3ObW/Kw83JMEzBKEwOFbgINDIl/QDPZnDGEzT9D1MQqtKgLblLF4gon3H6XI e/H8Ricdau5eNPtdBuEZyLdbIfCSXJjcSAWRo8jJmqQl+3eXGlwTZo4pYUf9PdZrtrs8 tnvl6bGch2awvWymlM8d51ZMaRs7dPKya07HVre4kb3BietyhriyNTMJvQZpo3R8UH0i +g9Iya/Ua6NJVu5TjXNMXfcSG9CeecnHaE3kKdh/uiWJY1t3hz90Nj+eykhP0viAv/xI 6vrbAhd8qt3cREWgij3AXggvFfOxzl2/w7DEtDcbAR48QMxndi9m47EtNWM5usiAwmRx 74RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=72WK5gdLfg+8RgepOagG7LllxF4BWHujAXVduDm7r+4=; b=EZEjMZPuNUSBbM2K3o9B936FL/iwpdFktli0GhjJvXqMCllRv9EBPAIfXq8kCElKUO QjXtCtN6beAFzfMpR5YbfTKi246dAl1BPREkZDhICdnSzjFmOUM7fKUtElEhh7PzitVw JXdZaZcnmzXP5H0DDtNDd1LZ4zcIwUpxXJUkhl2p7qIdn2C1RupoxJJGrkvMxHjWG00w jtwQ/Aa7OEwH34F0/T3mF5krX5D0vKKywGPGaHzwkeYz6hv8N7BZBiv8PzMiRY8RNIX0 EIgQmZjJQi8q9lXMY77K4FYlhV1jAeRYx+nNIfE8fQx76c5SjfqkLZJ8SR+YJsYiZNWJ 98ow== X-Gm-Message-State: AOAM533yzzLM7BWDwCDXqnTIBf0bhrnNSiHmtHEZOBDlFoXbbvwZjRAO 7DgVBMz85nsoFHkxGZF12AE= X-Google-Smtp-Source: ABdhPJw197tx4uU6/FgGT5umqJUIokir+xifWVT5zLhPEW3lgXFo7oLNXg+7DZ0uhJVTM6h7GHjN6w== X-Received: by 2002:a63:4006:: with SMTP id n6mr42376pga.171.1604635114907; Thu, 05 Nov 2020 19:58:34 -0800 (PST) Received: from [10.230.1.248] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id s6sm129495pfh.9.2020.11.05.19.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2020 19:58:33 -0800 (PST) To: Prasad Sodagudi , rostedt@goodmis.org, mingo@redhat.com, keescook@chromium.org, catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org, will@kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, gregkh@linuxfoundation.org, anton@enomsg.org, arnd@arndb.de, ccross@android.com, jbaron@akamai.com, jim.cromie@gmail.com, joe@perches.com, joel@joelfernandes.org References: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org> From: Florian Fainelli Subject: Re: [PATCH 2] Register read and writes tracing Message-ID: Date: Thu, 5 Nov 2020 19:58:31 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 11/5/2020 6:56 PM, Prasad Sodagudi wrote: > This patch series adds register read/write event tracing > support. Qualcomm team tried upstreaming the register > trace buffer solution - [1] with pstore and dynamic debug > feature but that patch series didn't merge. I have followed > Steve suggestion from -[2] and used tracepoint_enabled() API. > > [1] - https://patchwork.kernel.org/project/linux-arm-msm/cover/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/ > [2] - https://lore.kernel.org/lkml/20200928105501.7e29df65@oasis.local.home/ > > Qualcomm teams uses these logs for debugging various issues > in the product life cycle and hopping that this logging > would help other silicon vendors as this is generic approach. There is not anything arm64 specific here other than where you have hooked into the low-level I/O accessors, you could consider adding this as a generic facility to other architectures as well. Also, have you looked at making mmiotrace less x86 specific and more generic? -- Florian From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 875E6C4741F for ; Fri, 6 Nov 2020 04:00:02 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01107206F7 for ; Fri, 6 Nov 2020 04:00:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="dxD6VKsX"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="SAA4dD3O" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01107206F7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:Subject: From:References:To:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lMFrfCHwKvz0pP6kLIo91TtKCDgZ1muqKMBmhVzdTw0=; b=dxD6VKsX0by6ZvumDbzmLG81b f6uiQ5x4rBPqKJ++Go8kAmfnx4pChyAw+Pcklvi1q+kADDPf8onk5HTscdvvhVc0UOGbFoUfLf1f4 J7uu1XVxn5Fw16QHx785FwMzOt2m1OJSa2nMeGKePk9FehEdVOHEElSxBdDcx8hiXxQQ6Vmjh7v+z 31XqqnsrY7gctpAt/QMNL9rbM73Wmm08/uHytT8T20EBHsjvwwjdRY/dhYxV9NNxuoGmZlqAahg1o VKkYddoy+yM87ww8WF57r4FGJiHx54D6JkJay+8/EbRDKGJt9oZ1ya8dra8sqLT37DeVVv07vftfp jIlDuxnlg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kastc-00005E-Kn; Fri, 06 Nov 2020 03:58:40 +0000 Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kasta-0008WH-Ot for linux-arm-kernel@lists.infradead.org; Fri, 06 Nov 2020 03:58:39 +0000 Received: by mail-pg1-x544.google.com with SMTP id w4so2904453pgg.13 for ; Thu, 05 Nov 2020 19:58:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:cc:references:from:subject:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=72WK5gdLfg+8RgepOagG7LllxF4BWHujAXVduDm7r+4=; b=SAA4dD3ObW/Kw83JMEzBKEwOFbgINDIl/QDPZnDGEzT9D1MQqtKgLblLF4gon3H6XI e/H8Ricdau5eNPtdBuEZyLdbIfCSXJjcSAWRo8jJmqQl+3eXGlwTZo4pYUf9PdZrtrs8 tnvl6bGch2awvWymlM8d51ZMaRs7dPKya07HVre4kb3BietyhriyNTMJvQZpo3R8UH0i +g9Iya/Ua6NJVu5TjXNMXfcSG9CeecnHaE3kKdh/uiWJY1t3hz90Nj+eykhP0viAv/xI 6vrbAhd8qt3cREWgij3AXggvFfOxzl2/w7DEtDcbAR48QMxndi9m47EtNWM5usiAwmRx 74RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:subject:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=72WK5gdLfg+8RgepOagG7LllxF4BWHujAXVduDm7r+4=; b=JUlThmNEzQEreYe+YVOE1k32PZHH8IMqIsCpY/KE27fVRR1VBZu0kyaT2JhkE9DgRE o8fn5DPCUhpKfG0RhvQtrlESLDFnHbJOMZtY3ySUseYXmCgVJ2v5vWFCfau5WyOJ0xlU 3j6d/3Lko/TpEqC0Ih1nJ6HePQhz948eK96Q+XjDgKkN9y92xPmvIVNggWXmICcH2isf xGpDTOER+LF6ylR6vBDyVm9v+ipDShqfN/9n7AbGnHO0EAMR6fVYIOTectqh5IfeD60x Av1xKZ8RksIKozY25wsiSDuYE5af78zVhk+ZC4Td2ZWPM3ycxrcQXNIr9q+w7MXF8RAn aPTw== X-Gm-Message-State: AOAM5324AkyfCQKUqKapq45A/6HhKZgalcpeEQr85ZU+vXJotE/ZC+nA O/JWQ0c23OHrOWLoaq9e11U= X-Google-Smtp-Source: ABdhPJw197tx4uU6/FgGT5umqJUIokir+xifWVT5zLhPEW3lgXFo7oLNXg+7DZ0uhJVTM6h7GHjN6w== X-Received: by 2002:a63:4006:: with SMTP id n6mr42376pga.171.1604635114907; Thu, 05 Nov 2020 19:58:34 -0800 (PST) Received: from [10.230.1.248] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id s6sm129495pfh.9.2020.11.05.19.58.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 05 Nov 2020 19:58:33 -0800 (PST) To: Prasad Sodagudi , rostedt@goodmis.org, mingo@redhat.com, keescook@chromium.org, catalin.marinas@arm.com, saiprakash.ranjan@codeaurora.org, will@kernel.org References: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org> From: Florian Fainelli Subject: Re: [PATCH 2] Register read and writes tracing Message-ID: Date: Thu, 5 Nov 2020 19:58:31 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: <1604631386-178312-1-git-send-email-psodagud@codeaurora.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201105_225838_823782_0DD6589A X-CRM114-Status: GOOD ( 12.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: arnd@arndb.de, jim.cromie@gmail.com, linux-arm-msm@vger.kernel.org, anton@enomsg.org, linux-kernel@vger.kernel.org, joel@joelfernandes.org, jbaron@akamai.com, ccross@android.com, gregkh@linuxfoundation.org, joe@perches.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11/5/2020 6:56 PM, Prasad Sodagudi wrote: > This patch series adds register read/write event tracing > support. Qualcomm team tried upstreaming the register > trace buffer solution - [1] with pstore and dynamic debug > feature but that patch series didn't merge. I have followed > Steve suggestion from -[2] and used tracepoint_enabled() API. > > [1] - https://patchwork.kernel.org/project/linux-arm-msm/cover/cover.1536430404.git.saiprakash.ranjan@codeaurora.org/ > [2] - https://lore.kernel.org/lkml/20200928105501.7e29df65@oasis.local.home/ > > Qualcomm teams uses these logs for debugging various issues > in the product life cycle and hopping that this logging > would help other silicon vendors as this is generic approach. There is not anything arm64 specific here other than where you have hooked into the low-level I/O accessors, you could consider adding this as a generic facility to other architectures as well. Also, have you looked at making mmiotrace less x86 specific and more generic? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel