[U-Boot] [PATCH 3/8] video/console: Implement relative cursor movement ANSI handling

From: "André Przywara" <andre.przywara@arm.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/8] video/console: Implement relative cursor movement ANSI handling
Date: Sat, 13 Apr 2019 22:40:03 +0100	[thread overview]
Message-ID: <a9de80f1-bb70-5a54-5769-79b3a7dfc025@arm.com> (raw)
In-Reply-To: <20190411140933.29a6b8c5@crub>

On 11/04/2019 13:09, Anatolij Gustschin wrote:

Hi Anatolij,

thanks for the heads up!

> On Tue, 9 Apr 2019 23:05:11 +0200
> Anatolij Gustschin agust at denx.de wrote:
> ...
>>>  drivers/video/vidconsole-uclass.c | 37 +++++++++++++++++++++++++++++++++++++
>>>  1 file changed, 37 insertions(+)  
>>
>> Applied to u-boot-video/master, thanks!
> 
> I've dropped all applied patches of this series now, some of them
> introduced dm video_ansi test error [1]. Please fix. Thanks!

Hmh, good one. Didn't find an easy way to get to the bottom of this
within the ut test system, so I copied the ANSI sequences out and
replayed them with a custom command, inspecting the (sandbox) screen
manually. Is there a canonical way to trace down those issues?

Anyway, the fix for patch 2/8 is rather simple (see below), do you want
to fix this up in your tree? Or shall I sent a v2?
The head of my tree passes the video_ansi test now.

(This patch won't apply cleanly (blame Thunderbird), but I think you get
the idea...)

--- a/drivers/video/vidconsole-uclass.c
+++ b/drivers/video/vidconsole-uclass.c
@@ -464,7 +464,7 @@ static void vidconsole_escape_char(struct udevice
*dev, char ch)
 			break;
 		case 40 ... 47:
-			/* background color */
-			vid_priv->bg_col_idx &= ~7;
+			/* background color, also mask the bold bit */
+			vid_priv->bg_col_idx &= ~0xf;
 			vid_priv->bg_col_idx |= val - 40;
 			vid_priv->colour_bg = vid_console_color(
 					vid_priv, vid_priv->bg_col_idx);

Cheers,
Andre.
