All of lore.kernel.org
 help / color / mirror / Atom feed
* Multiple-line parsing of packets dissected over HTTP
@ 2021-01-19  4:07 Joey Salazar
       [not found] ` <CAGka-81Ze71igsW2zsfzYqqkr+sz5FE6YYo3mEpdEQUSUxZvaw@mail.gmail.com>
  0 siblings, 1 reply; 3+ messages in thread
From: Joey Salazar @ 2021-01-19  4:07 UTC (permalink / raw)
  To: Emily Shaffer, Jonathan Nieder; +Cc: git, Developer support list for Wireshark

Hi all,

In commit 33af2649 [1] we can keep dissecting the contents of the req, adv, and res packets by setting
 while (plen > 0) { }
either in `dissect_git_pdu()` or in `dissect_one_pkt_line()`, but for now in `dissect_git_pdu()` it'd be a bit messy, so wanted to ask for your feedback for getting `dissect_one_pkt_line()` to work properly first.

As you can see in pcap 169 [2], it correctly parses the length of the first line as 0x0014 (20 bytes) until `0x0a`, then it's supposed to get the length of the next line by the first 4 hex bytes in that line, but instead of reading the length as 0x0018 (24 bytes) it's reading it as 0x0010 (16 bytes), and anyways, this particular line's length actually is 59 bytes.

Suggestions on how to approach this?

Thank you all,
Joey

[1] gitlab.com/joeysal/wireshark/-/commit/33af2649927cb5660d4aeb64b9a9e9a58a1823aa
[2] www.imgur.com/a/91GMo6U

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-01-21  0:26 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-19  4:07 Multiple-line parsing of packets dissected over HTTP Joey Salazar
     [not found] ` <CAGka-81Ze71igsW2zsfzYqqkr+sz5FE6YYo3mEpdEQUSUxZvaw@mail.gmail.com>
2021-01-20  0:09   ` [Wireshark-dev] " Jonathan Nieder
2021-01-20 23:17     ` Joey Salazar

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.