All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stefan Wahren <wahrenst@gmx.net>
To: Florian Fainelli <f.fainelli@gmail.com>, Lukas Wunner <lukas@wunner.de>
Cc: Scott Branden <sbranden@broadcom.com>,
	Ray Jui <rjui@broadcom.com>,
	bcm-kernel-feedback-list@broadcom.com,
	linux-arm-kernel@lists.infradead.org,
	Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
	linux-rpi-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: dts: bcm283x: Fix critical trip point
Date: Mon, 9 Dec 2019 20:31:36 +0100	[thread overview]
Message-ID: <aa08117e-b6d5-fcdb-8d01-28810f56e210@gmx.net> (raw)
In-Reply-To: <899ae14b-28d0-0982-cbdf-baf4f1e978fe@gmail.com>

Am 09.12.19 um 19:17 schrieb Florian Fainelli:
> On 11/30/19 5:54 AM, Lukas Wunner wrote:
>> On Sat, Nov 30, 2019 at 01:31:13PM +0100, Stefan Wahren wrote:
>>> During definition of the CPU thermal zone of BCM283x SoC family there was
>>> a misunderstanding of the meaning "criticial trip point" and the thermal
>>> throttling range of the VideoCore firmware. The latter one takes effect
>>> when the core temperature is between 80 and 85 degree celsius. So the
>>> current critical trip point doesn't make sense, because the
>>> thermal shutdown appears before the firmware has a chance to throttle the
>>> ARM core(s).
>> FWIW, the thermal throttling range goes way above 85°C.
>>
>> At Kunbus we've performed numerous tests in a climate chamber
>> and my recollection is that a CM3 starts throttling above 80°C
>> with the frequency hovering between 600 and 1200 MHz.
>>
>> Once 85°C is reached, the frequency is fixed at 600 MHz.
>>
>> But there a additional tripping points above that when the frequency
>> gets further reduced to 400 MHz and later 300 MHz.
> Does that mean that you are okay with 90°C here, or would you rather see
> this be change to 85°C?

From my understanding the change is okay, but the wording in the patch
description is misleading.

Suggestion:

... The latter one takes effect when the core temperature is at least 85
degree celsius or higher.


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-12-09 19:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-30 12:31 [PATCH] ARM: dts: bcm283x: Fix critical trip point Stefan Wahren
     [not found] ` <20191130135403.jmuuuy3lf5l3enti@wunner.de>
2019-12-09 18:17   ` Florian Fainelli
2019-12-09 19:31     ` Stefan Wahren [this message]
2019-12-10 20:37       ` Florian Fainelli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa08117e-b6d5-fcdb-8d01-28810f56e210@gmx.net \
    --to=wahrenst@gmx.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lukas@wunner.de \
    --cc=nsaenzjulienne@suse.de \
    --cc=rjui@broadcom.com \
    --cc=sbranden@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.