From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 080A1C4708F for ; Tue, 1 Jun 2021 20:28:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3E4A613BD for ; Tue, 1 Jun 2021 20:28:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B3E4A613BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:38190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1loAzs-0007IJ-O4 for qemu-devel@archiver.kernel.org; Tue, 01 Jun 2021 16:28:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1loAz1-0005gF-6L for qemu-devel@nongnu.org; Tue, 01 Jun 2021 16:27:27 -0400 Received: from mail-pf1-x42c.google.com ([2607:f8b0:4864:20::42c]:37481) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1loAyz-0002Im-9X for qemu-devel@nongnu.org; Tue, 01 Jun 2021 16:27:26 -0400 Received: by mail-pf1-x42c.google.com with SMTP id y15so414223pfl.4 for ; Tue, 01 Jun 2021 13:27:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=FZ31macvvAU7ox/dsVC1HJDzINgo8q6nZ82L1RujB90=; b=tbhSWs0NZFD0VvAKqZyJBVKzFQjajBQXRkNZXaS29MHhkyJWd7sSXV2dG3ka9HS5qC Erx0RG86HZh2M50lDrbGlT58sjTLxF7S5MN4uGK65P/TxzD2AlES5zsyEPaU9pGiARX+ CbxvvO8jSq3u4TyIblqxbW8hucJHVxFjJiMDrpp7kGIWn1uadFpYX7QQlL+PN/08lr3Q 5WbwVAbJI1Era/4afcRwEzMcqJxXqR48d9iifPGjDOHrrMXR69BoeaBQenvlh5P8tZPJ M72IyKtmh3NEZY41czUGfxHSX1g4serDNwzLW/M8zLSkqXT9XyTgnzvZLfC5ea1ceoYI Cykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=FZ31macvvAU7ox/dsVC1HJDzINgo8q6nZ82L1RujB90=; b=ppbOJyLIiYvRfHTj1gtIzGOJfULNjAqhGFdKHnyxShjXB3bDbikTvwh5IBgajo4odR /Ag2mrC710xGfKQ3IfgSDUVNKP4Q61Mf7MiJHYEuFq9OSHTCmyL/eAYbYHR/MujZ0yOi s9brWazWEVImeKaw+9+2+C/lFmySqTQ1mQ7y4acN85Ozb+rvSD8CVOnK7DH79LNc0CBd EEY3ibQB3oPjVpP4AZu6IkFE7j9xulZXYzSphsQmAmJ6SQJGOQi5yBlifT1Eih7g5CzK G05M1TL9nU39sWx2n3cqBAZ7gkP6zJmR9JQ2Zs+kbXSJ4yK0/VOTmiICf3I9x7cMldng Zu+g== X-Gm-Message-State: AOAM530QokycamZC34IsyfWljYg/oQquQBeJNR/lK95lRAIh3cmPNEQq o8tbKINMUG/K1uSxosA3ZmgOMA== X-Google-Smtp-Source: ABdhPJyt23U1eqxw8sH90S49YLYG4J1fltYTKF2MsmfFxggYUZrhwzsTvCUT9YxGnyIGpmb7wVQxog== X-Received: by 2002:aa7:8426:0:b029:2e9:bc0e:5c3f with SMTP id q6-20020aa784260000b02902e9bc0e5c3fmr15769251pfn.22.1622579243590; Tue, 01 Jun 2021 13:27:23 -0700 (PDT) Received: from [192.168.1.11] (174-21-70-228.tukw.qwest.net. [174.21.70.228]) by smtp.gmail.com with ESMTPSA id u12sm13796459pfm.2.2021.06.01.13.27.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 13:27:23 -0700 (PDT) Subject: Re: [PATCH] target/ppc: fix single-step exception regression To: Luis Pires , qemu-devel@nongnu.org References: <20210601180237.296402-1-luis.pires@eldorado.org.br> From: Richard Henderson Message-ID: Date: Tue, 1 Jun 2021 13:27:20 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210601180237.296402-1-luis.pires@eldorado.org.br> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::42c; envelope-from=richard.henderson@linaro.org; helo=mail-pf1-x42c.google.com X-Spam_score_int: -26 X-Spam_score: -2.7 X-Spam_bar: -- X-Spam_report: (-2.7 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.613, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: matheus.ferst@eldorado.org.br, qemu-ppc@nongnu.org, groug@kaod.org, david@gibson.dropbear.id.au Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/1/21 11:02 AM, Luis Pires wrote: > + if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) { > + /* We have not updated nip yet, so do it now */ > + gen_update_nip(ctx, nip); > + } This is incorrect. Both EXIT and CHAIN *have* updated nip, but to something that isn't the next instruction. E.g. return from interrupt. r~