Re: [PATCH v3 0/6] block: add a sequence number to disks

From: Luca Boccassi <bluca@debian.org>
To: Hannes Reinecke <hare@suse.de>,
	Matteo Croce <mcroce@linux.microsoft.com>,
	linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	Jens Axboe <axboe@kernel.dk>
Cc: linux-kernel@vger.kernel.org,
	"Lennart Poettering" <lennart@poettering.net>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Damien Le Moal" <damien.lemoal@wdc.com>,
	"Tejun Heo" <tj@kernel.org>,
	"Javier González" <javier@javigon.com>,
	"Niklas Cassel" <niklas.cassel@wdc.com>,
	"Johannes Thumshirn" <johannes.thumshirn@wdc.com>,
	"Matthew Wilcox" <willy@infradead.org>,
	"Christoph Hellwig" <hch@infradead.org>,
	JeffleXu <jefflexu@linux.alibaba.com>
Subject: Re: [PATCH v3 0/6] block: add a sequence number to disks
Date: Wed, 23 Jun 2021 13:46:48 +0100	[thread overview]
Message-ID: <aa0ed29d1d15d06fc125bee1af0c40425bd5c6f4.camel@debian.org> (raw)
In-Reply-To: <bfdd6f56-ce2b-ef74-27b1-83b922e5f7d9@suse.de>

[-- Attachment #1: Type: text/plain, Size: 1698 bytes --]

On Wed, 2021-06-23 at 14:03 +0200, Hannes Reinecke wrote:
> On 6/23/21 12:58 PM, Matteo Croce wrote:
> > From: Matteo Croce <mcroce@microsoft.com>
> > 
> > With this series a monotonically increasing number is added to disks,
> > precisely in the genhd struct, and it's exported in sysfs and uevent.
> > 
> > This helps the userspace correlate events for devices that reuse the
> > same device, like loop.
> > 
> I'm failing to see the point here.
> Apparently you are assuming that there is a userspace tool tracking 
> events, and has a need to correlate events related to different 
> instances of the disk.
> But if you have an userspace application tracking events, why can't the 
> same application track the 'add' and 'remove' events to track the 
> lifetime of the devices, and implement its own numbering based on that?
> 
> Why do we need to burden the kernel with this?
> 
> Cheers,
> 
> Hannes

Hi,

It is not an assumption, such tool does exist, and manually tracking
does not work because of the impossibility of reliably correlating
events to devices (we've tried, again and again and again), which is
the purpose of this series - to solve this long standing issue, which
has been causing problems both in testing and production for a long
time now, despite our best efforts to add workaround after workaround.

For more info please see the discussion on the v1:

https://lore.kernel.org/linux-fsdevel/20210315201331.GA2577561@casper.infradead.org/t/#m5b03e48013de14b4a080c90afdc4a8b8c94c30d4

and the bug linked in the cover letter:

https://github.com/systemd/systemd/issues/17469#issuecomment-762919781

-- 
Kind regards,
Luca Boccassi

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]