From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbdDLBkf (ORCPT ); Tue, 11 Apr 2017 21:40:35 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:43994 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751608AbdDLBkd (ORCPT ); Tue, 11 Apr 2017 21:40:33 -0400 Subject: Re: [PATCH 4.9 000/152] 4.9.22-stable review To: Tony Lindgren , Greg Kroah-Hartman References: <20170410164159.934755016@linuxfoundation.org> <38bcb13d-1a22-3f52-21a6-c91f83631a72@roeck-us.net> <20170411044236.GB31847@kroah.com> <20170411151659.GH5339@atomide.com> Cc: linux-kernel@vger.kernel.org, Linus Torvalds , akpm@linux-foundation.org, shuahkh@osg.samsung.com, patches@kernelci.org, ben.hutchings@codethink.co.uk, stable@vger.kernel.org, Sean Young From: Guenter Roeck Message-ID: Date: Tue, 11 Apr 2017 18:40:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170411151659.GH5339@atomide.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2017 08:17 AM, Tony Lindgren wrote: > * Greg Kroah-Hartman [170410 21:45]: >> On Mon, Apr 10, 2017 at 08:07:17PM -0700, Guenter Roeck wrote: >>> The arm builds fail as follows. >>> >>> Building arm:overo:omap2plus_defconfig:omap3-overo-tobi ... failed >>> ------------ >>> Error log: >>> In file included from arch/arm/mach-omap2/pdata-quirks.c:15:0: >>> arch/arm/mach-omap2/pdata-quirks.c:537:49: error: 'rx51_ir_data' undeclared here (not in a function) >>> OF_DEV_AUXDATA("nokia,n900-ir", 0, "n900-ir", &rx51_ir_data), >>> ^ >>> ./include/linux/of_platform.h:52:21: note: in definition of macro 'OF_DEV_AUXDATA' >>> .platform_data = _pdata } >>> ^ >>> make[1]: *** [arch/arm/mach-omap2/pdata-quirks.o] Error 1 >>> >>> I am a bit lost here. Reverting >>> >>> f2ea7a5c3730 rx51: broken build >>> >>> fixes the problem, but is supposed to accomplish the opposite. You'll need to drop >>> that patch, or maybe even better drop > > Just trying to understand what's going on.. OK so dropping the patch > above makes sense. It seems there's some other dependency not mentioned > there. > >>> 375a81645446 ARM: OMAP2+: Fix init for multiple quirks for the same SoC >>> >>> as well and let the authors [copied] sort this out. > > Guenter, what's your reasoning to also drop this one? I don't quite see > the connection between these two patches? > Somehow I thought they are related, but right now I have no idea why I thought that. Maybe I didn't have enough coffee :-(. Guenter