From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DDE97C11F64 for ; Tue, 29 Jun 2021 02:27:50 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3187A61CEF for ; Tue, 29 Jun 2021 02:27:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3187A61CEF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oss.nxp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6B34582E85; Tue, 29 Jun 2021 04:27:48 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=NXP1.onmicrosoft.com header.i=@NXP1.onmicrosoft.com header.b="UKTixiNv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id F29E182EA6; Tue, 29 Jun 2021 04:27:46 +0200 (CEST) Received: from EUR01-HE1-obe.outbound.protection.outlook.com (mail-he1eur01on0611.outbound.protection.outlook.com [IPv6:2a01:111:f400:fe1e::611]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 4653882E85 for ; Tue, 29 Jun 2021 04:27:39 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=oss.nxp.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=peng.fan@oss.nxp.com ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=l1U+wQThZZa+iP6MbWMO5hnE5b+n+o78dOJSPUCbsbFYgdRCgTsrV07vPvuSrBeSQXG5mWUKbXgrRa3ARvBDdFjyDTh0qFLeeUXPjAz0oQna6YgjU8ynuF54QzvMPkCuET0UFTB2o6V7y7RfINK0dVMyN1rxaIGwL6DzFsx5FPXPwE8Ad6MjlaF+P/rmsr32VzpANBEv6U5/xyyme5zv0dOEnbP7N19ZrPJrOEzkI87OvTgbYcjglQH785MYz8ibFYS9+LkIz0uNBI966R48aAW8G6VdJjSSduEgenbIvuDxFIqJ23hdtTAU9oMP/MVnUawpcoBwCb36AfOP+IO7ig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GK5+scg7eCZ5t09aUruTKJXTfCkPPzcdyH0StKqCotQ=; b=B88GunSJjWGzF40Mt8QmfWZBbVC1QTdyYl28zvSe9NGoK8eICQtdpQTTk7kmRH4/Yh0bisgNeIjG6wzB7foPQ8Pt17x7+Swpv4AJmSB40NmYjJh1MYyCSSQBfGg+QIC9lE3gju31LJH3jhio8tqgtNQfJWv++uvAOpgZlugkJOm145zBnboks6k0bZZ02AwgDE0/n0kb8iB0rZqVFTqhTY3Cg/tUgGd3AheA7RTAKSfQqxNn8mLEOErcRAmSaU9ebx5A1jfgjsj6yfsApnhgQ0cdqpfPYBzxiuH3Z2LITcMKp8oYLoZMA9neqAqBJwolvMCfc2RB5itFw3oROcBD4A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector2-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GK5+scg7eCZ5t09aUruTKJXTfCkPPzcdyH0StKqCotQ=; b=UKTixiNvAr96883meUI3c3hp1Q4mmYyayDJnCS90kimBf3TLCCfyHC9LqmoXwF92l+muiwfLN5JndfDpqKnZBQHDBI+IRu2W8TbAeo/Bff00u61/dr69QH8Hu5at7Xmeah2zz6H3F/dpISdVPGnrjZTrAnAsosaO9FzXy1J9o9I= Authentication-Results: amarulasolutions.com; dkim=none (message not signed) header.d=none;amarulasolutions.com; dmarc=none action=none header.from=oss.nxp.com; Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) by DB3PR0402MB3657.eurprd04.prod.outlook.com (2603:10a6:8:b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.20; Tue, 29 Jun 2021 02:27:37 +0000 Received: from DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::c445:d742:eb76:86dd]) by DB6PR0402MB2760.eurprd04.prod.outlook.com ([fe80::c445:d742:eb76:86dd%9]) with mapi id 15.20.4264.026; Tue, 29 Jun 2021 02:27:37 +0000 Subject: Re: [PATCH 03/12] Revert "usb: gadget: fastboot: use correct max packet size" To: Maxime Ripard , u-boot@lists.denx.de, Andre Przywara Cc: Peng Fan , Li Jun , Marek Vasut , Tom Rini , Miquel Raynal , Jagan Teki References: <20210625130547.2177920-1-maxime@cerno.tech> <20210625130547.2177920-4-maxime@cerno.tech> From: "Peng Fan (OSS)" Message-ID: Date: Tue, 29 Jun 2021 10:27:27 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.2 In-Reply-To: <20210625130547.2177920-4-maxime@cerno.tech> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [119.31.174.71] X-ClientProxiedBy: SG2PR01CA0173.apcprd01.prod.exchangelabs.com (2603:1096:4:28::29) To DB6PR0402MB2760.eurprd04.prod.outlook.com (2603:10a6:4:a1::14) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [10.193.102.59] (119.31.174.71) by SG2PR01CA0173.apcprd01.prod.exchangelabs.com (2603:1096:4:28::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4264.18 via Frontend Transport; Tue, 29 Jun 2021 02:27:34 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ca5bb511-1a29-4a4d-1c99-08d93aa575ea X-MS-TrafficTypeDiagnostic: DB3PR0402MB3657: X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:175; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: PtvhlXaBIhz15HO9w/db+TMZ5oXyko0Izpw7m6eyVOkF7lAkFyKfboeyYTY2+GMT3sXLVsB70wBYqUe9EQ2Da5SiWCucG6lvVk50fKxIWUE1QAMHNji/IuP2ExBIuwh3RGfjsYxdSN463b/qV+YyjhioSGy57tZZacp1aw0nkM2xCPqVTyAlj3HcqPrriv1CG2i3AQYUoUNjjQ/2qGaNHVh2aI3T7fS70WM8UClXeskjU3T1EiCg4pnW4PQJv4slfnDkL6NEukScR7AcqibUcixDSdpUgPi/tMJjwIEgLx16lRZqyW7ZXgr4Zs86DaLcQ5ITNM+aUUmfIr0SX4acRgnCKJhDe/j6+qO6oyVqKaRCNbQvZP+0JHg0pytSLXE7ORQgq91OqQHd2LtZqSj/Pelv/tCgY6BSUIey9Bn7b8cqaCUSpCIGZTjshMPoHqbqlKZaxa02PMjOw/3Iyy1ZQbu9lJnLUJ7S/rPsgGFqHKaLwPgVQJUur7zJPoJDtCSfhyWdH4k1vHk/QcPEcvtUOFEZamBYjuCF376AvJmAe1m7xW0LvA57FUTcyq4tQMDweAL3IST+PqIVyDMjQbdoDoPO1Wo+B9MMjj6KCmZ+T/e/YkRZhlfuYqyz1PbxzOSLa1X5MdSNghGBInnFxZQUfzytqFI072QK03lHtyC6TGfXQyuDbFQ58NtoT1Rvgpc+n0v3pDdQToFwat5cUgNjMfOkDTBisT9pd1djKeVh6sAtMza8AWUmv+a8/EBDD/M2 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB6PR0402MB2760.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(396003)(346002)(376002)(478600001)(26005)(83380400001)(53546011)(4744005)(38350700002)(6486002)(66946007)(66556008)(38100700002)(5660300002)(66476007)(2906002)(16526019)(8676002)(110136005)(52116002)(4326008)(31696002)(6666004)(956004)(186003)(8936002)(86362001)(316002)(2616005)(16576012)(54906003)(31686004)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?dDJ5Z1YwbFFmdXNRTzNsVldrSlZxSFJsWUNJZnZIc2R2S3d0WTVSQXpVZng4?= =?utf-8?B?MUwvWmhBTmVzekQ4azh3N2d4anJiYUFiOGxuZmxSL0E3ckdxQ1ZwTlJSYXJW?= =?utf-8?B?WVNUa050K2ZScXFaZStFcGRKNnI0RXl1SEs2MVJWNGI2Ulg1RGRMTXp1bmVW?= =?utf-8?B?bm1FM084bWhWTzhiK1VnWE41MXVhN2ptb3hJNEtUUmVaNTUxc0oxa0FTZWl4?= =?utf-8?B?ekRFS3Nrc1JMZnUrOU1ndmE1dkkyT24wL2k1VDBJN0JndCtlSFZCV0E0Nm1P?= =?utf-8?B?WnhJWmZPSWNrbnlZaG1MZTA1ZzY2WFR4N29SMnRMamR6bHJ2VEQ2c1JzRDl0?= =?utf-8?B?c0ZpMEZScXpjUStRSXFZMFl5ZWhJVVF5N0ROSGFGSGNkcXpOSm0ybnRFWnhE?= =?utf-8?B?dW9DY1BhREd4cEVTcld0RG14NkhZRkZkVXNrZjlyY3RkWWV1VXI5RFJYRkVq?= =?utf-8?B?dkM3bnlNOTdLN1N2T1VNeEtwT2tNVzhQaWZoUW5uT0NrendMWllNRGRHRC9V?= =?utf-8?B?QkRxOXFERjhMdWhibU9rOCt3OW9IaDlUMUQ2Q1A3aFVJQkpOcnZiNDJqdU1q?= =?utf-8?B?WFRVRzBoYmNFWFJtOVRHWUVsK0pWTElLSU1QLzlJSU96TjVIaDdKZFVId2NF?= =?utf-8?B?a2wwSFVsV1hsRUF3cU52RmtUSjhsd2g2SFI5bFNiOFRVeUIvQld0YThtT1RY?= =?utf-8?B?cHRnN1lick4yUHhSY2tvY3A5NVFxbFc1SGRrUUZUcjJoM0FSK250a0ZmRzJH?= =?utf-8?B?Yy9meEZXTEJTd2l6Y3ZBR2ZwcHE0dnVaQjBNZUcvdlZ0N2czMzU4TnI0SHQv?= =?utf-8?B?ZFBBTXB0Y0IveGpaUGZGVkRoWnY1QWE0dFlKLytLY0pVeWVUV2ZEWlZjOGps?= =?utf-8?B?L1hGVDJDV2VZMGdTVDZwVmpFdUpiOVlZbk5JRTFGUXRCdEIwdVNlWEx2VUZj?= =?utf-8?B?RWpwRW1MWGJ6TTdxMVZmTzkwbys0cFdmY253aFFZWStYNmVjZ2pBTzNaWFg5?= =?utf-8?B?MnJmODcwVnFiMElXaTEvN1luRFlxWnpjZ2QwYTA0OTlJNE0xRnFUS21zcklT?= =?utf-8?B?ZzVzRlpFdW5WZm0wZXNqeUVhN2dNL3lkdStFWmtGQndoQkovSEpHMzBjSC9O?= =?utf-8?B?QzZ2MUZicEV5K0cwdjY1bk9DbU95UVE5YkxlUm5uaHN0MWdJZGw5OXBXUUZh?= =?utf-8?B?WU8wRXgyNEd2TGxIQm02R0Y4N2tobkhBMG15Y1cyVEVtK1dxdjR6ZmlZZkJG?= =?utf-8?B?NWNVUHRJOVFPR2xLV3YreU90VWxtK29qMTNPR2R2NVpHSU9KcCs4Nk9OdjFr?= =?utf-8?B?emoxU1ZubnJibEtlRStRbUNvcTRseFBMd1VxNTlKT0pLTUJXUGVLblJiUEtv?= =?utf-8?B?RGJtNW9hdnFjdjN5aXlpaTVxNUtsTElYM2dEUFJ3K2RjVGxreERiSk1ibjIr?= =?utf-8?B?TWtMcmVETlA4bDVjNjdEZ0VCK2h2NitYUlhzTHlpamdlZnlUcEM5YXRvWTJI?= =?utf-8?B?dG9wTEJhS3Vwb0JVcWF1ZmxhZnlqUERRRmFxODkvWk56QzNTb2FiL0FoN2pR?= =?utf-8?B?RkRXdWt0SE5ucENpYm5KREswNFVPcXNPWEoyVzVMcWVvT3lkZ0Q1V0N0aFVo?= =?utf-8?B?NEx0RnZSZEJKWFlBUHNjQllKUWxldDRNSlVHMDNKcFpHcnM2V042UGVBeUsx?= =?utf-8?B?cG9jSTBnNWpwaE1CMVZJekhPWmZoZ3phb0dVbDdob0dzTjZSajBBbExET2k0?= =?utf-8?B?M3FjazJQZ0tNMWRRVi8zcE9RYXZyMWsxRU9vL1N5Y1Ara0VCVURSWXA4QmlF?= =?utf-8?B?bUdBMGRPRGJlSitIc2h4QT09?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: ca5bb511-1a29-4a4d-1c99-08d93aa575ea X-MS-Exchange-CrossTenant-AuthSource: DB6PR0402MB2760.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2021 02:27:37.4386 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y2qbTMqx37azvug38ug38eu8Bnvs+y7cWVVGmbnJZhuTEayaH8tUAJRu6JSKS5y9qxcS3Z3IfvNUcuBuYiL/Sw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB3PR0402MB3657 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Maxime On 2021/6/25 21:05, Maxime Ripard wrote: > This reverts commit 27c9141b1114fd5721437abbb1c694e45e765f19. > --- > drivers/usb/gadget/f_fastboot.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/f_fastboot.c b/drivers/usb/gadget/f_fastboot.c > index 8ba55aab9f8f..1fcffaf9dd26 100644 > --- a/drivers/usb/gadget/f_fastboot.c > +++ b/drivers/usb/gadget/f_fastboot.c > @@ -427,7 +427,7 @@ static unsigned int rx_bytes_expected(struct usb_ep *ep) > { > int rx_remain = fastboot_data_remaining(); > unsigned int rem; > - unsigned int maxpacket = usb_endpoint_maxp(ep->desc); > + unsigned int maxpacket = ep->maxpacket; Have you ever checked what's the value here of ep->maxpacket and usb_endpoint_maxp(ep->desc); in your failure case? Regards, Peng. > > if (rx_remain <= 0) > return 0; >