From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 216DEC432BE for ; Thu, 12 Aug 2021 03:23:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 057AF60EE2 for ; Thu, 12 Aug 2021 03:23:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233506AbhHLDXm (ORCPT ); Wed, 11 Aug 2021 23:23:42 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:51811 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbhHLDXk (ORCPT ); Wed, 11 Aug 2021 23:23:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628738596; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2m2roWrvbYZeRqtABbQ37PaOQOhXAkNprJbXopZhFmQ=; b=I1YRj/qgLA33z+HD0LRttf6Ln1A82T0C4frepbqrCbHrZAOP2XEQ/0Wt2y8wfnqFQmZ2fj 6kGtNSIOTDB+Mme377ZWNtvTWbyLCpybyqAzY+nqipIKWnlBRlr44i/q15vIlHI4PDksIA HmwfKXhqbp9gwRaj+VmbjZdd1/giOzM= Received: from mail-pj1-f70.google.com (mail-pj1-f70.google.com [209.85.216.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-152-S8u3SAPWNB262j0dKDV4_w-1; Wed, 11 Aug 2021 23:23:14 -0400 X-MC-Unique: S8u3SAPWNB262j0dKDV4_w-1 Received: by mail-pj1-f70.google.com with SMTP id r23-20020a17090aa097b0290176fc47a8b7so6948343pjp.6 for ; Wed, 11 Aug 2021 20:23:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2m2roWrvbYZeRqtABbQ37PaOQOhXAkNprJbXopZhFmQ=; b=rhl0usoP/nFHSxP7vKQG+nF3e550asobhmwtd4ZrD9fKZuY6mJPaCNolgpdEqwFQfw 5EynGdMzpKfk3lNZf5uxksfnvpdf5gd3zNQfelv3vXxgmJsj7XaAYF6O/oXnzDvHgO/A h6P9vJmSj+6vXfYeLmYQZORBRlpVGHP9fAilyac1bBbro13dn2L5ksJy5GUNob83f9Xt TVMW6eSHpfFVuqPqRNowqqbaNFKTqpxI/2kxA0uZDa6etNfx+21rKWgld2mJSowZ8orQ AWIPHjvFvNNtahZ/fdv+kSeqDBgF3TCafxADhsYkif1yH12gQ2gw8Ztq2MQRduupNS2n p60A== X-Gm-Message-State: AOAM532tADL1FV7O708ASNWuTtjvmdvWbM5jTM0p/Uil75di5ohyA199 wtX9cP3CjFR9/se0/6ZGmd7tbjPtFXow/GNMq8TAwGckAXvbSYWxGAn3Cv2SZHaeNoA4iS9Dy/c hsyqLzr4L3c4uM7a6dZWxYR/0 X-Received: by 2002:a63:4b20:: with SMTP id y32mr1859079pga.382.1628738593898; Wed, 11 Aug 2021 20:23:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxri0vz1C8dFRUmJIUTNidwykg+eDk8Nwx4EwLANMh4kFarSI6fxHbBC1+cB14MM5x9vm7Uww== X-Received: by 2002:a63:4b20:: with SMTP id y32mr1859066pga.382.1628738593676; Wed, 11 Aug 2021 20:23:13 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id m16sm8395422pjz.30.2021.08.11.20.23.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 20:23:13 -0700 (PDT) Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO To: Jakub Kicinski Cc: mst@redhat.com, davem@davemloft.net, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ivan@prestigetransportation.com, xiangxia.m.yue@gmail.com, willemb@google.com, edumazet@google.com References: <20210811081623.9832-1-jasowang@redhat.com> <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Jason Wang Message-ID: Date: Thu, 12 Aug 2021 11:23:04 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Content-Type: text/plain; charset=gbk; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ÔÚ 2021/8/12 ÉÏÎç6:17, Jakub Kicinski дµÀ: > On Wed, 11 Aug 2021 16:16:23 +0800 Jason Wang wrote: >> Try to fix this by using NETIF_F_GRO_HW instead so we're not >> guaranteed to be re-segmented as original. > This sentence may need rephrasing. Right, actually, I meant: Try to fix this by using NETIF_F_GRO_HW instead. But we're not sure the packet could be re-segmented to the exact original packet stream. Since it's really depends on the bakcend implementation. > >> Or we may want a new netdev >> feature like RX_GSO since the guest offloads for virtio-net is >> actually to receive GSO packet. >> >> Or we can try not advertise LRO is control guest offloads is not >> enabled. This solves the warning but will still slow down the traffic. > IMO gro-hw fits pretty well, patch looks good. If the re-segmentation is not a issue. I will post a formal patch. Thanks > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C7A4C4338F for ; Thu, 12 Aug 2021 03:23:24 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A2DD660EE2 for ; Thu, 12 Aug 2021 03:23:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A2DD660EE2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 65B6E401CF; Thu, 12 Aug 2021 03:23:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vyJoENzAtmJX; Thu, 12 Aug 2021 03:23:19 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by smtp2.osuosl.org (Postfix) with ESMTPS id F2BCF401B9; Thu, 12 Aug 2021 03:23:18 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id C3AA2C0010; Thu, 12 Aug 2021 03:23:18 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) by lists.linuxfoundation.org (Postfix) with ESMTP id 13D9BC000E for ; Thu, 12 Aug 2021 03:23:18 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id EF21240580 for ; Thu, 12 Aug 2021 03:23:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Authentication-Results: smtp4.osuosl.org (amavisd-new); dkim=pass (1024-bit key) header.d=redhat.com Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id Wc_toJxLNcSn for ; Thu, 12 Aug 2021 03:23:17 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by smtp4.osuosl.org (Postfix) with ESMTPS id 55C5E40560 for ; Thu, 12 Aug 2021 03:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628738595; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2m2roWrvbYZeRqtABbQ37PaOQOhXAkNprJbXopZhFmQ=; b=VIq3nocEpeEuejQkZpeAR55rmstvJxPFGpEUsNkclXXIBifXr6oVQUrZPU+P4D4HiaXwgH in+ps3Kcw8qkgQRK3IzKj5WKxnNZBsxhbFU2OgoY9z4XvFPGBKREhIfWdv0wbOhgh13Pfx z08c/cXKccS62q4hxzVpPqD4djVrSJc= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-11-Q68rgd4jM9a_MI9cy2fn6w-1; Wed, 11 Aug 2021 23:23:14 -0400 X-MC-Unique: Q68rgd4jM9a_MI9cy2fn6w-1 Received: by mail-pj1-f72.google.com with SMTP id v18-20020a17090abb92b0290178fa401bdcso3193797pjr.4 for ; Wed, 11 Aug 2021 20:23:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=2m2roWrvbYZeRqtABbQ37PaOQOhXAkNprJbXopZhFmQ=; b=j5b+5Q1y1NI5WVMndDQ6SHU6xO733h9y+FGPFbAQeSKo1Fg+sk52LdcW5zulGiiGvl r69H+KP+SsOGvE6pUme9biznjnLwI2e8N4lErFgakA+TZhLzoKdlaraN257op+5hEX39 R79uZB0YXCw7k3NBZbAj4oWIlwaWC9bCldekjZ5IddA8cEeYv6kujDRnKo09LW03+Pnc Tj7W3hmICjOlJL7vDuwX6Id7UaTnl0jNKcyGB+dk2YtEVWDr/1gtmyuSzQRwbtDDopkh c+HtNy9Ld1E+Ktm1kVnJoBhhIJ6fey9M1MB69nWVypXWmkXv37mVr0fiomc1DRJ3rYgz NucQ== X-Gm-Message-State: AOAM532z8qZybu12G+sdNyKzTDzlsotFsk3ALh0z+ulLXv3DYpsMbpb4 frL9Yn7487/0xNqQvGhG4hRMFbiakRzBTOnKgPS/jyFGosI+KaAwHJXI/8eO/UVvehaXhN5uxVb Rl1yEyu0/DlC2hHBA9bpo2vY3F3Lpbc0Cp2/j7tzSsw== X-Received: by 2002:a63:4b20:: with SMTP id y32mr1859083pga.382.1628738593901; Wed, 11 Aug 2021 20:23:13 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxri0vz1C8dFRUmJIUTNidwykg+eDk8Nwx4EwLANMh4kFarSI6fxHbBC1+cB14MM5x9vm7Uww== X-Received: by 2002:a63:4b20:: with SMTP id y32mr1859066pga.382.1628738593676; Wed, 11 Aug 2021 20:23:13 -0700 (PDT) Received: from wangxiaodeMacBook-Air.local ([209.132.188.80]) by smtp.gmail.com with ESMTPSA id m16sm8395422pjz.30.2021.08.11.20.23.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 20:23:13 -0700 (PDT) Subject: Re: [RFC PATCH] virtio-net: use NETIF_F_GRO_HW instead of NETIF_F_LRO To: Jakub Kicinski References: <20210811081623.9832-1-jasowang@redhat.com> <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Jason Wang Message-ID: Date: Thu, 12 Aug 2021 11:23:04 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210811151754.030a22a7@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=jasowang@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Cc: willemb@google.com, mst@redhat.com, netdev@vger.kernel.org, ivan@prestigetransportation.com, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, edumazet@google.com, davem@davemloft.net X-BeenThere: virtualization@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Linux virtualization List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="gbk"; Format="flowed" Errors-To: virtualization-bounces@lists.linux-foundation.org Sender: "Virtualization" CtTaIDIwMjEvOC8xMiDJz87nNjoxNywgSmFrdWIgS2ljaW5za2kg0LS1wDoKPiBPbiBXZWQsIDEx IEF1ZyAyMDIxIDE2OjE2OjIzICswODAwIEphc29uIFdhbmcgd3JvdGU6Cj4+IFRyeSB0byBmaXgg dGhpcyBieSB1c2luZyBORVRJRl9GX0dST19IVyBpbnN0ZWFkIHNvIHdlJ3JlIG5vdAo+PiBndWFy YW50ZWVkIHRvIGJlIHJlLXNlZ21lbnRlZCBhcyBvcmlnaW5hbC4KPiBUaGlzIHNlbnRlbmNlIG1h eSBuZWVkIHJlcGhyYXNpbmcuCgoKUmlnaHQsIGFjdHVhbGx5LCBJIG1lYW50OgoKClRyeSB0byBm aXggdGhpcyBieSB1c2luZyBORVRJRl9GX0dST19IVyBpbnN0ZWFkLiBCdXQgd2UncmUgbm90IHN1 cmUgdGhlIApwYWNrZXQgY291bGQgYmUgcmUtc2VnbWVudGVkIHRvIHRoZSBleGFjdCBvcmlnaW5h bCBwYWNrZXQgc3RyZWFtLiBTaW5jZSAKaXQncyByZWFsbHkgZGVwZW5kcyBvbiB0aGUgYmFrY2Vu ZCBpbXBsZW1lbnRhdGlvbi4KCgo+Cj4+IE9yIHdlIG1heSB3YW50IGEgbmV3IG5ldGRldgo+PiBm ZWF0dXJlIGxpa2UgUlhfR1NPIHNpbmNlIHRoZSBndWVzdCBvZmZsb2FkcyBmb3IgdmlydGlvLW5l dCBpcwo+PiBhY3R1YWxseSB0byByZWNlaXZlIEdTTyBwYWNrZXQuCj4+Cj4+IE9yIHdlIGNhbiB0 cnkgbm90IGFkdmVydGlzZSBMUk8gaXMgY29udHJvbCBndWVzdCBvZmZsb2FkcyBpcyBub3QKPj4g ZW5hYmxlZC4gVGhpcyBzb2x2ZXMgdGhlIHdhcm5pbmcgYnV0IHdpbGwgc3RpbGwgc2xvdyBkb3du IHRoZSB0cmFmZmljLgo+IElNTyBncm8taHcgZml0cyBwcmV0dHkgd2VsbCwgcGF0Y2ggbG9va3Mg Z29vZC4KCgpJZiB0aGUgcmUtc2VnbWVudGF0aW9uIGlzIG5vdCBhIGlzc3VlLiBJIHdpbGwgcG9z dCBhIGZvcm1hbCBwYXRjaC4KClRoYW5rcwoKCj4KCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClZpcnR1YWxpemF0aW9uIG1haWxpbmcgbGlzdApWaXJ0dWFs aXphdGlvbkBsaXN0cy5saW51eC1mb3VuZGF0aW9uLm9yZwpodHRwczovL2xpc3RzLmxpbnV4Zm91 bmRhdGlvbi5vcmcvbWFpbG1hbi9saXN0aW5mby92aXJ0dWFsaXphdGlvbg==