From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1740C433FE for ; Tue, 19 Apr 2022 06:31:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348821AbiDSGds (ORCPT ); Tue, 19 Apr 2022 02:33:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236895AbiDSGdr (ORCPT ); Tue, 19 Apr 2022 02:33:47 -0400 Received: from mail-ej1-x636.google.com (mail-ej1-x636.google.com [IPv6:2a00:1450:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6CA3B245BE for ; Mon, 18 Apr 2022 23:31:05 -0700 (PDT) Received: by mail-ej1-x636.google.com with SMTP id bv19so30823745ejb.6 for ; Mon, 18 Apr 2022 23:31:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=/rrLKvmQMfKWM71Vt4ACdmZv7rtrzaFdefyFe3yrPL0=; b=TxQpED75D37zNwWP0eZ4Dppk/q0LBcVqFM6ORmD7xS3vp6VttRdoUTzqm+XP5vOFB0 Ctlm47B6Emw1ElvrpbN9QjQq7etONKq0Fbe+h2PELH5bpevYVaHc0zL4bcpO5Qu1e8ng VBoBvyM85yJHIOcjSeDLAlGnhqt81eY9ktqQssIFMEbOujGk25Tjs0P1764K49T1dInS gq25ZkM3ab/TjSjwESqF2E+Q65bRBe48H/wOBG8hMorzLyEUchddko3rhab4wIHEZ4u2 Ed518cl9OebJFYVdZjYw+ib48Z0+1HgqZLZwbpyFngfqIxORmv7aMQjvtzynGBzn8m9q UGQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=/rrLKvmQMfKWM71Vt4ACdmZv7rtrzaFdefyFe3yrPL0=; b=d0pKytxX32AnInV14a2HE6p/vqOso3RSDYaJtgw9bgHw6rOqMeLYG4wW88zqmjuSRd X7e3ClijiujTTrLL3KBj3EeLwrDhCpKhss5WXfCxXT44YjN+Ps9AHOynFTQ6zvieHRzG iJupt4eKKZrGnM4vF0euH6rZxd+J5r5GOFUksHicC7FtLYy8/EFUghH7DBifXfoFO+Rb flMzUiVlikW880F+UfE5DRkHcbrOWNdDMb5Wt/d/UJ+pHI+SSKlU9Mqc1WOmA15/c0gP qb5SlFE5qpkgG+6ksYGmM1vjuq9OiXaYGRjGj4Y4tGzNrNDYx0cZlvQGYoN0skxoeDCp 6TDQ== X-Gm-Message-State: AOAM531mobqVE4mOKVtqhRl9nXvEmk0P7cWCCo9/kZr34wGSxh58opTr UtCo7yUgyuhvvt5xYIUdkj76nbnJzlc0ug== X-Google-Smtp-Source: ABdhPJzYgvXLYpatm5Bb1YZMvzLwkeUp5lptQM5SS++47h8EOa4UubW5sk4ag3uCpQcwEUHKYqtY7A== X-Received: by 2002:a17:907:1c9b:b0:6ef:5e62:fd62 with SMTP id nb27-20020a1709071c9b00b006ef5e62fd62mr10556403ejc.686.1650349863942; Mon, 18 Apr 2022 23:31:03 -0700 (PDT) Received: from [192.168.0.217] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id j2-20020a056402238200b0041f351a8b83sm7940834eda.43.2022.04.18.23.31.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Apr 2022 23:31:03 -0700 (PDT) Message-ID: Date: Tue, 19 Apr 2022 08:31:02 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH RESEND v2 1/9] dt-bindings: clk: qcom: msm8996-apcc: Add CBF Content-Language: en-US To: Yassine Oudjana Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Michael Turquette , Stephen Boyd , Ilia Lin , Viresh Kumar , Nishanth Menon , "Rafael J. Wysocki" , Konrad Dybcio , Dmitry Baryshkov , Loic Poulain , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, Yassine Oudjana , Rob Herring References: <20220416025637.83484-1-y.oudjana@protonmail.com> <20220416025637.83484-2-y.oudjana@protonmail.com> <813f4a3d-255b-0ec1-cc3e-a1280e4d74ae@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 18/04/2022 21:12, Yassine Oudjana wrote: > > On Mon, Apr 18 2022 at 18:04:08 +0200, Krzysztof Kozlowski > wrote: >> On 16/04/2022 04:56, Yassine Oudjana wrote: >>> Add CBF clock and reg. >>> >>> Signed-off-by: Yassine Oudjana >>> Acked-by: Rob Herring >>> --- >>> .../devicetree/bindings/clock/qcom,msm8996-apcc.yaml | 10 >>> ++++++---- >>> 1 file changed, 6 insertions(+), 4 deletions(-) >>> >>> diff --git >>> a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >>> b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >>> index a20cb10636dd..325f8aef53b2 100644 >>> --- a/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >>> +++ b/Documentation/devicetree/bindings/clock/qcom,msm8996-apcc.yaml >>> @@ -10,8 +10,8 @@ maintainers: >>> - Loic Poulain >>> >>> description: | >>> - Qualcomm CPU clock controller for MSM8996 CPUs, clock 0 is for >>> Power cluster >>> - and clock 1 is for Perf cluster. >>> + Qualcomm CPU clock controller for MSM8996 CPUs, clock 0 is for >>> Power cluster, >>> + clock 1 is for Perf cluster, and clock 2 is for Coherent bus >>> fabric (CBF). >>> >>> properties: >>> compatible: >>> @@ -19,7 +19,9 @@ properties: >>> - qcom,msm8996-apcc >>> >>> reg: >>> - maxItems: 1 >>> + items: >>> + - description: Cluster clock registers >>> + - description: CBF clock registers >> >> This breaks the ABI (which might be okay or might be not, but was not >> mentioned in the commit) and breaks existing DTSes. Please fix them >> before this patch. > > This is only documenting changes made in an earlier patch[1] this > series depends on, So this other patch breaks the ABI. Was it accepted? The patch you wrote here should go together with the clock change. > and the DTSes are fixed in another patch[2] that > is also listed as a dependency in the cover letter (both patches > aren't applied yet). Shouldn't the ABI changes should be mentioned in > those patches instead? They should be mentioned in the clock driver or here, because usually they come together. :) Best regards, Krzysztof