From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757491AbdLUCpG (ORCPT ); Wed, 20 Dec 2017 21:45:06 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:2710 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1755928AbdLUCpB (ORCPT ); Wed, 20 Dec 2017 21:45:01 -0500 Subject: Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver To: "lipeng (Y)" , David Miller CC: , , , , References: <1513759399-40915-1-git-send-email-lipeng321@huawei.com> <20171220.142843.568343410203899321.davem@davemloft.net> <5619d233-a0bc-3bd9-daf4-cffb5486b396@huawei.com> From: Hanjun Guo Message-ID: Date: Thu, 21 Dec 2017 10:43:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <5619d233-a0bc-3bd9-daf4-cffb5486b396@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.177.223.23] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2017/12/21 10:27, lipeng (Y) wrote: > > > On 2017/12/21 3:28, David Miller wrote: >> From: Lipeng >> Date: Wed, 20 Dec 2017 16:43:02 +0800 >> >>> This patchset adds some new feature support and fixes some bugs: >>> [Patch 1/17 - 5/17] add the support to modify/query the tqp number >>> through ethtool -L/l command, and also fix some related bugs for >>> change tqp number. >>> [Patch 6/17 - 9-17] add support vlan tag offload on tx&&rx direction >>> for pf, and fix some related bugs. >>> [patch 10/17 - 11/17] fix bugs for auto negotiation. >>> [patch 12/17] adds support for ethtool command set_pauseparam. >>> [patch 13/17 - 14/17] add support to update flow control settings after >>> autoneg. >>> [patch 15/17 - 17/17] fix some other bugs in net-next. >> In your From: email field, as well as you and your colleagues signoffs >> you are not using your full, real, name: >> >> ==================== >> From: Lipeng > > My first name is 'Peng' and Surname is 'Li'. > But it is usually spelled as 'Lipeng' in one go when referring. > This is quite usual convention with full names originating from > China. Surnames comes first, followed by the first name and they > both are inseparable while they are written as well. > "Lipeng" is my full real name,  and my sign-off's appear like above. > > > The name "lipeng"  is very common in china, many guys in HuaWei have the > same name "lipeng", > So my email is lipeng321@huawei.com,  to Distinguish from others. > > other guys who named "lipeng" in huawei ,  their email have an id too, > such as lipengxxx@huawei.com. > > Wish the explanation is clear. I think David was expecting two fixes here: - The first one is that the Author of the patch needs to match the first Signed-off-by in the patch. In your patches, lots of them show that you are the Author but qumingguang is in the first Signed-off-by. - It's better to use first name + last name: Peng Li Mingguang Qu Thanks Hanjun