From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7ECD0C64E7A for ; Tue, 1 Dec 2020 07:37:53 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F06982085B for ; Tue, 1 Dec 2020 07:37:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=suse.com header.i=@suse.com header.b="u6487MCv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F06982085B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=suse.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from list by lists.xenproject.org with outflank-mailman.41595.74859 (Exim 4.92) (envelope-from ) id 1kk0Dy-0007b9-MP; Tue, 01 Dec 2020 07:37:22 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 41595.74859; Tue, 01 Dec 2020 07:37:22 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kk0Dy-0007b2-Iv; Tue, 01 Dec 2020 07:37:22 +0000 Received: by outflank-mailman (input) for mailman id 41595; Tue, 01 Dec 2020 07:37:21 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1kk0Dx-0007ax-Aj for xen-devel@lists.xenproject.org; Tue, 01 Dec 2020 07:37:21 +0000 Received: from mx2.suse.de (unknown [195.135.220.15]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 04c375a3-03c1-445e-a4ed-35a27fca23cf; Tue, 01 Dec 2020 07:37:19 +0000 (UTC) Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id E3423AC2E; Tue, 1 Dec 2020 07:37:18 +0000 (UTC) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: 04c375a3-03c1-445e-a4ed-35a27fca23cf X-Virus-Scanned: by amavisd-new at test-mx.suse.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1606808239; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lrE4uA8nvH6aMb0GP+TFUfmyFpP1OeaCi17A0aEBzWQ=; b=u6487MCvE3DLDeLpdIXGZjdSP+CvF2hxukNhraKl8f6iZ3Gp+2anfLNNQAQe9K7B2ZWTmx HpU48HgFjR5cAsVxZWrSga+N9rHoIV13MTHWY2NykHPS8dhhSQCwWkbkgnMoQOL6zXfVTQ fb0eu6kqXAb4B0OhrSsbj/iLmKbF4VM= Subject: Re: [PATCH 04/16] x86/srat: vmap the pages for acpi_slit To: Hongyan Xia Cc: julien@xen.org, Andrew Cooper , Wei Liu , =?UTF-8?Q?Roger_Pau_Monn=c3=a9?= , xen-devel@lists.xenproject.org References: <8118aa61528cb14acab8a399bd483557bd3c921e.camel@xen.org> From: Jan Beulich Message-ID: Date: Tue, 1 Dec 2020 08:37:14 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <8118aa61528cb14acab8a399bd483557bd3c921e.camel@xen.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 30.11.2020 19:11, Hongyan Xia wrote: > On Mon, 2020-11-30 at 11:16 +0100, Jan Beulich wrote: >> On 30.04.2020 22:44, Hongyan Xia wrote: >>> --- a/xen/arch/x86/srat.c >>> +++ b/xen/arch/x86/srat.c >>> @@ -196,7 +196,8 @@ void __init acpi_numa_slit_init(struct >>> acpi_table_slit *slit) >>> return; >>> } >>> mfn = alloc_boot_pages(PFN_UP(slit->header.length), 1); >>> - acpi_slit = mfn_to_virt(mfn_x(mfn)); >>> + acpi_slit = vmap_boot_pages(mfn, PFN_UP(slit->header.length)); >>> + BUG_ON(!acpi_slit); >>> memcpy(acpi_slit, slit, slit->header.length); >>> } >> >> I'm not sure in how far this series is still to be considered >> active / pending; I still have it in my inbox as something to >> look at in any event. If it is, then I think the latest by this >> patch it becomes clear that we either want to make vmalloc() >> boot-allocator capable, or introduce e.g. vmalloc_boot(). >> Having this recurring pattern including the somewhat odd >> vmap_boot_pages() is imo not the best way forward. It would >> then also no longer be necessary to allocate contiguous pages, >> as none of the users up to here appear to have such a need. > > This series is blocked on the PTE domheap conversion series so I will > definitely come back here after that series is merged. > > vmap_boot_pages() (poorly named, there is nothing "boot" about it) is > actually useful in other patches as well, especially when there is no > direct map but we need to map a contiguous range, since > map_domain_page() can only handle a single one. So I would say there > will be a need for this function (maybe call it vmap_contig_pages()?) > even if for this patch a boot-capable vmalloc can do the job. Question is in how many cases contiguous allocations are actually needed. I suspect there aren't many, and hence vmalloc() (or a boot time clone of it, if need be) may again be the better choice. Jan