From: Lars-Peter Clausen <lars@metafoo.de>
To: jic23@kernel.org, linux-iio@vger.kernel.org, knaack.h@gmx.de,
pmeerw@pmeerw.net, dmitry.torokhov@gmail.com,
michael.hennerich@analog.com, daniel.baluta@gmail.com,
amsfield22@gmail.com, florian.vaussard@heig-vd.ch,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/4] iio: accel: adxl345: Add ACPI support
Date: Mon, 20 Feb 2017 13:07:38 +0100 [thread overview]
Message-ID: <aa845fa1-4689-cdac-bbf5-0bab19e003dd@metafoo.de> (raw)
In-Reply-To: <20170219121506.GA3856@Socrates-UM>
On 02/19/2017 01:15 PM, Eva Rachel Retuya wrote:
> On Sun, Feb 19, 2017 at 11:01:23AM +0100, Lars-Peter Clausen wrote:
>> On 02/16/2017 11:02 AM, Eva Rachel Retuya wrote:
>> [...]
>>> @@ -54,9 +55,17 @@ static const struct i2c_device_id adxl345_i2c_id[] = {
>>>
>>> MODULE_DEVICE_TABLE(i2c, adxl345_i2c_id);
>>>
>>> +static const struct acpi_device_id adxl345_acpi_id[] = {
>>> + { "ADX0345", 0 },
>>
>> Who allocated this ID? ADX does not seem to be a registered vendor ID
>> (http://www.uefi.org/PNP_ACPI_Registry).
>>
>
> Hello Lars,
>
> Pardon the ignorance. I was not aware of this when I set it like that.
> Is "ADS0345" OK? Will submit a new version with that ID.
Excellent question. ACPI is not like devicetree where we can just randomly
choose IDs. The namespaces are more controlled. The vendor IDs are managed
and allocated by the UEFI forum, each vendor then allocates device IDs in
its vendor namespace for specific purposes. Unless you own a vendor ID or
the device ID has been allocated by the vendor for you you shouldn't use the ID.
If you have a ACPI based system which features the adxl345 maybe using
PRP0001[1] might be the better approach.
- Lars
[1] https://www.kernel.org/doc/Documentation/acpi/enumeration.txt
next prev parent reply other threads:[~2017-02-20 12:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 10:02 [PATCH 0/4] iio: accel: adxl345: Split driver into core and I2C then add SPI support Eva Rachel Retuya
2017-02-16 10:02 ` [PATCH 1/4] iio: accel: adxl345: Use I2C regmap instead of direct I2C access Eva Rachel Retuya
2017-02-19 13:04 ` Jonathan Cameron
2017-02-16 10:02 ` [PATCH 2/4] iio: accel: adxl345: Split driver into core and I2C Eva Rachel Retuya
2017-02-19 13:11 ` Jonathan Cameron
2017-02-20 6:41 ` Eva Rachel Retuya
2017-02-20 9:32 ` Eva Rachel Retuya
2017-02-20 11:47 ` Andy Shevchenko
2017-02-16 10:02 ` [PATCH 3/4] iio: accel: adxl345: Add SPI support Eva Rachel Retuya
2017-02-19 13:12 ` Jonathan Cameron
2017-02-20 6:46 ` Eva Rachel Retuya
2017-02-16 10:02 ` [PATCH 4/4] iio: accel: adxl345: Add ACPI support Eva Rachel Retuya
2017-02-19 10:01 ` Lars-Peter Clausen
2017-02-19 12:15 ` Eva Rachel Retuya
2017-02-20 12:07 ` Lars-Peter Clausen [this message]
2017-02-21 15:18 ` Eva Rachel Retuya
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa845fa1-4689-cdac-bbf5-0bab19e003dd@metafoo.de \
--to=lars@metafoo.de \
--cc=amsfield22@gmail.com \
--cc=daniel.baluta@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=florian.vaussard@heig-vd.ch \
--cc=jic23@kernel.org \
--cc=knaack.h@gmx.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.hennerich@analog.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.