From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91391C433F5 for ; Wed, 4 May 2022 18:41:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355848AbiEDSov (ORCPT ); Wed, 4 May 2022 14:44:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42976 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236247AbiEDSot (ORCPT ); Wed, 4 May 2022 14:44:49 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 696876462 for ; Wed, 4 May 2022 11:41:12 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id i10so3814445lfg.13 for ; Wed, 04 May 2022 11:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wTxln7YGVkX89i8PG0IKXfsso9aaC9QMWGmO6EX/EGY=; b=z2Ctxr3w9cDEGS/IXiaRNEtZDn6Wv0POATksyAG9keUZE2UBpjRpqxqEhe03gIVezk JUHIQzyf/0MFa26gN3hi0g8FHd/HHXCynEgpy2M5H7LEO8cPdG9LbSNWy4iMxvJh/joQ KVsH9tDJmcqntkqGTL3cxSgFiPZgi+CX0jvzztvuwLE5KOCWpXjvHU8Nm3OXF7d/+Kop MaDt4RjNKWP6xsVrGhiEed3Zu7Y1eH3v+cMbJ04VzT7yPGJHlsXkTiyp1XYyofqvPaQi QbrsqXxwYv8AvPL0L/DqQxBoG7tz9RBWjz0w9SJu5p2yT+8+8vehbDyH1X46CuUQ+MW9 mCgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wTxln7YGVkX89i8PG0IKXfsso9aaC9QMWGmO6EX/EGY=; b=6GW7in7ib5a6w6D0mIVCRpqVsbm5rSg3GE1GXWLEBpT4T/3JLfanUoawvio/0151MT 8Xdc969IeyC6JK24dN39YHt8SEeKmbUqvQTT23ESyKZB2w4dlvhvT/QCVwdptBgoa+t4 Q6cJaIu64N5a2ETBhf5LFGpf7dyHrgvNICwkTyNJHNUoMads1eUhICcvUe/+rsQ8Bjrf ltGID3QynstVAtIctPRC+ffz8H8MthOLypugAvV7oBfDzGOKyvo5zLTlE9PpYRD6Mozd x/Hd3sfGPF4CSvoDcUCaySsVdtvTp0l8RUnCQUxiHzYqoHZWa5vRmvr3i7Fv9b7tZSCL SrMQ== X-Gm-Message-State: AOAM5301E7qJJClZ9bppaYhT2HL6Gm1sDJdAnpoiZXWOtrq1qXRDuECy IqEEugcyPZk/KiTpTYc0Ad9NGQ== X-Google-Smtp-Source: ABdhPJy4zg1hpUl4Auyu5EEfhi6Mx+a0yiiys0cRdUGvJh5KnPLpnHF/RaEZ9+x6pGoF15y0uGxIGA== X-Received: by 2002:a05:6512:683:b0:473:a110:e52 with SMTP id t3-20020a056512068300b00473a1100e52mr8290893lfe.412.1651689670755; Wed, 04 May 2022 11:41:10 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id s15-20020ac25fef000000b0047255d2115esm1274090lfg.141.2022.05.04.11.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 May 2022 11:41:10 -0700 (PDT) Message-ID: Date: Wed, 4 May 2022 21:41:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] drm/msm: Limit command submission when no IOMMU Content-Language: en-GB To: Rob Clark , dri-devel@lists.freedesktop.org Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Luca Weiss , Rob Clark , Sean Paul , Abhinav Kumar , David Airlie , Daniel Vetter , open list References: <20220502172908.3569799-1-robdclark@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220502172908.3569799-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 02/05/2022 20:29, Rob Clark wrote: > From: Rob Clark > > Running the GPU without an IOMMU is not really a supported (or sane) > configuration. Yet it can be useful during SoC bringup (ie. if the > iommu driver doesn't work yet). > > Lets limit it to users who already have /dev/mem access, to avoid the > chance that a user accidentially configures kernel without IOMMU > support. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index 23b68bc945f6..9cd8c8708990 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, > if (args->pad) > return -EINVAL; > > + if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) { > + DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n"); > + return -EPERM; > + } > + > /* for now, we just have 3d pipe.. eventually this would need to > * be more clever to dispatch to appropriate gpu module: > */ -- With best wishes Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6F06FC433F5 for ; Wed, 4 May 2022 18:41:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2037810EAB0; Wed, 4 May 2022 18:41:13 +0000 (UTC) Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6D36A10EAB0 for ; Wed, 4 May 2022 18:41:12 +0000 (UTC) Received: by mail-lf1-x132.google.com with SMTP id t25so3843717lfg.7 for ; Wed, 04 May 2022 11:41:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=wTxln7YGVkX89i8PG0IKXfsso9aaC9QMWGmO6EX/EGY=; b=z2Ctxr3w9cDEGS/IXiaRNEtZDn6Wv0POATksyAG9keUZE2UBpjRpqxqEhe03gIVezk JUHIQzyf/0MFa26gN3hi0g8FHd/HHXCynEgpy2M5H7LEO8cPdG9LbSNWy4iMxvJh/joQ KVsH9tDJmcqntkqGTL3cxSgFiPZgi+CX0jvzztvuwLE5KOCWpXjvHU8Nm3OXF7d/+Kop MaDt4RjNKWP6xsVrGhiEed3Zu7Y1eH3v+cMbJ04VzT7yPGJHlsXkTiyp1XYyofqvPaQi QbrsqXxwYv8AvPL0L/DqQxBoG7tz9RBWjz0w9SJu5p2yT+8+8vehbDyH1X46CuUQ+MW9 mCgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=wTxln7YGVkX89i8PG0IKXfsso9aaC9QMWGmO6EX/EGY=; b=v+GjDhLKIkdG41vZZ1Z6E6ah6lr7dU+GmwfnUBp3ET6wpjUiHRfTgJQZhICrrcSRVl JrYjnC7JBlxLR8fDo5jWFZTjSuqbRRVu0tvC5ejM9va0ozEZae5M7u8PI3FNlxWOo9tH xgvPX0Na02fkAWq181ZZ8h6tg29FjrwYrnIn/4+iuT4Qm0DrghySIplY0rgHWbaegNv7 f4WIpX4UrLeZCfeSNzKJMxMUCpYu+XgTVWf6Dfo/eofp09a+X1PpkL8y87/p/fVzESGd 0v84v9oYYDH23WHK5M5SqdKO0129/US3Ai0O/HqMEhvV7xhRDskj+ZNhFJggKibc8GTP NteQ== X-Gm-Message-State: AOAM532+ScL9o27Xk+PZ8Z9Ojpj2flNlXfbhyxtg4kePGkrXYYRMOcf0 K8FyXjCsQGCF9xICY5YFTtSmjNu/KOfpqA== X-Google-Smtp-Source: ABdhPJy4zg1hpUl4Auyu5EEfhi6Mx+a0yiiys0cRdUGvJh5KnPLpnHF/RaEZ9+x6pGoF15y0uGxIGA== X-Received: by 2002:a05:6512:683:b0:473:a110:e52 with SMTP id t3-20020a056512068300b00473a1100e52mr8290893lfe.412.1651689670755; Wed, 04 May 2022 11:41:10 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id s15-20020ac25fef000000b0047255d2115esm1274090lfg.141.2022.05.04.11.41.09 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 May 2022 11:41:10 -0700 (PDT) Message-ID: Date: Wed, 4 May 2022 21:41:09 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] drm/msm: Limit command submission when no IOMMU Content-Language: en-GB To: Rob Clark , dri-devel@lists.freedesktop.org References: <20220502172908.3569799-1-robdclark@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20220502172908.3569799-1-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , freedreno@lists.freedesktop.org, David Airlie , linux-arm-msm@vger.kernel.org, Abhinav Kumar , open list , Luca Weiss , Sean Paul Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 02/05/2022 20:29, Rob Clark wrote: > From: Rob Clark > > Running the GPU without an IOMMU is not really a supported (or sane) > configuration. Yet it can be useful during SoC bringup (ie. if the > iommu driver doesn't work yet). > > Lets limit it to users who already have /dev/mem access, to avoid the > chance that a user accidentially configures kernel without IOMMU > support. > > Signed-off-by: Rob Clark Reviewed-by: Dmitry Baryshkov > --- > drivers/gpu/drm/msm/msm_gem_submit.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/msm/msm_gem_submit.c b/drivers/gpu/drm/msm/msm_gem_submit.c > index 23b68bc945f6..9cd8c8708990 100644 > --- a/drivers/gpu/drm/msm/msm_gem_submit.c > +++ b/drivers/gpu/drm/msm/msm_gem_submit.c > @@ -734,6 +734,11 @@ int msm_ioctl_gem_submit(struct drm_device *dev, void *data, > if (args->pad) > return -EINVAL; > > + if (unlikely(!ctx->aspace) && !capable(CAP_SYS_RAWIO)) { > + DRM_ERROR_RATELIMITED("IOMMU support or CAP_SYS_RAWIO required!\n"); > + return -EPERM; > + } > + > /* for now, we just have 3d pipe.. eventually this would need to > * be more clever to dispatch to appropriate gpu module: > */ -- With best wishes Dmitry