All of lore.kernel.org
 help / color / mirror / Atom feed
From: Changqing Li <changqing.li@windriver.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>,
	William Bourque <wbourque@gmail.com>,
	<openembedded-core@lists.openembedded.org>
Subject: Re: ✗ patchtest: failure for wic/plugins: Source that support both EFI and BIOS
Date: Thu, 4 Jul 2019 17:02:55 +0800	[thread overview]
Message-ID: <aaa7a2fe-b44e-8495-4759-4479ca51a505@windriver.com> (raw)
In-Reply-To: <ab85111307d8ed9b93c0fb8026a91ae5f24c4ed3.camel@linuxfoundation.org>


On 7/3/19 3:51 PM, Richard Purdie wrote:
> On Tue, 2019-07-02 at 15:22 -0400, William Bourque wrote:
>> Hi,
>>
>> The error "scripts/lib/wic/plugins/source/bootimg-biosplusefi.py does
>> not exist" is a bit puzzling : this is the new file my patch is
>> adding.
>> Is this test failure expected for new files?
>>
>> I sent this using git-sendmail; should I submit using a different way
>> (pull request, ...)?
> I think the test is broken so we can ignore that. I've cc'd Sandy so
> she might be able to look into this issue if possible as we've seen it
> a few times.

I checked the test case,  and current test only support modified file well,

for new add file,  enhancement is needed, I have file a bug in bugzilla,

I will fix this when have time.

>
> What I did wonder is whether we should be adding some tests to wic for
> this new plugin though?
>
> The existing tests are in meta/lib/oeqa/selftest/cases/wic.py and can
> be run with "oe-selftest -r wic", would it make sense to add something
> to this as part of this change?
>
> Cheers,
>
> Richard
>
>
-- 
BRs

Sandy(Li Changqing)



  reply	other threads:[~2019-07-04  9:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-02 18:24 [PATCH] wic/plugins: Source that support both EFI and BIOS wbourque
2019-07-02 18:30 ` ✗ patchtest: failure for " Patchwork
2019-07-02 19:22   ` William Bourque
2019-07-03  7:51     ` Richard Purdie
2019-07-04  9:02       ` Changqing Li [this message]
2019-07-04  9:03       ` Changqing Li
2019-07-04 16:29       ` William Bourque

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aaa7a2fe-b44e-8495-4759-4479ca51a505@windriver.com \
    --to=changqing.li@windriver.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=richard.purdie@linuxfoundation.org \
    --cc=wbourque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.