* [PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation
@ 2021-03-09 15:19 Paolo Bonzini
2021-03-09 16:22 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2021-03-09 15:19 UTC (permalink / raw)
To: qemu-devel
gen_semantics is an executable, not an input. Meson 0.57 special cases
the first argument and @INPUT@ is not expanded there. Fix that by
not including it in the input, only in the command.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target/hexagon/meson.build | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/target/hexagon/meson.build b/target/hexagon/meson.build
index 15318a6fa7..8724f8f1fb 100644
--- a/target/hexagon/meson.build
+++ b/target/hexagon/meson.build
@@ -33,8 +33,7 @@ gen_semantics = executable(
semantics_generated = custom_target(
'semantics_generated.pyinc',
output: 'semantics_generated.pyinc',
- input: gen_semantics,
- command: ['@INPUT@', '@OUTPUT@'],
+ command: [gen_semantics, '@OUTPUT@'],
)
hexagon_ss.add(semantics_generated)
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation
2021-03-09 15:19 [PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation Paolo Bonzini
@ 2021-03-09 16:22 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2021-03-09 16:22 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel
On 3/9/21 7:19 AM, Paolo Bonzini wrote:
> gen_semantics is an executable, not an input. Meson 0.57 special cases
> the first argument and @INPUT@ is not expanded there. Fix that by
> not including it in the input, only in the command.
>
> Signed-off-by: Paolo Bonzini<pbonzini@redhat.com>
> ---
> target/hexagon/meson.build | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-03-09 18:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-09 15:19 [PATCH] hexagon: do not specify inputs to semantics_generated.pyinc generation Paolo Bonzini
2021-03-09 16:22 ` Richard Henderson
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.