All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>, CTLIN0 <CTLIN0@nuvoton.com>
Cc: ALSA development <alsa-devel@alsa-project.org>,
	YHCHuang@nuvoton.com, WTLI@nuvoton.com, KCHSU0@nuvoton.com,
	Liam Girdwood <lgirdwood@gmail.com>,
	Tzung-Bi Shih <tzungbi@google.com>
Subject: Re: [PATCH] ASoC: nau8315: add codec driver
Date: Fri, 6 Nov 2020 08:57:51 -0600	[thread overview]
Message-ID: <aab83231-c2fb-364f-c512-5f74f34174db@linux.intel.com> (raw)
In-Reply-To: <20201106122058.GC49612@sirena.org.uk>



On 11/6/20 6:20 AM, Mark Brown wrote:
> On Fri, Nov 06, 2020 at 11:31:36AM +0800, CTLIN0 wrote:
> 
>> Thanks for your comments. However, I also agree the opinion from
>> Tzung-Bi Shih @ Google.
>> May I confirm whether I should keep this patch, and remove dapm widget
>> of EN_PIN next patch?
> 
> Please send incremental patches on top of this one with any changes.

EN_PIN is not strictly required but as discussed it provides additional 
flexibility for machine drivers, so probably better to keep it?

  reply	other threads:[~2020-11-06 14:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-02  2:32 [PATCH] ASoC: nau8315: add codec driver David Lin
2020-11-02 14:42 ` Pierre-Louis Bossart
2020-11-04 11:49   ` CTLIN0
2020-11-04 14:51     ` Pierre-Louis Bossart
2020-11-05  2:20       ` Tzung-Bi Shih
2020-11-05 15:02         ` Mark Brown
2020-11-05 16:21           ` Pierre-Louis Bossart
2020-11-06  3:31             ` CTLIN0
2020-11-06 12:20               ` Mark Brown
2020-11-06 14:57                 ` Pierre-Louis Bossart [this message]
2020-11-10  9:58 ` [PATCH 2/2] ASoC: nau8315: revise the power event of EN_PIN dapm widget for symmetry David Lin
2020-11-10 16:02 ` [PATCH] ASoC: nau8315: add codec driver Mark Brown
  -- strict thread matches above, loose matches on Subject: below --
2020-10-30  5:01 David Lin
2020-10-30 13:25 ` Mark Brown
2020-11-01  5:59   ` CTLIN0
2020-10-29 11:33 David Lin
2020-10-29 12:46 ` Mark Brown
2020-10-30  5:00   ` CTLIN0
2020-10-30 12:56     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aab83231-c2fb-364f-c512-5f74f34174db@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=CTLIN0@nuvoton.com \
    --cc=KCHSU0@nuvoton.com \
    --cc=WTLI@nuvoton.com \
    --cc=YHCHuang@nuvoton.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=tzungbi@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.