From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guoqing Jiang Subject: Re: [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private Date: Fri, 1 May 2020 08:41:37 +0200 Message-ID: References: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> <20200430214450.10662-2-guoqing.jiang@cloud.ionos.com> <20200430221338.GY29705@bombadil.infradead.org> <20200501014229.GB23230@ZenIV.linux.org.uk> <20200501014954.GC23230@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20200501014954.GC23230@ZenIV.linux.org.uk> Content-Language: en-US Sender: linux-fsdevel-owner@vger.kernel.org To: Al Viro , Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, Andrew Morton , "Darrick J. Wong" , William Kucharski , "Kirill A. Shutemov" , Andreas Gruenbacher , Yang Shi , Yafang Shao , Song Liu , linux-raid@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Anton Altaparmakov , linux-ntfs-dev@l List-Id: linux-raid.ids On 5/1/20 3:49 AM, Al Viro wrote: > On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote: >> On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote: >> >>>> +/** >>>> + * clear_page_private - clear page's private field and PG_private. >>>> + * @page: page to be cleared. >>>> + * >>>> + * The counterpart function of attach_page_private. >>>> + * Return: private data of page or NULL if page doesn't have private data. >>>> + */ >>> Seems to me that the opposite of "attach" is "detach", not "clear". >> Or "remove", perhaps... > Actually, "detach" is better - neither "clear" nor "remove" imply "... and give > me what used to be attached there", as this thing is doing. Ok, seems we have reached the agreement about the new name ;-), will follow the instruction. Thanks & Regards, Guoqing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9FCEC47254 for ; Fri, 1 May 2020 06:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9766E2192A for ; Fri, 1 May 2020 06:41:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="GqsIZQEE" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728204AbgEAGlm (ORCPT ); Fri, 1 May 2020 02:41:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728126AbgEAGll (ORCPT ); Fri, 1 May 2020 02:41:41 -0400 Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 276C6C035494 for ; Thu, 30 Apr 2020 23:41:41 -0700 (PDT) Received: by mail-wm1-x342.google.com with SMTP id h4so5002681wmb.4 for ; Thu, 30 Apr 2020 23:41:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=GqsIZQEErtxp95UJWpKrQY3O4F4Sx0g6/X7lDuIF3bXx91ATcAP7/DgLZaXrIRReWa znotQmlfvGIU7bhOau/vG2ipCW6ay1jPpHU3dkPnfckc/TMFNyCGl5XeXfWbalOtQFX6 gHm3zFY30ObZXefKrk/18Gy2OZL756D02eheTA1eXn1hgUUuYr/zXY5w9hicdvsi4iBD i020Okt4saC0RwlJrU73As1XgAjtDLrTAZicCsFsg88M5CUlGGFssxUDRySCbpKtqxbR BDN9qezqrIubk6PtQC5phFq9yawZi0lU9ffYH6Pj6n7nOgRjbcS5uv/clrIpOkDaYgOd H9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=Gn/4zkoexMzzAW1Z4w4z5wJmpWwQ+0dzo9pALdWPRq5HSLpFWfrp5kkJZKVzWIMu31 moq4ZlWDUWYXd+ivVFCbmelhSnmYpKbCL0YAfF8m1MYaUASJ5REA6Tc99nZ2EwzdiBFJ CwJGprt9zYobnLkWuV15Jx+FDv5NkePQLYimb3yM81EbnVsVUPa0b/MA20AqcV6PQfHX ce0jQcsn9L3xl7Wne10tTVD0PRZfF7ObzH1ACw2htMwfuS6fNPvYKJegv1ZX7DCGUs/i 64Monxjf5LJDNl1EjWVhXw0lWf08HR8k6934OFVPHmJ5gCi2t/aay6u8EeaXgpytxZI8 bJCg== X-Gm-Message-State: AGi0PuYKvjNkkhEZH+W275eUTBCoUSWU1KcLiV59sZTYOXpIwx6i1FSp 7u+Fu7zdqd2ILfFjMIKQb9Eyyg== X-Google-Smtp-Source: APiQypJhB8+PWaUoN3to5dH+glY2Sg5fXS6DS+6PXPXyjLj6QnarNlU5QbgDxRGc63eafm6Rtglqrg== X-Received: by 2002:a1c:e302:: with SMTP id a2mr2364418wmh.96.1588315299701; Thu, 30 Apr 2020 23:41:39 -0700 (PDT) Received: from ?IPv6:2001:16b8:48db:9b00:e80e:f5df:f780:7d57? ([2001:16b8:48db:9b00:e80e:f5df:f780:7d57]) by smtp.gmail.com with ESMTPSA id u127sm2576769wme.8.2020.04.30.23.41.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 23:41:39 -0700 (PDT) Subject: Re: [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private To: Al Viro , Matthew Wilcox Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, david@fromorbit.com, Andrew Morton , "Darrick J. Wong" , William Kucharski , "Kirill A. Shutemov" , Andreas Gruenbacher , Yang Shi , Yafang Shao , Song Liu , linux-raid@vger.kernel.org, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, Jaegeuk Kim , Chao Yu , linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, Anton Altaparmakov , linux-ntfs-dev@lists.sourceforge.net, Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org, Thomas Gleixner , Sebastian Andrzej Siewior , Roman Gushchin , Andreas Dilger References: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> <20200430214450.10662-2-guoqing.jiang@cloud.ionos.com> <20200430221338.GY29705@bombadil.infradead.org> <20200501014229.GB23230@ZenIV.linux.org.uk> <20200501014954.GC23230@ZenIV.linux.org.uk> From: Guoqing Jiang Message-ID: Date: Fri, 1 May 2020 08:41:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200501014954.GC23230@ZenIV.linux.org.uk> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-btrfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-btrfs@vger.kernel.org On 5/1/20 3:49 AM, Al Viro wrote: > On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote: >> On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote: >> >>>> +/** >>>> + * clear_page_private - clear page's private field and PG_private. >>>> + * @page: page to be cleared. >>>> + * >>>> + * The counterpart function of attach_page_private. >>>> + * Return: private data of page or NULL if page doesn't have private data. >>>> + */ >>> Seems to me that the opposite of "attach" is "detach", not "clear". >> Or "remove", perhaps... > Actually, "detach" is better - neither "clear" nor "remove" imply "... and give > me what used to be attached there", as this thing is doing. Ok, seems we have reached the agreement about the new name ;-), will follow the instruction. Thanks & Regards, Guoqing From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60369C47254 for ; Fri, 1 May 2020 07:06:07 +0000 (UTC) Received: from lists.sourceforge.net (lists.sourceforge.net [216.105.38.7]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 23D7E20787 for ; Fri, 1 May 2020 07:06:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sourceforge.net header.i=@sourceforge.net header.b="maSCOgZe"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sf.net header.i=@sf.net header.b="EMN/xxeJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cloud.ionos.com header.i=@cloud.ionos.com header.b="GqsIZQEE" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 23D7E20787 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cloud.ionos.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linux-f2fs-devel-bounces@lists.sourceforge.net Received: from [127.0.0.1] (helo=sfs-ml-1.v29.lw.sourceforge.com) by sfs-ml-1.v29.lw.sourceforge.com with esmtp (Exim 4.90_1) (envelope-from ) id 1jUPkM-0001kL-MF; Fri, 01 May 2020 07:06:06 +0000 Received: from [172.30.20.202] (helo=mx.sourceforge.net) by sfs-ml-1.v29.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jUPkL-0001k5-2D for linux-f2fs-devel@lists.sourceforge.net; Fri, 01 May 2020 07:06:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sourceforge.net; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=maSCOgZe9EJ2sU/uP4UW1qCSoV R5QTK2pWgJePZIwwAjCCFkqEL4BQ+/xCWqm1QOwgWwQZcVuQugLEHqmZu3/tmGn2UkOKqZEz5O+Sh 7/0xLPF8UdhyA/YKClbFIdu03d45oBG4jsO7vuQxwcOkBQ4P40aocAe4kR9YJK8Pbmjs=; DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sf.net; s=x ; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=EMN/xxeJaBPhBJlU9iyC6ZVlFo h7my6zFWOhMo9+NluUkZ5c8KnlXA3ZhAvv4eHOr2pqqQgypEyC4qNQi9OCWKyC14UgXFBwui0vqIA dsWi25UobIr7bV6viZhsHrUx1wwYpRTpdSPhXzRLt3qW+nlKprZNL79P+GpX/goJVkJM=; Received: from mail-wm1-f68.google.com ([209.85.128.68]) by sfi-mx-1.v28.lw.sourceforge.com with esmtps (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.92.2) id 1jUPkJ-006LjT-2N for linux-f2fs-devel@lists.sourceforge.net; Fri, 01 May 2020 07:06:05 +0000 Received: by mail-wm1-f68.google.com with SMTP id u127so5413331wmg.1 for ; Fri, 01 May 2020 00:06:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cloud.ionos.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=GqsIZQEErtxp95UJWpKrQY3O4F4Sx0g6/X7lDuIF3bXx91ATcAP7/DgLZaXrIRReWa znotQmlfvGIU7bhOau/vG2ipCW6ay1jPpHU3dkPnfckc/TMFNyCGl5XeXfWbalOtQFX6 gHm3zFY30ObZXefKrk/18Gy2OZL756D02eheTA1eXn1hgUUuYr/zXY5w9hicdvsi4iBD i020Okt4saC0RwlJrU73As1XgAjtDLrTAZicCsFsg88M5CUlGGFssxUDRySCbpKtqxbR BDN9qezqrIubk6PtQC5phFq9yawZi0lU9ffYH6Pj6n7nOgRjbcS5uv/clrIpOkDaYgOd H9Xw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=cpQ8/VzVs0qy6Coq4jsY7ccdDFl3LgDWXkhtB9YYQco=; b=O6lnPLKRWnXNbzvK8uzSrUUbvHEBXFpWYl3CmgoczXN+4nTct6fSzQwEErYmLsW/x4 sbm9ydPjngvDD7avWaHY8H28Mb12kSEfwN6o1bJiC8ONLSyJmDFqT8NZbxurciL2HqnL 95lLOwlYFHr4WxxhQM3p/NKyES4BZUdxC5/jD0QCZfQYN/DKx/ike7Qf4fLSY8CoWvDU BCbuLhMUI1NND+yLES8IPHVKUH36XLg9kpuRjwSDEi8px6NLzC7iK+R7XsqSeDyCTjPI sgksVnQyiC0AGeDFs2zoCgrBSm8WAUnJ5vHDa9ptqJ85rZuiCVq+EPLxNkvWpN1vvr7U Rg1Q== X-Gm-Message-State: AGi0PuYYJ+J7ZcdaC4MZAQZKu4GMtQSxHM3Mv4j9ka9J7EdTiaLZPRnU elrQZKGg3PjfedO6lRmIACupmL8QMdgD9Cku X-Google-Smtp-Source: APiQypJhB8+PWaUoN3to5dH+glY2Sg5fXS6DS+6PXPXyjLj6QnarNlU5QbgDxRGc63eafm6Rtglqrg== X-Received: by 2002:a1c:e302:: with SMTP id a2mr2364418wmh.96.1588315299701; Thu, 30 Apr 2020 23:41:39 -0700 (PDT) Received: from ?IPv6:2001:16b8:48db:9b00:e80e:f5df:f780:7d57? ([2001:16b8:48db:9b00:e80e:f5df:f780:7d57]) by smtp.gmail.com with ESMTPSA id u127sm2576769wme.8.2020.04.30.23.41.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Apr 2020 23:41:39 -0700 (PDT) To: Al Viro , Matthew Wilcox References: <20200430214450.10662-1-guoqing.jiang@cloud.ionos.com> <20200430214450.10662-2-guoqing.jiang@cloud.ionos.com> <20200430221338.GY29705@bombadil.infradead.org> <20200501014229.GB23230@ZenIV.linux.org.uk> <20200501014954.GC23230@ZenIV.linux.org.uk> From: Guoqing Jiang Message-ID: Date: Fri, 1 May 2020 08:41:37 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200501014954.GC23230@ZenIV.linux.org.uk> Content-Language: en-US X-Headers-End: 1jUPkJ-006LjT-2N Subject: Re: [f2fs-dev] [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private X-BeenThere: linux-f2fs-devel@lists.sourceforge.net X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Martin Brandenburg , Sebastian Andrzej Siewior , david@fromorbit.com, Song Liu , Yafang Shao , Mike Marshall , Andreas Gruenbacher , "Darrick J. Wong" , Chris Mason , hch@infradead.org, devel@lists.orangefs.org, Josef Bacik , linux-raid@vger.kernel.org, David Sterba , Jaegeuk Kim , Thomas Gleixner , Anton Altaparmakov , Andreas Dilger , Yang Shi , William Kucharski , linux-ntfs-dev@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-xfs@vger.kernel.org, "Kirill A. Shutemov" , linux-fsdevel@vger.kernel.org, Andrew Morton , Roman Gushchin , linux-btrfs@vger.kernel.org Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: linux-f2fs-devel-bounces@lists.sourceforge.net On 5/1/20 3:49 AM, Al Viro wrote: > On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote: >> On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote: >> >>>> +/** >>>> + * clear_page_private - clear page's private field and PG_private. >>>> + * @page: page to be cleared. >>>> + * >>>> + * The counterpart function of attach_page_private. >>>> + * Return: private data of page or NULL if page doesn't have private data. >>>> + */ >>> Seems to me that the opposite of "attach" is "detach", not "clear". >> Or "remove", perhaps... > Actually, "detach" is better - neither "clear" nor "remove" imply "... and give > me what used to be attached there", as this thing is doing. Ok, seems we have reached the agreement about the new name ;-), will follow the instruction. Thanks & Regards, Guoqing _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel